| Message ID | 20250411003209.44053-3-shannon.nelson@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | pds_core: updates and fixes | expand |
On Thu, 10 Apr 2025 17:32:06 -0700 Shannon Nelson wrote: > Fix the kernel-doc complaint > include/linux/pds/pds_adminq.h:481: warning: Excess struct member 'name' description in 'pds_core_lif_getattr_comp' > > Fixes: 45d76f492938 ("pds_core: set up device and adminq") How is this a bug fix? The warnings are only generated on W=1 builds. Please be more considerate of folks maintaining stable trees. There's no need to waste their time with patches like this.
On 4/14/2025 5:36 PM, Jakub Kicinski wrote: > > On Thu, 10 Apr 2025 17:32:06 -0700 Shannon Nelson wrote: >> Fix the kernel-doc complaint >> include/linux/pds/pds_adminq.h:481: warning: Excess struct member 'name' description in 'pds_core_lif_getattr_comp' >> >> Fixes: 45d76f492938 ("pds_core: set up device and adminq") > > How is this a bug fix? The warnings are only generated on W=1 builds. > Please be more considerate of folks maintaining stable trees. There's > no need to waste their time with patches like this. I'll drop it out and repost. Thanks, sln
diff --git a/include/linux/pds/pds_adminq.h b/include/linux/pds/pds_adminq.h index ddd111f04ca0..339156113fa5 100644 --- a/include/linux/pds/pds_adminq.h +++ b/include/linux/pds/pds_adminq.h @@ -463,7 +463,6 @@ struct pds_core_lif_getattr_cmd { * @rsvd: Word boundary padding * @comp_index: Index in the descriptor ring for which this is the completion * @state: LIF state (enum pds_core_lif_state) - * @name: LIF name string, 0 terminated * @features: Features (enum pds_core_hw_features) * @rsvd2: Word boundary padding * @color: Color bit
Fix the kernel-doc complaint include/linux/pds/pds_adminq.h:481: warning: Excess struct member 'name' description in 'pds_core_lif_getattr_comp' Fixes: 45d76f492938 ("pds_core: set up device and adminq") Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com> --- include/linux/pds/pds_adminq.h | 1 - 1 file changed, 1 deletion(-)