| Message ID | 20250409140258.785834-1-animesh.manna@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | LOBF enablement fix | expand |
Hello Animesh, One generic comment on this patch set. I realized that we are missing sink ALPM configuration completely if PSR/PR is not enabled. It is currenty in intel_psr_post_plane_update->intel_psr_enable_locked- >intel_psr_enable_sink->intel_psr_enable_sink_alpm. I think it should be moved out from PSR code and be common for all (PSR/PR/LOBF). BR, Jouni Högander On Wed, 2025-04-09 at 19:32 +0530, Animesh Manna wrote: > v1: Initial version. > v2: Addressed review comments from Jani. > v3: Addressed review comments from Jouni. > v4: Addressed review comments received on v3. > v5: Addressed review comments received on v4. > v6: Addressed review comments received on v5. > v7: Addressed review comments received on v6. > v8: Addressed review comments received on v7. > > Signed-off-by: Animesh Manna <animesh.manna@intel.com> > > Animesh Manna (8): > drm/i915/lobf: Add lobf enablement in post plane update > drm/i915/lobf: Add debug print for LOBF > drm/i915/lobf: Disintegrate alpm_disable from psr_disable > drm/i915/lobf: Add fixed refresh rate check in compute_config() > drm/i915/lobf: Update lobf if any change in dependent parameters > drm/i915/lobf: Add debug interface for lobf > drm/i915/lobf: Add mutex for alpm update > drm/i915/lobf: Check for sink error and disable LOBF > > Jouni Högander (1): > drm/i915/alpm: use variable from intel_crtc_state instead of > intel_psr > > drivers/gpu/drm/i915/display/intel_alpm.c | 133 > +++++++++++++++++- > drivers/gpu/drm/i915/display/intel_alpm.h | 8 +- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 + > drivers/gpu/drm/i915/display/intel_display.c | 3 + > .../drm/i915/display/intel_display_types.h | 4 + > drivers/gpu/drm/i915/display/intel_dp.c | 7 +- > drivers/gpu/drm/i915/display/intel_psr.c | 32 +---- > 7 files changed, 153 insertions(+), 36 deletions(-) >
v1: Initial version. v2: Addressed review comments from Jani. v3: Addressed review comments from Jouni. v4: Addressed review comments received on v3. v5: Addressed review comments received on v4. v6: Addressed review comments received on v5. v7: Addressed review comments received on v6. v8: Addressed review comments received on v7. Signed-off-by: Animesh Manna <animesh.manna@intel.com> Animesh Manna (8): drm/i915/lobf: Add lobf enablement in post plane update drm/i915/lobf: Add debug print for LOBF drm/i915/lobf: Disintegrate alpm_disable from psr_disable drm/i915/lobf: Add fixed refresh rate check in compute_config() drm/i915/lobf: Update lobf if any change in dependent parameters drm/i915/lobf: Add debug interface for lobf drm/i915/lobf: Add mutex for alpm update drm/i915/lobf: Check for sink error and disable LOBF Jouni Högander (1): drm/i915/alpm: use variable from intel_crtc_state instead of intel_psr drivers/gpu/drm/i915/display/intel_alpm.c | 133 +++++++++++++++++- drivers/gpu/drm/i915/display/intel_alpm.h | 8 +- drivers/gpu/drm/i915/display/intel_ddi.c | 2 + drivers/gpu/drm/i915/display/intel_display.c | 3 + .../drm/i915/display/intel_display_types.h | 4 + drivers/gpu/drm/i915/display/intel_dp.c | 7 +- drivers/gpu/drm/i915/display/intel_psr.c | 32 +---- 7 files changed, 153 insertions(+), 36 deletions(-)