| Message ID | 20250407072126.3879086-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Mikulas Patocka |
| Headers | show |
| Series | [v1,1/1] dm table: Fix W=1 build warning when mempool_needs_integrity is unused | expand |
On Mon, Apr 07, 2025 at 10:21:26AM +0300, Andy Shevchenko wrote: > The mempool_needs_integrity is unused. This, in particular, prevents > kernel builds with Clang, `make W=1` and CONFIG_WERROR=y: > > drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable] > 1052 | bool mempool_needs_integrity = t->integrity_supported; > | ^ > > Fix this by removing the leftover. This issue is still present in v6.15-rc1.
On Mon, Apr 14, 2025 at 01:04:49PM +0300, Andy Shevchenko wrote: > On Mon, Apr 07, 2025 at 10:21:26AM +0300, Andy Shevchenko wrote: > > The mempool_needs_integrity is unused. This, in particular, prevents > > kernel builds with Clang, `make W=1` and CONFIG_WERROR=y: > > > > drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable] > > 1052 | bool mempool_needs_integrity = t->integrity_supported; > > | ^ > > > > Fix this by removing the leftover. > > This issue is still present in v6.15-rc1. I meant v6.15-rc2, of course.
On Mon, 14 Apr 2025, Andy Shevchenko wrote: > On Mon, Apr 14, 2025 at 01:04:49PM +0300, Andy Shevchenko wrote: > > On Mon, Apr 07, 2025 at 10:21:26AM +0300, Andy Shevchenko wrote: > > > The mempool_needs_integrity is unused. This, in particular, prevents > > > kernel builds with Clang, `make W=1` and CONFIG_WERROR=y: > > > > > > drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable] > > > 1052 | bool mempool_needs_integrity = t->integrity_supported; > > > | ^ > > > > > > Fix this by removing the leftover. > > > > This issue is still present in v6.15-rc1. > > I meant v6.15-rc2, of course. > > -- > With Best Regards, > Andy Shevchenko I will send it to Linus (maybe with other changes) before 6.15 comes out. Mikulas
On Mon, Apr 14, 2025 at 02:13:18PM +0200, Mikulas Patocka wrote: > On Mon, 14 Apr 2025, Andy Shevchenko wrote: > > On Mon, Apr 14, 2025 at 01:04:49PM +0300, Andy Shevchenko wrote: > > > On Mon, Apr 07, 2025 at 10:21:26AM +0300, Andy Shevchenko wrote: > > > > The mempool_needs_integrity is unused. This, in particular, prevents > > > > kernel builds with Clang, `make W=1` and CONFIG_WERROR=y: > > > > > > > > drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable] > > > > 1052 | bool mempool_needs_integrity = t->integrity_supported; > > > > | ^ > > > > > > > > Fix this by removing the leftover. > > > > > > This issue is still present in v6.15-rc1. > > > > I meant v6.15-rc2, of course. > > I will send it to Linus (maybe with other changes) before 6.15 comes out. Thank you!
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 35100a435c88..53759dbbe9d6 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -1049,7 +1049,6 @@ static int dm_table_alloc_md_mempools(struct dm_table *t, struct mapped_device * unsigned int min_pool_size = 0, pool_size; struct dm_md_mempools *pools; unsigned int bioset_flags = 0; - bool mempool_needs_integrity = t->integrity_supported; if (unlikely(type == DM_TYPE_NONE)) { DMERR("no table type is set, can't allocate mempools"); @@ -1074,8 +1073,6 @@ static int dm_table_alloc_md_mempools(struct dm_table *t, struct mapped_device * per_io_data_size = max(per_io_data_size, ti->per_io_data_size); min_pool_size = max(min_pool_size, ti->num_flush_bios); - - mempool_needs_integrity |= ti->mempool_needs_integrity; } pool_size = max(dm_get_reserved_bio_based_ios(), min_pool_size); front_pad = roundup(per_io_data_size,
The mempool_needs_integrity is unused. This, in particular, prevents kernel builds with Clang, `make W=1` and CONFIG_WERROR=y: drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable] 1052 | bool mempool_needs_integrity = t->integrity_supported; | ^ Fix this by removing the leftover. Fixes: 105ca2a2c2ff ("block: split struct bio_integrity_payload") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/md/dm-table.c | 3 --- 1 file changed, 3 deletions(-)