| Message ID | E1u4dIh-000dT5-Kt@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 978d13b26ab31297e320dba1feb87f95c107961b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: stmmac: intel: remove unnecessary setting max_speed | expand |
Hello Russell, On Tue, 15 Apr 2025 11:13:55 +0100 "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk> wrote: > Phylink will already limit the MAC speed according to the interface, > so if 2500BASE-X is selected, the maximum speed will be 2.5G. > Similarly, if SGMII is selected, the maximum speed will be 1G. > It is, therefore, not necessary to set a speed limit. Remove setting > plat_dat->max_speed from this glue driver. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Maxime
On Tue, Apr 15, 2025 at 11:13:55AM +0100, Russell King (Oracle) wrote: > Phylink will already limit the MAC speed according to the interface, > so if 2500BASE-X is selected, the maximum speed will be 2.5G. > Similarly, if SGMII is selected, the maximum speed will be 1G. > It is, therefore, not necessary to set a speed limit. Remove setting > plat_dat->max_speed from this glue driver. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 15 Apr 2025 11:13:55 +0100 you wrote: > Phylink will already limit the MAC speed according to the interface, > so if 2500BASE-X is selected, the maximum speed will be 2.5G. > Similarly, if SGMII is selected, the maximum speed will be 1G. > It is, therefore, not necessary to set a speed limit. Remove setting > plat_dat->max_speed from this glue driver. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > [...] Here is the summary with links: - [net-next] net: stmmac: intel: remove unnecessary setting max_speed https://git.kernel.org/netdev/net-next/c/978d13b26ab3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c index 54db5b778304..96c893dd262f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -300,11 +300,8 @@ static void intel_speed_mode_2500(struct net_device *ndev, void *intel_data) if (((data & SERDES_LINK_MODE_MASK) >> SERDES_LINK_MODE_SHIFT) == SERDES_LINK_MODE_2G5) { dev_info(priv->device, "Link Speed Mode: 2.5Gbps\n"); - priv->plat->max_speed = 2500; priv->plat->phy_interface = PHY_INTERFACE_MODE_2500BASEX; priv->plat->mdio_bus_data->default_an_inband = false; - } else { - priv->plat->max_speed = 1000; } }
Phylink will already limit the MAC speed according to the interface, so if 2500BASE-X is selected, the maximum speed will be 2.5G. Similarly, if SGMII is selected, the maximum speed will be 1G. It is, therefore, not necessary to set a speed limit. Remove setting plat_dat->max_speed from this glue driver. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 3 --- 1 file changed, 3 deletions(-)