| Message ID | E1u4zyh-000xVE-PG@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 01be295b485a7adcd662bec3b4613b4cef7956dc |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: stmmac: mediatek: stop initialising plat->mac_interface | expand |
On Wed, Apr 16, 2025 at 11:26:47AM +0100, Russell King (Oracle) wrote: > Mediatek doesn't make use of mac_interface, and none of the in-tree > DT files use the mac-mode property. Therefore, mac_interface already > follows phy_interface. Remove this unnecessary assignment. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 16 Apr 2025 11:26:47 +0100 you wrote: > Mediatek doesn't make use of mac_interface, and none of the in-tree > DT files use the mac-mode property. Therefore, mac_interface already > follows phy_interface. Remove this unnecessary assignment. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [net-next] net: stmmac: mediatek: stop initialising plat->mac_interface https://git.kernel.org/netdev/net-next/c/01be295b485a You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c index d178d5ddc7c7..39421d6a34e4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c @@ -581,7 +581,6 @@ static int mediatek_dwmac_common_data(struct platform_device *pdev, int i; priv_plat->phy_mode = plat->phy_interface; - plat->mac_interface = priv_plat->phy_mode; if (priv_plat->mac_wol) plat->flags &= ~STMMAC_FLAG_USE_PHY_WOL; else
Mediatek doesn't make use of mac_interface, and none of the in-tree DT files use the mac-mode property. Therefore, mac_interface already follows phy_interface. Remove this unnecessary assignment. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 1 - 1 file changed, 1 deletion(-)