| Message ID | 20250417072708.2757909-2-Sai.Sathujoda@toshiba-tsip.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [isar-cip-core,v4,1/2] .gitlab-ci.yml: Set timeout value to run IEC layer tests for different targets. | expand |
On 17.04.25 09:27, Sai.Sathujoda@toshiba-tsip.com wrote: > From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com> > > Major changes in this update: > > 1. Fixed instability of TC_CR2.7_1 (Concurrent session termination) > 2. Added TC_CR1.10_1 (Authenticator feedback) > > Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com> > --- > tests/templates/IEC_template.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml > index c8efe40..b93ed4b 100644 > --- a/tests/templates/IEC_template.yml > +++ b/tests/templates/IEC_template.yml > @@ -64,7 +64,7 @@ actions: > definitions: > - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git > from: git > - revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f > + revision: bb19990c2b29ea96eea309e54124c74ea3246f18 > path: iec-security-tests/Singlenode-TestDefinition.yaml > name: Security-Testcases > Thanks, both applied. Jan
On 17.04.25 15:22, Jan Kiszka wrote: > On 17.04.25 09:27, Sai.Sathujoda@toshiba-tsip.com wrote: >> From: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com> >> >> Major changes in this update: >> >> 1. Fixed instability of TC_CR2.7_1 (Concurrent session termination) >> 2. Added TC_CR1.10_1 (Authenticator feedback) >> >> Signed-off-by: sai ashrith sathujoda <sai.sathujoda@toshiba-tsip.com> >> --- >> tests/templates/IEC_template.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml >> index c8efe40..b93ed4b 100644 >> --- a/tests/templates/IEC_template.yml >> +++ b/tests/templates/IEC_template.yml >> @@ -64,7 +64,7 @@ actions: >> definitions: >> - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git >> from: git >> - revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f >> + revision: bb19990c2b29ea96eea309e54124c74ea3246f18 >> path: iec-security-tests/Singlenode-TestDefinition.yaml >> name: Security-Testcases >> > > Thanks, both applied. > CI fails now, please have a look: https://gitlab.com/cip-project/cip-core/isar-cip-core/-/jobs/9757849360 Jan
Hi Jan, envsubst tool is replacing the value with null in case if it is not finding the exported variable in that template file. That is why it was unable to pull the swupdate file from the dispatcher because lava_dispatcher_id and lava_job_id are replaced with null. https://lava.ciplatform.org/scheduler/job/1264806/definition#defline74 So I made the following change to the envsubst command to handle this, https://gitlab.com/cip-project/cip-core/isar-cip-core/-/commit/fb13471312e6909483addb78e0c7644997383e66#a2c400ca9e562e29e60bd9b5edf0e3aa068ce6dc_337_342 Now I can see those two variables are not replaced in the job definition, and I am sure the x86-uefi swupdate job will not fail now. But just now noticed that there was problem with flashing the device https://lava.ciplatform.org/scheduler/job/1265073#L236. Can you please look into this issue ? Once it has been resolved I will send patch to update the envsubst command. Thanks and regards, Sai Ashrith
diff --git a/tests/templates/IEC_template.yml b/tests/templates/IEC_template.yml index c8efe40..b93ed4b 100644 --- a/tests/templates/IEC_template.yml +++ b/tests/templates/IEC_template.yml @@ -64,7 +64,7 @@ actions: definitions: - repository: https://gitlab.com/cip-project/cip-testing/cip-security-tests.git from: git - revision: 5dbc47f55d4a43449dcbde4363e5d23d6e96344f + revision: bb19990c2b29ea96eea309e54124c74ea3246f18 path: iec-security-tests/Singlenode-TestDefinition.yaml name: Security-Testcases