| Message ID | 20250417190302.13811-4-rubenru09@aol.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: sm750fb: cleanup ddk750_sii164 | expand |
On Thu, Apr 17, 2025 at 08:02:51PM +0100, Ruben Wauters wrote: > Fixes camel case check reported by checkpatch.pl > > Signed-off-by: Ruben Wauters <rubenru09@aol.com> > --- > drivers/staging/sm750fb/ddk750_sii164.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index d4309e0d807f..9f660a9be5d6 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -26,14 +26,14 @@ static char *dvi_controller_chip_name = "Silicon Image SiI 164"; > */ > unsigned short sii164_get_vendor_id(void) > { > - unsigned short vendorID; > + unsigned short vendor_id; > > - vendorID = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, > + vendor_id = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, > SII164_VENDOR_ID_HIGH) << 8) | > - (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, > - SII164_VENDOR_ID_LOW); > + (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, > + SII164_VENDOR_ID_LOW); > > - return vendorID; > + return vendor_id; Why is the temporary variable needed at all? Why not just return the value directly? thanks, greg k-h
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c index d4309e0d807f..9f660a9be5d6 100644 --- a/drivers/staging/sm750fb/ddk750_sii164.c +++ b/drivers/staging/sm750fb/ddk750_sii164.c @@ -26,14 +26,14 @@ static char *dvi_controller_chip_name = "Silicon Image SiI 164"; */ unsigned short sii164_get_vendor_id(void) { - unsigned short vendorID; + unsigned short vendor_id; - vendorID = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + vendor_id = ((unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, SII164_VENDOR_ID_HIGH) << 8) | - (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, - SII164_VENDOR_ID_LOW); + (unsigned short)sm750_hw_i2c_read_reg(SII164_I2C_ADDRESS, + SII164_VENDOR_ID_LOW); - return vendorID; + return vendor_id; } /*
Fixes camel case check reported by checkpatch.pl Signed-off-by: Ruben Wauters <rubenru09@aol.com> --- drivers/staging/sm750fb/ddk750_sii164.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)