| Message ID | 1343392734-11805-5-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Lee, On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > Provide a compatible string for the AB8500 CODEC to aid in > configuration property look-up from its associated Device Tree > node. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/ab8500-core.c | 1 + > 1 file changed, 1 insertion(+) Applied as well. Cheers, Samuel.
On Fri, Jul 27, 2012 at 03:36:33PM +0200, Samuel Ortiz wrote: > On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > > Provide a compatible string for the AB8500 CODEC to aid in > > configuration property look-up from its associated Device Tree > > node. > Applied as well. I remain *deeply* unconvinced that this is tasteful design for the device tree bindings, and it's certainly not needed urgently for v3.6 as there's no DT bindings on the CODEC side.
On Sun, Jul 29, 2012 at 09:28:07PM +0100, Mark Brown wrote: > On Fri, Jul 27, 2012 at 03:36:33PM +0200, Samuel Ortiz wrote: > > On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > > > > Provide a compatible string for the AB8500 CODEC to aid in > > > configuration property look-up from its associated Device Tree > > > node. > > > Applied as well. > > I remain *deeply* unconvinced that this is tasteful design for the > device tree bindings, and it's certainly not needed urgently for v3.6 as > there's no DT bindings on the CODEC side. Fair enough, I'll keep this one for the next merge window. Cheers, Samuel.
On Mon, Jul 30, 2012 at 03:24:22PM +0200, Samuel Ortiz wrote: > On Sun, Jul 29, 2012 at 09:28:07PM +0100, Mark Brown wrote: > > On Fri, Jul 27, 2012 at 03:36:33PM +0200, Samuel Ortiz wrote: > > > On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > > > > > > Provide a compatible string for the AB8500 CODEC to aid in > > > > configuration property look-up from its associated Device Tree > > > > node. > > > > > Applied as well. > > > > I remain *deeply* unconvinced that this is tasteful design for the > > device tree bindings, and it's certainly not needed urgently for v3.6 as > > there's no DT bindings on the CODEC side. > Fair enough, I'll keep this one for the next merge window. Chasing this, as it still doesn't appear in v3.7 -next. Kind regards, Lee
Hi Lee, On Fri, Jul 27, 2012 at 01:38:51PM +0100, Lee Jones wrote: > Provide a compatible string for the AB8500 CODEC to aid in > configuration property look-up from its associated Device Tree > node. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/ab8500-core.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. Cheers, Samuel.
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index 626b4ec..0c5b70f 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -1076,6 +1076,7 @@ static struct mfd_cell __devinitdata ab8500_devs[] = { }, { .name = "ab8500-codec", + .of_compatible = "stericsson,ab8500-codec", }, };
Provide a compatible string for the AB8500 CODEC to aid in configuration property look-up from its associated Device Tree node. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/ab8500-core.c | 1 + 1 file changed, 1 insertion(+)