| Message ID | 1343393162-11938-18-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 27, 2012 at 01:46:01PM +0100, Lee Jones wrote: > arch/arm/boot/dts/db8500.dtsi | 8 ++++++++ This is a generic DT include file but... > + sound { > + compatible = "stericsson,snd-soc-mop500"; > + > + stericsson,platform-pcm-dma = <&pcm>; > + stericsson,cpu-dai = <&msp1 &msp3>; > + stericsson,audio-codec = <&codec>; > + }; ...this is clearly the board-specific setup for the system, showing how the CPU and CODEC are hooked up. This should therefore be in the DT for whatever board this is you're working on.
On 29/07/12 21:52, Mark Brown wrote: > On Fri, Jul 27, 2012 at 01:46:01PM +0100, Lee Jones wrote: > >> arch/arm/boot/dts/db8500.dtsi | 8 ++++++++ > > This is a generic DT include file but... > >> + sound { >> + compatible = "stericsson,snd-soc-mop500"; >> + >> + stericsson,platform-pcm-dma = <&pcm>; >> + stericsson,cpu-dai = <&msp1 &msp3>; >> + stericsson,audio-codec = <&codec>; >> + }; > > ...this is clearly the board-specific setup for the system, showing how > the CPU and CODEC are hooked up. This should therefore be in the DT for > whatever board this is you're working on. I don't think it's board specific. I believe this is the setup on all db8500 platforms. I'm happy to be told I'm wrong here, in which case I can move it to the board specific files.
On Mon, Jul 30, 2012 at 08:35:18AM +0100, Lee Jones wrote: > On 29/07/12 21:52, Mark Brown wrote: > >...this is clearly the board-specific setup for the system, showing how > >the CPU and CODEC are hooked up. This should therefore be in the DT for > >whatever board this is you're working on. > I don't think it's board specific. I believe this is the setup on > all db8500 platforms. I'm happy to be told I'm wrong here, in which > case I can move it to the board specific files. I think that's more a sign that all the platforms you've seen are just cut'n'pasted from the reference design than anything else. If the thing you're describing is on the PCB it's generally board specific...
On 30/07/12 14:42, Mark Brown wrote: > On Mon, Jul 30, 2012 at 08:35:18AM +0100, Lee Jones wrote: >> On 29/07/12 21:52, Mark Brown wrote: > >>> ...this is clearly the board-specific setup for the system, showing how >>> the CPU and CODEC are hooked up. This should therefore be in the DT for >>> whatever board this is you're working on. > >> I don't think it's board specific. I believe this is the setup on >> all db8500 platforms. I'm happy to be told I'm wrong here, in which >> case I can move it to the board specific files. > > I think that's more a sign that all the platforms you've seen are just > cut'n'pasted from the reference design than anything else. If the thing > you're describing is on the PCB it's generally board specific... I'll split it out into the board file(s) if it makes you happy. I'd rather just get it in and move on to something more productive. We can change it retrospectively if I'm told by someone more knowledgeable that it's 100% common across all platforms.
diff --git a/arch/arm/boot/dts/db8500.dtsi b/arch/arm/boot/dts/db8500.dtsi index b9d4405..9d0fba6 100644 --- a/arch/arm/boot/dts/db8500.dtsi +++ b/arch/arm/boot/dts/db8500.dtsi @@ -595,6 +595,14 @@ compatible = "stericsson,ux500-pcm"; }; + sound { + compatible = "stericsson,snd-soc-mop500"; + + stericsson,platform-pcm-dma = <&pcm>; + stericsson,cpu-dai = <&msp1 &msp3>; + stericsson,audio-codec = <&codec>; + }; + msp0: msp@80123000 { compatible = "stericsson,ux500-msp-i2s"; reg = <0x80123000 0x1000>;
This is the node which links together the platform (PCM), codec (AB8500) and the CPU side Digital Audio Interface (MCP) with the machine driver. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/db8500.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)