| Message ID | 1343730576-20494-3-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jul 31, 2012 at 7:29 AM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > + i2c0_pins_b: i2c0@1 { > + reg = <1>; > + fsl,pinmux-ids = <0x3001 0x3011>; Can you please also list the name of the pin as comment (just like you did for pwm4)? This would allow us to quickly identify the muxing option without the need of looking at the mxs pinctrl doc. Regards, Fabio Estevam
Hi, Le 31/07/2012 14:02, Fabio Estevam a écrit : > On Tue, Jul 31, 2012 at 7:29 AM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > >> + i2c0_pins_b: i2c0@1 { >> + reg = <1>; >> + fsl,pinmux-ids = <0x3001 0x3011>; > > Can you please also list the name of the pin as comment (just like you > did for pwm4)? > > This would allow us to quickly identify the muxing option without the > need of looking at the mxs pinctrl doc. You're right, this will be in the next version. Thanks! Maxime
diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 915db89..44ce1fd 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -410,6 +410,14 @@ fsl,pull-up = <1>; }; + i2c0_pins_b: i2c0@1 { + reg = <1>; + fsl,pinmux-ids = <0x3001 0x3011>; + fsl,drive-strength = <1>; + fsl,voltage = <1>; + fsl,pull-up = <1>; + }; + saif0_pins_a: saif0@0 { reg = <0>; fsl,pinmux-ids = <
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Brian Lilly <brian@crystalfontz.com> --- arch/arm/boot/dts/imx28.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)