diff mbox

[v2] xconfig: Display dependency values in debug_info

Message ID 50182ACF.6070704@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Salar Ali Mumtaz July 31, 2012, 6:58 p.m. UTC 
Now the debug_info only shows y/n/m values.

Signed-off-by: Salar Ali Mumtaz <salaarali@gmail.com>
---
 scripts/kconfig/qconf.cc |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

Comments

Randy Dunlap July 31, 2012, 8:21 p.m. UTC | #1 
On 07/31/2012 11:58 AM, Salar Ali Mumtaz wrote:

> Now the debug_info only shows y/n/m values.
> 


or no value at all??

for CONFIG_BINFMT_ELF:



Kernel support for ELF binaries (BINFMT_ELF)

type: boolean
unknown property: symbol
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
prompt: Kernel support for ELF binaries
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
default: y
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y

defined at fs/Kconfig.binfmt:1

CONFIG_BINFMT_ELF:





> Signed-off-by: Salar Ali Mumtaz <salaarali@gmail.com>
> ---
>  scripts/kconfig/qconf.cc |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index df274fe..b6a7cc5 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -1073,8 +1073,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
>  		debug += " (choice)";
>  	debug += "<br>";
>  	if (sym->rev_dep.expr) {
> -		debug += "reverse dep: ";
> +		debug += "reverse dep: (";
>  		expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE);
> +		debug += " )  =";
> +		debug += print_filter(sym_get_string_value(sym));
>  		debug += "<br>";
>  	}
>  	for (struct property *prop = sym->prop; prop; prop = prop->next) {
> @@ -1108,7 +1110,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
>  		}
>  		if (prop->visible.expr) {
>  			debug += "&nbsp;&nbsp;&nbsp;&nbsp;dep: ";
> +			debug += " ( ";
>  			expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE);
> +			debug += " )  =";
> +			debug += print_filter(sym_get_string_value(sym));
>  			debug += "<br>";
>  		}
>  	}
> @@ -1152,11 +1157,18 @@ void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char
>  {
>  	QString* text = reinterpret_cast<QString*>(data);
>  	QString str2 = print_filter(str);
> +	QString value;
>  
>  	if (sym && sym->name && !(sym->flags & SYMBOL_CONST)) {
> +		value = print_filter(sym_get_string_value(sym));
> +
>  		*text += QString().sprintf("<a href=\"s%p\">", sym);
>  		*text += str2;
>  		*text += "</a>";
> +		*text += "<b>   ";
> +		if(value == "y" || value == "m" || value == "n")
> +			*text += print_filter(sym_get_string_value(sym));
> +		*text += "</b>";
>  	} else
>  		*text += str2;
>  }



thanks,
Salar Ali Mumtaz Aug. 2, 2012, 4:20 a.m. UTC | #2 
On 12-07-31 04:21 PM, Randy Dunlap wrote:
> On 07/31/2012 11:58 AM, Salar Ali Mumtaz wrote:
> 
>> Now the debug_info only shows y/n/m values.
>>
> 
> 
> or no value at all??


Yes.

y/n/m or no value at all.

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Randy Dunlap Aug. 2, 2012, 4:47 a.m. UTC | #3 
On 08/01/2012 09:20 PM, Salar Ali Mumtaz wrote:

> On 12-07-31 04:21 PM, Randy Dunlap wrote:
>> On 07/31/2012 11:58 AM, Salar Ali Mumtaz wrote:
>>
>>> Now the debug_info only shows y/n/m values.
>>>
>>
>>
>> or no value at all??
> 
> 
> Yes.
> 
> y/n/m or no value at all.
> 


so in:

Kernel support for ELF binaries (BINFMT_ELF)

type: boolean
unknown property: symbol
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
prompt: Kernel support for ELF binaries
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
default: y
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y



does that mean that FRV is n, so !FRV is y ??
It's still confusing.
diff mbox

Patch

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index df274fe..b6a7cc5 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1073,8 +1073,10 @@  QString ConfigInfoView::debug_info(struct symbol *sym)
 		debug += " (choice)";
 	debug += "<br>";
 	if (sym->rev_dep.expr) {
-		debug += "reverse dep: ";
+		debug += "reverse dep: (";
 		expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE);
+		debug += " )  =";
+		debug += print_filter(sym_get_string_value(sym));
 		debug += "<br>";
 	}
 	for (struct property *prop = sym->prop; prop; prop = prop->next) {
@@ -1108,7 +1110,10 @@  QString ConfigInfoView::debug_info(struct symbol *sym)
 		}
 		if (prop->visible.expr) {
 			debug += "&nbsp;&nbsp;&nbsp;&nbsp;dep: ";
+			debug += " ( ";
 			expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE);
+			debug += " )  =";
+			debug += print_filter(sym_get_string_value(sym));
 			debug += "<br>";
 		}
 	}
@@ -1152,11 +1157,18 @@  void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char
 {
 	QString* text = reinterpret_cast<QString*>(data);
 	QString str2 = print_filter(str);
+	QString value;
 
 	if (sym && sym->name && !(sym->flags & SYMBOL_CONST)) {
+		value = print_filter(sym_get_string_value(sym));
+
 		*text += QString().sprintf("<a href=\"s%p\">", sym);
 		*text += str2;
 		*text += "</a>";
+		*text += "<b>   ";
+		if(value == "y" || value == "m" || value == "n")
+			*text += print_filter(sym_get_string_value(sym));
+		*text += "</b>";
 	} else
 		*text += str2;
 }