diff mbox

[18/19] Documentation: Define the MSP Driver Device Tree bindings

Message ID 1343741953-17828-19-git-send-email-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Lee Jones July 31, 2012, 1:39 p.m. UTC
Here we add the required documentation for the new Device Tree
bindings pertaining to the MSP CPU-side DAI Driver.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 .../devicetree/bindings/sound/ux500-msp.txt        |   43 ++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/ux500-msp.txt

Comments

Mark Brown July 31, 2012, 1:55 p.m. UTC | #1
On Tue, Jul 31, 2012 at 02:39:12PM +0100, Lee Jones wrote:

> +Optional properties:
> + - interrupts       : The interrupt outputs from the device.

If there's more than one interrupt then how are they ordered?
Lee Jones July 31, 2012, 2:59 p.m. UTC | #2
On 31/07/12 14:55, Mark Brown wrote:
> On Tue, Jul 31, 2012 at 02:39:12PM +0100, Lee Jones wrote:
>
>> +Optional properties:
>> + - interrupts       : The interrupt outputs from the device.
>
> If there's more than one interrupt then how are they ordered?

It doesn't matter. If there are any more than one (which there aren't in 
this case), we usually use the interrupt-names property then request 
them by name in the driver.
Mark Brown July 31, 2012, 3:10 p.m. UTC | #3
On Tue, Jul 31, 2012 at 03:59:46PM +0100, Lee Jones wrote:
> On 31/07/12 14:55, Mark Brown wrote:

> >>+Optional properties:
> >>+ - interrupts       : The interrupt outputs from the device.

> >If there's more than one interrupt then how are they ordered?

> It doesn't matter. If there are any more than one (which there
> aren't in this case), we usually use the interrupt-names property
> then request them by name in the driver.

So the binding therefore needs to say "The interrupt output from the
device" as there's only one output supported.  If we were using
interrupt-names then we'd need to document what the supported names are.
Lee Jones Aug. 2, 2012, 12:45 p.m. UTC | #4
On 31/07/12 16:10, Mark Brown wrote:
> On Tue, Jul 31, 2012 at 03:59:46PM +0100, Lee Jones wrote:
>> On 31/07/12 14:55, Mark Brown wrote:
>
>>>> +Optional properties:
>>>> + - interrupts       : The interrupt outputs from the device.
>
>>> If there's more than one interrupt then how are they ordered?
>
>> It doesn't matter. If there are any more than one (which there
>> aren't in this case), we usually use the interrupt-names property
>> then request them by name in the driver.
>
> So the binding therefore needs to say "The interrupt output from the
> device" as there's only one output supported.  If we were using
> interrupt-names then we'd need to document what the supported names are.

Okay, I've changed 'outputs' to 'output'.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/sound/ux500-msp.txt b/Documentation/devicetree/bindings/sound/ux500-msp.txt
new file mode 100644
index 0000000..5b883cc
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/ux500-msp.txt
@@ -0,0 +1,43 @@ 
+* ux500 MSP (CPU-side Digital Audio Interface)
+
+Required properties:
+ - compatible       :"stericsson,ux500-msp-i2s"
+ - reg              : Physical base address and length of the device's registers.
+
+Optional properties:
+ - interrupts       : The interrupt outputs from the device.
+ - interrupt-parent : The parent interrupt controller.
+ - <name>-supply    : Phandle to the regulator <name> supply
+
+Example:
+
+	sound {
+		compatible = "stericsson,snd-soc-mop500";
+
+		stericsson,platform-pcm-dma = <&pcm>;
+		stericsson,cpu-dai = <&msp1 &msp3>;
+		stericsson,audio-codec = <&codec>;
+	};
+
+	pcm: ux500-pcm {
+		compatible = "stericsson,ux500-pcm";
+	};
+
+	msp1: msp@80124000 {
+		compatible = "stericsson,ux500-msp-i2s";
+		reg = <0x80124000 0x1000>;
+		interrupts = <0 62 0x4>;
+		v-ape-supply = <&db8500_vape_reg>;
+	};
+
+	msp3: msp@80125000 {
+		compatible = "stericsson,ux500-msp-i2s";
+		reg = <0x80125000 0x1000>;
+		interrupts = <0 62 0x4>;
+		v-ape-supply = <&db8500_vape_reg>;
+	};
+
+	codec: ab8500-codec {
+		compatible = "stericsson,ab8500-codec";
+		stericsson,earpeice-cmv = <950>; /* Units in mV. */
+	};