| Message ID | 1343775898-28345-9-git-send-email-cyril@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 31 Jul 2012, Cyril Chemparathy wrote: > From: Vitaly Andrianov <vitalya@ti.com> > > This patch fixes the initrd setup code to use phys_addr_t instead of assuming > 32-bit addressing. Without this we cannot boot on systems where initrd is > located above the 4G physical address limit. > > Signed-off-by: Vitaly Andrianov <vitalya@ti.com> > Signed-off-by: Cyril Chemparathy <cyril@ti.com> > --- > arch/arm/mm/init.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > index 8252c31..51f3e92 100644 > --- a/arch/arm/mm/init.c > +++ b/arch/arm/mm/init.c > @@ -36,12 +36,12 @@ > > #include "mm.h" > > -static unsigned long phys_initrd_start __initdata = 0; > -static unsigned long phys_initrd_size __initdata = 0; > +static phys_addr_t phys_initrd_start __initdata = 0; > +static phys_addr_t phys_initrd_size __initdata = 0; phys_addr_t for the initrd size is rather overkill, isn't it? Nicolas
On 8/4/2012 2:57 AM, Nicolas Pitre wrote: > On Tue, 31 Jul 2012, Cyril Chemparathy wrote: > >> From: Vitaly Andrianov <vitalya@ti.com> >> >> This patch fixes the initrd setup code to use phys_addr_t instead of assuming >> 32-bit addressing. Without this we cannot boot on systems where initrd is >> located above the 4G physical address limit. >> >> Signed-off-by: Vitaly Andrianov <vitalya@ti.com> >> Signed-off-by: Cyril Chemparathy <cyril@ti.com> >> --- >> arch/arm/mm/init.c | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c >> index 8252c31..51f3e92 100644 >> --- a/arch/arm/mm/init.c >> +++ b/arch/arm/mm/init.c >> @@ -36,12 +36,12 @@ >> >> #include "mm.h" >> >> -static unsigned long phys_initrd_start __initdata = 0; >> -static unsigned long phys_initrd_size __initdata = 0; >> +static phys_addr_t phys_initrd_start __initdata = 0; >> +static phys_addr_t phys_initrd_size __initdata = 0; > > phys_addr_t for the initrd size is rather overkill, isn't it? > Fair enough. :-) > > Nicolas >
diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index 8252c31..51f3e92 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -36,12 +36,12 @@ #include "mm.h" -static unsigned long phys_initrd_start __initdata = 0; -static unsigned long phys_initrd_size __initdata = 0; +static phys_addr_t phys_initrd_start __initdata = 0; +static phys_addr_t phys_initrd_size __initdata = 0; static int __init early_initrd(char *p) { - unsigned long start, size; + phys_addr_t start, size; char *endp; start = memparse(p, &endp); @@ -347,14 +347,14 @@ void __init arm_memblock_init(struct meminfo *mi, struct machine_desc *mdesc) #ifdef CONFIG_BLK_DEV_INITRD if (phys_initrd_size && !memblock_is_region_memory(phys_initrd_start, phys_initrd_size)) { - pr_err("INITRD: 0x%08lx+0x%08lx is not a memory region - disabling initrd\n", - phys_initrd_start, phys_initrd_size); + pr_err("INITRD: 0x%08llx+0x%08llx is not a memory region - disabling initrd\n", + (u64)phys_initrd_start, (u64)phys_initrd_size); phys_initrd_start = phys_initrd_size = 0; } if (phys_initrd_size && memblock_is_region_reserved(phys_initrd_start, phys_initrd_size)) { - pr_err("INITRD: 0x%08lx+0x%08lx overlaps in-use memory region - disabling initrd\n", - phys_initrd_start, phys_initrd_size); + pr_err("INITRD: 0x%08llx+0x%08llx overlaps in-use memory region - disabling initrd\n", + (u64)phys_initrd_start, (u64)phys_initrd_size); phys_initrd_start = phys_initrd_size = 0; } if (phys_initrd_size) {