drm/radeon: Include swiotlb.h if SWIOTLB configured.

Commit Message

Huacai Chen Aug. 13, 2012, 2:09 a.m. UTC

When SWIOTLB is configured, if without this patch kernel compilation
fails.

Signed-off-by: Huacai Chen <[e-mail]>
Signed-off-by: Hongliang Tao <[e-mail]>
Signed-off-by: Hua Yan <[e-mail]>
Cc: [e-mail]
---
 drivers/gpu/drm/radeon/radeon_ttm.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Paul Menzel Aug. 13, 2012, 7 a.m. UTC | #1

Dear Chen,


thanks for your patch.

Firstly, is Chen your first or last name? If it is your first name, your
From address should be switched.

Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
> When SWIOTLB is configured, if without this patch kernel compilation
> fails.

Secondly, could you please always paste part of the error message into
the commit message so that people hitting this problem and searching for
it on the WWW have a higher chance finding your patch.

Thirdly, do you know why this was not caught beforehand and compilation
worked before?

> Signed-off-by: Huacai Chen <[e-mail]>

Lastly, the addresses in your From line and Signed-off-by line disagree.
You can easily fix that, by adding

    From: Huacai Chen <[e-mail]>

to the beginning of your message.

> Signed-off-by: Hongliang Tao <[e-mail]>
> Signed-off-by: Hua Yan <[e-mail]>
> Cc: [e-mail]
> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 5b71c71..fc3ac22 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -41,6 +41,10 @@
>  #include "radeon_reg.h"
>  #include "radeon.h"
>  
> +#ifdef CONFIG_SWIOTLB
> +#include <linux/swiotlb.h>
> +#endif
> +
>  #define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT)
>  
>  static int radeon_ttm_debugfs_init(struct radeon_device *rdev);

With the clarification above

    Acked-by: Paul Menzel <[e-mail]>

can be added to your patch.


Thanks,

Paul

Huacai Chen Aug. 13, 2012, 7:16 a.m. UTC | #2

On Mon, Aug 13, 2012 at 3:00 PM, Paul Menzel
<[e-mail]> wrote:
> Dear Chen,
>
>
> thanks for your patch.
>
> Firstly, is Chen your first or last name? If it is your first name, your
> From address should be switched.
Chen is may last name.

>
> Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
>> When SWIOTLB is configured, if without this patch kernel compilation
>> fails.
>
> Secondly, could you please always paste part of the error message into
> the commit message so that people hitting this problem and searching for
> it on the WWW have a higher chance finding your patch.
>
OK, I'll paste error message.

> Thirdly, do you know why this was not caught beforehand and compilation
> worked before?
Maybe radeon is mostly used on X86 and swiotlb.h is included
indirectly on X86 platform. This patch is split from my MIPS patchset,
on MIPS machines compilation always failed.

>
>> Signed-off-by: Huacai Chen <[e-mail]>
>
> Lastly, the addresses in your From line and Signed-off-by line disagree.
> You can easily fix that, by adding
My patch is generated by git format-patch and there is surely a From
line in the beginning (from [e-mail]), but the mail is sent
out by gmail, so I don't know how to make From line and Signed-off-by
agree.

>
>     From: Huacai Chen <[e-mail]>
>
> to the beginning of your message.
>
>> Signed-off-by: Hongliang Tao <[e-mail]>
>> Signed-off-by: Hua Yan <[e-mail]>
>> Cc: [e-mail]
>> ---
>>  drivers/gpu/drm/radeon/radeon_ttm.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>> index 5b71c71..fc3ac22 100644
>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>> @@ -41,6 +41,10 @@
>>  #include "radeon_reg.h"
>>  #include "radeon.h"
>>
>> +#ifdef CONFIG_SWIOTLB
>> +#include <linux/swiotlb.h>
>> +#endif
>> +
>>  #define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT)
>>
>>  static int radeon_ttm_debugfs_init(struct radeon_device *rdev);
>
> With the clarification above
>
>     Acked-by: Paul Menzel <[e-mail]>
>
> can be added to your patch.
>
>
> Thanks,
>
> Paul

Paul Menzel Aug. 13, 2012, 7:50 a.m. UTC | #3

Dear Huacai,


Am Montag, den 13.08.2012, 15:16 +0800 schrieb Huacai Chen:
> On Mon, Aug 13, 2012 at 3:00 PM, Paul Menzel wrote:

> > thanks for your patch.
> >
> > Firstly, is Chen your first or last name? If it is your first name, your
> > From address should be switched.
> Chen is may last name.

I am sorry then.

> > Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
> >> When SWIOTLB is configured, if without this patch kernel compilation
> >> fails.
> >
> > Secondly, could you please always paste part of the error message into
> > the commit message so that people hitting this problem and searching for
> > it on the WWW have a higher chance finding your patch.
> >
> OK, I'll paste error message.
> 
> > Thirdly, do you know why this was not caught beforehand and compilation
> > worked before?
> Maybe radeon is mostly used on X86 and swiotlb.h is included
> indirectly on X86 platform. This patch is split from my MIPS patchset,
> on MIPS machines compilation always failed.

Ah, I thought your patches had already been submitted.

> >> Signed-off-by: Huacai Chen <[e-mail]>
> >
> > Lastly, the addresses in your From line and Signed-off-by line disagree.
> > You can easily fix that, by adding
> My patch is generated by git format-patch and there is surely a From
> line in the beginning (from [e-mail]),

It should be `From: Huacai Chen <[e-mail]>`.

> but the mail is sent out by gmail, so I don't know how to make From
> line and Signed-off-by agree.

Do you copy the content of the file created by `git format-patch` into
the Gmail Web compositor?

If yes, just do not delete the `From` *and* `Date` lines from the
beginning as for example Alex Deucher is doing [1].

[…]


Thanks,

Paul


[1] http://lists.freedesktop.org/archives/dri-devel/2012-July/025200.html

Huacai Chen Aug. 13, 2012, 8:04 a.m. UTC | #4

On Mon, Aug 13, 2012 at 3:50 PM, Paul Menzel
<[e-mail]> wrote:
> Dear Huacai,
>
>
> Am Montag, den 13.08.2012, 15:16 +0800 schrieb Huacai Chen:
>> On Mon, Aug 13, 2012 at 3:00 PM, Paul Menzel wrote:
>
>> > thanks for your patch.
>> >
>> > Firstly, is Chen your first or last name? If it is your first name, your
>> > From address should be switched.
>> Chen is may last name.
>
> I am sorry then.
>
>> > Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:
>> >> When SWIOTLB is configured, if without this patch kernel compilation
>> >> fails.
>> >
>> > Secondly, could you please always paste part of the error message into
>> > the commit message so that people hitting this problem and searching for
>> > it on the WWW have a higher chance finding your patch.
>> >
>> OK, I'll paste error message.
>>
>> > Thirdly, do you know why this was not caught beforehand and compilation
>> > worked before?
>> Maybe radeon is mostly used on X86 and swiotlb.h is included
>> indirectly on X86 platform. This patch is split from my MIPS patchset,
>> on MIPS machines compilation always failed.
>
> Ah, I thought your patches had already been submitted.
My MIPS patchset is under review (not accepted now), I think this drm
patch is important and should be accept first, so sent it
independently.

>
>> >> Signed-off-by: Huacai Chen <[e-mail]>
>> >
>> > Lastly, the addresses in your From line and Signed-off-by line disagree.
>> > You can easily fix that, by adding
>> My patch is generated by git format-patch and there is surely a From
>> line in the beginning (from [e-mail]),
>
> It should be `From: Huacai Chen <[e-mail]>`.
Yes, git format-patch generate `From: Huacai Chen <[e-mail]>`

>
>> but the mail is sent out by gmail, so I don't know how to make From
>> line and Signed-off-by agree.
>
> Do you copy the content of the file created by `git format-patch` into
> the Gmail Web compositor?
>
> If yes, just do not delete the `From` *and* `Date` lines from the
> beginning as for example Alex Deucher is doing [1].
No, I use git send-email to send the patch but use gmail's server
(mail server of lemote.com is too weak). The original patch is begin
with:
-----
From 70e1e058da3d39c52b7dba3e8fa754e7ed41828c Mon Sep 17 00:00:00 2001
From: Huacai Chen <[e-mail]>
Date: Thu, 2 Aug 2012 17:02:59 +0800
Subject: [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.

When SWIOTLB is configured, if without this patch kernel compilation
fails with error messages:
----
Do you means I need to copy the From line and paste it after the Subject line?

>
> […]
>
>
> Thanks,
>
> Paul
>
>
> [1] http://lists.freedesktop.org/archives/dri-devel/2012-July/025200.html

Paul Menzel Aug. 13, 2012, 9:11 a.m. UTC | #5

Am Montag, den 13.08.2012, 16:04 +0800 schrieb Huacai Chen:
> On Mon, Aug 13, 2012 at 3:50 PM, Paul Menzel wrote:

> > Am Montag, den 13.08.2012, 15:16 +0800 schrieb Huacai Chen:
> >> On Mon, Aug 13, 2012 at 3:00 PM, Paul Menzel wrote:

[…]

> >> > Am Montag, den 13.08.2012, 10:09 +0800 schrieb Huacai Chen:

[…]

> >> >> Signed-off-by: Huacai Chen <[e-mail]>
> >> >
> >> > Lastly, the addresses in your From line and Signed-off-by line disagree.
> >> > You can easily fix that, by adding
> >> My patch is generated by git format-patch and there is surely a From
> >> line in the beginning (from [e-mail]),
> >
> > It should be `From: Huacai Chen <[e-mail]>`.
> Yes, git format-patch generate `From: Huacai Chen <[e-mail]>`
> 
> >
> >> but the mail is sent out by gmail, so I don't know how to make From
> >> line and Signed-off-by agree.
> >
> > Do you copy the content of the file created by `git format-patch` into
> > the Gmail Web compositor?
> >
> > If yes, just do not delete the `From` *and* `Date` lines from the
> > beginning as for example Alex Deucher is doing [1].
> No, I use git send-email to send the patch but use gmail's server
> (mail server of lemote.com is too weak). The original patch is begin
> with:
> -----
> From 70e1e058da3d39c52b7dba3e8fa754e7ed41828c Mon Sep 17 00:00:00 2001
> From: Huacai Chen <[e-mail]>
> Date: Thu, 2 Aug 2012 17:02:59 +0800
> Subject: [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.
> 
> When SWIOTLB is configured, if without this patch kernel compilation
> fails with error messages:
> ----
> Do you means I need to copy the From line and paste it after the Subject line?

wereHamster on #git suggested to use

    git send-email --from 'Huacai Chen <[e-mail]>'

and it should do the right thing.


Thanks,

Paul


> > [1] http://lists.freedesktop.org/archives/dri-devel/2012-July/025200.html

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 5b71c71..fc3ac22 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -41,6 +41,10 @@ 
 #include "radeon_reg.h"
 #include "radeon.h"
 
+#ifdef CONFIG_SWIOTLB
+#include <linux/swiotlb.h>
+#endif
+
 #define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT)
 
 static int radeon_ttm_debugfs_init(struct radeon_device *rdev);