diff mbox

[11/11] au0828: use %*ph to dump small buffers

Message ID 1344357792-18202-11-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andy Shevchenko Aug. 7, 2012, 4:43 p.m. UTC
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/au0828/au0828-core.c |   12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Comments

Mauro Carvalho Chehab Aug. 13, 2012, 7:41 p.m. UTC | #1
Em 07-08-2012 13:43, Andy Shevchenko escreveu:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/video/au0828/au0828-core.c |   12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828/au0828-core.c
> index 1e4ce50..49e0e92 100644
> --- a/drivers/media/video/au0828/au0828-core.c
> +++ b/drivers/media/video/au0828/au0828-core.c
> @@ -73,17 +73,7 @@ static void cmd_msg_dump(struct au0828_dev *dev)
>  	int i;
>  
>  	for (i = 0; i < sizeof(dev->ctrlmsg); i += 16)
> -		dprintk(2, "%s() %02x %02x %02x %02x %02x %02x %02x %02x "
> -				"%02x %02x %02x %02x %02x %02x %02x %02x\n",
> -			__func__,
> -			dev->ctrlmsg[i+0], dev->ctrlmsg[i+1],
> -			dev->ctrlmsg[i+2], dev->ctrlmsg[i+3],
> -			dev->ctrlmsg[i+4], dev->ctrlmsg[i+5],
> -			dev->ctrlmsg[i+6], dev->ctrlmsg[i+7],
> -			dev->ctrlmsg[i+8], dev->ctrlmsg[i+9],
> -			dev->ctrlmsg[i+10], dev->ctrlmsg[i+11],
> -			dev->ctrlmsg[i+12], dev->ctrlmsg[i+13],
> -			dev->ctrlmsg[i+14], dev->ctrlmsg[i+15]);
> +		dprintk(2, "%s() %*ph\n", __func__, 16, dev->ctrlmsg + i);
>  }
>  
>  static int send_control_msg(struct au0828_dev *dev, u16 request, u32 value,
> 
That one doesn't apply anymore.

Thanks,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andy Shevchenko Aug. 14, 2012, 3:50 a.m. UTC | #2
On Mon, Aug 13, 2012 at 10:41 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> Em 07-08-2012 13:43, Andy Shevchenko escreveu:
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
> That one doesn't apply anymore.
It's not needed anymore. Please, skip it.
diff mbox

Patch

diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828/au0828-core.c
index 1e4ce50..49e0e92 100644
--- a/drivers/media/video/au0828/au0828-core.c
+++ b/drivers/media/video/au0828/au0828-core.c
@@ -73,17 +73,7 @@  static void cmd_msg_dump(struct au0828_dev *dev)
 	int i;
 
 	for (i = 0; i < sizeof(dev->ctrlmsg); i += 16)
-		dprintk(2, "%s() %02x %02x %02x %02x %02x %02x %02x %02x "
-				"%02x %02x %02x %02x %02x %02x %02x %02x\n",
-			__func__,
-			dev->ctrlmsg[i+0], dev->ctrlmsg[i+1],
-			dev->ctrlmsg[i+2], dev->ctrlmsg[i+3],
-			dev->ctrlmsg[i+4], dev->ctrlmsg[i+5],
-			dev->ctrlmsg[i+6], dev->ctrlmsg[i+7],
-			dev->ctrlmsg[i+8], dev->ctrlmsg[i+9],
-			dev->ctrlmsg[i+10], dev->ctrlmsg[i+11],
-			dev->ctrlmsg[i+12], dev->ctrlmsg[i+13],
-			dev->ctrlmsg[i+14], dev->ctrlmsg[i+15]);
+		dprintk(2, "%s() %*ph\n", __func__, 16, dev->ctrlmsg + i);
 }
 
 static int send_control_msg(struct au0828_dev *dev, u16 request, u32 value,