Message ID | 20120812021405.GB8442@localhost (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On Sun, 12 Aug 2012 10:14:05 +0800 Fengguang Wu <fengguang.wu@intel.com> wrote: > From: Mel Gorman <mgorman@suse.de> > > The following build error occurred during an alpha build: > > net/core/sock.c:274:36: error: initializer element is not constant > > Dave Anglin says: > > Here is the line in sock.i: > > > > struct static_key memalloc_socks = ((struct static_key) { .enabled = > > ((atomic_t) { (0) }) }); > > The above line contains two compound literals. It also uses a designated > initializer to initialize the field enabled. A compound literal is not a > constant expression. > > The location of the above statement isn't fully clear, but if a compound > literal occurs outside the body of a function, the initializer list must > consist of constant expressions. > > Cc: <stable@vger.kernel.org> > Signed-off-by: Mel Gorman <mgorman@suse.de> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> I'll remvoe the Cc:stable from this one - the regression is post-3.5. -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux.orig/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:36.667523339 +0800 +++ linux/arch/alpha/include/asm/atomic.h 2012-08-12 10:12:37.659523362 +0800 @@ -14,8 +14,8 @@ */ -#define ATOMIC_INIT(i) ( (atomic_t) { (i) } ) -#define ATOMIC64_INIT(i) ( (atomic64_t) { (i) } ) +#define ATOMIC_INIT(i) { (i) } +#define ATOMIC64_INIT(i) { (i) } #define atomic_read(v) (*(volatile int *)&(v)->counter) #define atomic64_read(v) (*(volatile long *)&(v)->counter)