diff mbox

ACPI: pass correct parameter to acpi_processor_ffh_cstate_probe_cpu()

Message ID 20090312074524.GA15992@localhost (mailing list archive)
State Rejected, archived
Headers show

Commit Message

Fengguang Wu March 12, 2009, 7:45 a.m. UTC
This fixes a NULL pointer dereference bug introduced by 6e911954cac.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Len Brown March 16, 2009, 2:59 a.m. UTC | #1
On Thu, 12 Mar 2009, Wu Fengguang wrote:

> This fixes a NULL pointer dereference bug introduced by 6e911954cac.

What tree is this patch on top of?

thanks,
-Len Brown
Intel Open Source Technology Center

> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> index 6626e8c..b866b87 100644
> --- a/arch/x86/kernel/acpi/cstate.c
> +++ b/arch/x86/kernel/acpi/cstate.c
> @@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
>  	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
>  
>  	retval = smp_call_function_single(cpu,
> -				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
> +				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
>  	if (retval == 0) {
>  		retval = cxcc.retval;
>  		if (retval == 0) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fengguang Wu March 16, 2009, 4:43 a.m. UTC | #2
On Mon, Mar 16, 2009 at 10:59:19AM +0800, Len Brown wrote:
> On Thu, 12 Mar 2009, Wu Fengguang wrote:
> 
> > This fixes a NULL pointer dereference bug introduced by 6e911954cac.
> 
> What tree is this patch on top of?

It's for 2.6.29-rc7-next-20090311. Already fixed in other trees?

Thanks,
Fengguang

> thanks,
> -Len Brown
> Intel Open Source Technology Center
> 
> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> > ---
> > diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> > index 6626e8c..b866b87 100644
> > --- a/arch/x86/kernel/acpi/cstate.c
> > +++ b/arch/x86/kernel/acpi/cstate.c
> > @@ -137,7 +137,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,
> >  	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
> >  
> >  	retval = smp_call_function_single(cpu,
> > -				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
> > +				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
> >  	if (retval == 0) {
> >  		retval = cxcc.retval;
> >  		if (retval == 0) {
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
index 6626e8c..b866b87 100644
--- a/arch/x86/kernel/acpi/cstate.c
+++ b/arch/x86/kernel/acpi/cstate.c
@@ -137,7 +137,7 @@  int acpi_processor_ffh_cstate_probe(unsigned int cpu,
 	/* Run acpi_processor_ffh_cstate_probe_cpu() on the target CPU */
 
 	retval = smp_call_function_single(cpu,
-				acpi_processor_ffh_cstate_probe_cpu, cx, 1);
+				acpi_processor_ffh_cstate_probe_cpu, &cxcc, 1);
 	if (retval == 0) {
 		retval = cxcc.retval;
 		if (retval == 0) {