| Message ID | 1345648585-5176-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, I've a better fix for this here: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6 I already send a pull-req for this to Mauro a while ago, Mauro? Regards, Hans On 08/22/2012 05:16 PM, Guenter Roeck wrote: > Fix build error: > > ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined! > ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined! > > which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not. > > Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if > it is enabled. > > Cc: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/media/radio/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index 8090b87..bee4bee 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -77,6 +77,8 @@ config RADIO_SHARK > config RADIO_SHARK2 > tristate "Griffin radioSHARK2 USB radio receiver" > depends on USB > + select NEW_LEDS > + select LEDS_CLASS > ---help--- > Choose Y here if you have this radio receiver. > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 22, 2012 at 05:22:26PM +0200, Hans de Goede wrote: > Hi, > > I've a better fix for this here: > http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6 > > I already send a pull-req for this to Mauro a while ago, Mauro? > Looks like it found its way into mainline in the last couple of days. Should have updated my tree first. Sorry for the noise. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index 8090b87..bee4bee 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -77,6 +77,8 @@ config RADIO_SHARK config RADIO_SHARK2 tristate "Griffin radioSHARK2 USB radio receiver" depends on USB + select NEW_LEDS + select LEDS_CLASS ---help--- Choose Y here if you have this radio receiver.
Fix build error: ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined! ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined! which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not. Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if it is enabled. Cc: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/media/radio/Kconfig | 2 ++ 1 file changed, 2 insertions(+)