| Message ID | 1344887950-25596-1-git-send-email-joachim.eastwood@jotron.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/13/2012 09:59 PM, Joachim Eastwood : > Include linux/io.h for raw io operations in atmel-scc header. > > This fixes the following build error: > CC [M] sound/soc/atmel/atmel_ssc_dai.o > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': > sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': > sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' > > Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com> Added to at91-fixes for 3.6. Thanks! Arnd, can I queue this one in my upcoming pull-request to you? > --- > include/linux/atmel-ssc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h > index 0602339..4eb3175 100644 > --- a/include/linux/atmel-ssc.h > +++ b/include/linux/atmel-ssc.h > @@ -3,6 +3,7 @@ > > #include <linux/platform_device.h> > #include <linux/list.h> > +#include <linux/io.h> > > struct ssc_device { > struct list_head list; >
On 08/13/2012 09:59 PM, Joachim Eastwood : > Include linux/io.h for raw io operations in atmel-scc header. > > This fixes the following build error: > CC [M] sound/soc/atmel/atmel_ssc_dai.o > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': > sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': > sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' > > Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com> Liam, Mark, May I have your Acked-by for this patch, I plan to queue it with my other at91-related fixes in arm-soc tree? Thanks, best regards, > --- > include/linux/atmel-ssc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h > index 0602339..4eb3175 100644 > --- a/include/linux/atmel-ssc.h > +++ b/include/linux/atmel-ssc.h > @@ -3,6 +3,7 @@ > > #include <linux/platform_device.h> > #include <linux/list.h> > +#include <linux/io.h> > > struct ssc_device { > struct list_head list; >
On Thursday 23 August 2012, Nicolas Ferre wrote: > On 08/13/2012 09:59 PM, Joachim Eastwood : > > Include linux/io.h for raw io operations in atmel-scc header. > > > > This fixes the following build error: > > CC [M] sound/soc/atmel/atmel_ssc_dai.o > > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': > > sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' > > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': > > sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' > > > > Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com> > > Added to at91-fixes for 3.6. Thanks! > > Arnd, can I queue this one in my upcoming pull-request to you? > Sure, no problem. Arnd
On Thu, Aug 23, 2012 at 02:51:25PM +0200, Nicolas Ferre wrote: > May I have your Acked-by for this patch, I plan to queue it with my > other at91-related fixes in arm-soc tree? Don't think the original patch was CCed to me - can you send me a copy please and I'll take a look?
diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h index 0602339..4eb3175 100644 --- a/include/linux/atmel-ssc.h +++ b/include/linux/atmel-ssc.h @@ -3,6 +3,7 @@ #include <linux/platform_device.h> #include <linux/list.h> +#include <linux/io.h> struct ssc_device { struct list_head list;
Include linux/io.h for raw io operations in atmel-scc header. This fixes the following build error: CC [M] sound/soc/atmel/atmel_ssc_dai.o sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com> --- include/linux/atmel-ssc.h | 1 + 1 file changed, 1 insertion(+)