diff mbox

mmc: mmc_spi: Use module_spi_driver

Message ID 1346048622-2024-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Sachin Kamat Aug. 27, 2012, 6:23 a.m. UTC 
module_spi_driver makes the code simpler by eliminating
module_init and module_exit calls.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mmc/host/mmc_spi.c |   15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)

Comments

Chris Ball Aug. 30, 2012, 3:11 p.m. UTC | #1 
Hi,

On Mon, Aug 27 2012, Sachin Kamat wrote:
> module_spi_driver makes the code simpler by eliminating
> module_init and module_exit calls.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/mmc_spi.c |   15 +--------------
>  1 files changed, 1 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 273306c..a600eab 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -1532,20 +1532,7 @@ static struct spi_driver mmc_spi_driver = {
>  	.remove =	__devexit_p(mmc_spi_remove),
>  };
>  
> -
> -static int __init mmc_spi_init(void)
> -{
> -	return spi_register_driver(&mmc_spi_driver);
> -}
> -module_init(mmc_spi_init);
> -
> -
> -static void __exit mmc_spi_exit(void)
> -{
> -	spi_unregister_driver(&mmc_spi_driver);
> -}
> -module_exit(mmc_spi_exit);
> -
> +module_spi_driver(mmc_spi_driver);
>  
>  MODULE_AUTHOR("Mike Lavender, David Brownell, "
>  		"Hans-Peter Nilsson, Jan Nikitenko");

Thanks, pushed to mmc-next for 3.7.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 273306c..a600eab 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1532,20 +1532,7 @@  static struct spi_driver mmc_spi_driver = {
 	.remove =	__devexit_p(mmc_spi_remove),
 };
 
-
-static int __init mmc_spi_init(void)
-{
-	return spi_register_driver(&mmc_spi_driver);
-}
-module_init(mmc_spi_init);
-
-
-static void __exit mmc_spi_exit(void)
-{
-	spi_unregister_driver(&mmc_spi_driver);
-}
-module_exit(mmc_spi_exit);
-
+module_spi_driver(mmc_spi_driver);
 
 MODULE_AUTHOR("Mike Lavender, David Brownell, "
 		"Hans-Peter Nilsson, Jan Nikitenko");