| Message ID | 1346141454-18786-2-git-send-email-anilkumar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* AnilKumar Ch <anilkumar@ti.com> [120828 01:11]: > Adds basic pinctrl device tree data for AM33XX family of devices. > This patch is based on the pinctrl-single driver. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > --- > arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index dde76f7..dfe9c559 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -40,6 +40,15 @@ > }; > }; > > + am3358_pinmux: pinmux@44E10800 { > + compatible = "pinctrl-single"; > + reg = <0x44E10800 0x0238>; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-single,register-width = <32>; > + pinctrl-single,function-mask = <0x7F>; > + }; > + Nit: Please use lower case for the hex numbers as that's the standard in Linux kernel. Tony
On 8/31/2012 2:02 AM, Tony Lindgren wrote: > * AnilKumar Ch <anilkumar@ti.com> [120828 01:11]: >> Adds basic pinctrl device tree data for AM33XX family of devices. >> This patch is based on the pinctrl-single driver. >> >> Signed-off-by: AnilKumar Ch <anilkumar@ti.com> >> --- >> arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index dde76f7..dfe9c559 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -40,6 +40,15 @@ >> }; >> }; >> >> + am3358_pinmux: pinmux@44E10800 { >> + compatible = "pinctrl-single"; >> + reg = <0x44E10800 0x0238>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + pinctrl-single,register-width = <32>; >> + pinctrl-single,function-mask = <0x7F>; >> + }; >> + > > Nit: Please use lower case for the hex numbers as that's the > standard in Linux kernel. > Tony, I could see that you have already merged the patch from Anil for regulator support in bone & evm dts file, which has uppper-case hex numbers. Request you to merge the patch which I submitted to convert all hex numbers to lower-case and then merge all dts changes only with lower-case presentation. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg74393.html Thanks, Vaibhav > Tony > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss >
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index dde76f7..dfe9c559 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -40,6 +40,15 @@ }; }; + am3358_pinmux: pinmux@44E10800 { + compatible = "pinctrl-single"; + reg = <0x44E10800 0x0238>; + #address-cells = <1>; + #size-cells = <0>; + pinctrl-single,register-width = <32>; + pinctrl-single,function-mask = <0x7F>; + }; + /* * XXX: Use a flat representation of the AM33XX interconnect. * The real AM33XX interconnect network is quite complex.Since
Adds basic pinctrl device tree data for AM33XX family of devices. This patch is based on the pinctrl-single driver. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+)