[1/8] gpio: 74x164: Use module_spi_driver boiler plate function

Commit Message

Maxime Ripard Sept. 5, 2012, 8:40 a.m. UTC

Signed-off-by: Maxime Ripard <[e-mail]>
---
 drivers/gpio/gpio-74x164.c |   13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

Comments

Florian Fainelli Sept. 5, 2012, 8:46 a.m. UTC | #1

On Wednesday 05 September 2012 10:40:50 Maxime Ripard wrote:
> Signed-off-by: Maxime Ripard <[e-mail]>

Acked-by: Florian Fainelli <[e-mail]>

> ---
>  drivers/gpio/gpio-74x164.c |   13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index a31ad6f..2975036 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -159,18 +159,7 @@ static struct spi_driver gen_74x164_driver = {
>  	.probe		= gen_74x164_probe,
>  	.remove		= __devexit_p(gen_74x164_remove),
>  };
> -
> -static int __init gen_74x164_init(void)
> -{
> -	return spi_register_driver(&gen_74x164_driver);
> -}
> -subsys_initcall(gen_74x164_init);
> -
> -static void __exit gen_74x164_exit(void)
> -{
> -	spi_unregister_driver(&gen_74x164_driver);
> -}
> -module_exit(gen_74x164_exit);
> +module_spi_driver(gen_74x164_driver);
>  
>  MODULE_AUTHOR("Gabor Juhos <[e-mail]>");
>  MODULE_AUTHOR("Miguel Gaio <[e-mail]>");
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> [e-mail]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thomas Petazzoni Sept. 5, 2012, 9:16 a.m. UTC | #2

Le Wed,  5 Sep 2012 10:40:50 +0200,
Maxime Ripard <[e-mail]> a écrit :

> Signed-off-by: Maxime Ripard <[e-mail]>

Acked-by: Thomas Petazzoni <[e-mail]>

Linus Walleij Sept. 6, 2012, 7:21 a.m. UTC | #3

On Wed, Sep 5, 2012 at 10:40 AM, Maxime Ripard
<[e-mail]> wrote:

> Signed-off-by: Maxime Ripard <[e-mail]>
> ---
>  drivers/gpio/gpio-74x164.c |   13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)

Acked-by: Linus Walleij <[e-mail]>

I guess all of these will go through your kernel tree?
Tell me if you want me to apply these to my GPIO tree.

Yours,
Linus Walleij

Maxime Ripard Sept. 6, 2012, 2:10 p.m. UTC | #4

Hi Linus,

Le 06/09/2012 09:21, Linus Walleij a écrit :
> On Wed, Sep 5, 2012 at 10:40 AM, Maxime Ripard
> <[e-mail]> wrote:
> 
>> Signed-off-by: Maxime Ripard <[e-mail]>
>> ---
>>  drivers/gpio/gpio-74x164.c |   13 +------------
>>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> Acked-by: Linus Walleij <[e-mail]>
> 
> I guess all of these will go through your kernel tree?
> Tell me if you want me to apply these to my GPIO tree.

Since I don't have any kernel tree, I guess you can apply them in your
tree :)

Linus Walleij Sept. 7, 2012, 9:09 p.m. UTC | #5

On Thu, Sep 6, 2012 at 4:10 PM, Maxime Ripard
<[e-mail]> wrote:
> Hi Linus,
> Le 06/09/2012 09:21, Linus Walleij a écrit :
>>
>> Acked-by: Linus Walleij <[e-mail]>
>>
>> I guess all of these will go through your kernel tree?
>> Tell me if you want me to apply these to my GPIO tree.
>
> Since I don't have any kernel tree, I guess you can apply them in your
> tree :)

I was more thinking if the Free Electrons people were doing
composite pull requests to ARM SoC. Oh well, nevermind,
I'll take them.

Applied!

Linus Walleij

Patch

diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
index a31ad6f..2975036 100644
--- a/drivers/gpio/gpio-74x164.c
+++ b/drivers/gpio/gpio-74x164.c
@@ -159,18 +159,7 @@  static struct spi_driver gen_74x164_driver = {
 	.probe		= gen_74x164_probe,
 	.remove		= __devexit_p(gen_74x164_remove),
 };
-
-static int __init gen_74x164_init(void)
-{
-	return spi_register_driver(&gen_74x164_driver);
-}
-subsys_initcall(gen_74x164_init);
-
-static void __exit gen_74x164_exit(void)
-{
-	spi_unregister_driver(&gen_74x164_driver);
-}
-module_exit(gen_74x164_exit);
+module_spi_driver(gen_74x164_driver);
 
 MODULE_AUTHOR("Gabor Juhos <[e-mail]>");
 MODULE_AUTHOR("Miguel Gaio <[e-mail]>");