| Message ID | 1347902538-21208-3-git-send-email-mporter@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Matt Porter <mporter@ti.com> [120917 10:21]: > Enable pinctrl dummy states for all OMAP platforms that don't > populate DT. This allows drivers to be converted to pinctrl > and not generate new warnings on platforms that do not provide > pinctrl data. These platforms already have pinmuxes configured > before the drivers probe. Thanks this should do the trick until we've converted to use DT. I'll queue this for the upcoming merge window. Regards, Tony > Signed-off-by: Matt Porter <mporter@ti.com> > --- > arch/arm/mach-omap2/devices.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c > index 1efa984..6ef4010 100644 > --- a/arch/arm/mach-omap2/devices.c > +++ b/arch/arm/mach-omap2/devices.c > @@ -17,6 +17,7 @@ > #include <linux/err.h> > #include <linux/slab.h> > #include <linux/of.h> > +#include <linux/pinctrl/machine.h> > #include <linux/platform_data/omap4-keypad.h> > > #include <asm/mach-types.h> > @@ -628,6 +629,10 @@ static inline void omap_init_vout(void) {} > > static int __init omap2_init_devices(void) > { > + /* Enable dummy states for those platforms without pinctrl support */ > + if (!of_have_populated_dt()) > + pinctrl_provide_dummies(); > + > /* > * please keep these calls, and their implementations above, > * in alphabetical order so they're easier to sort through. > -- > 1.7.9.5 >
On Mon, Sep 17, 2012 at 7:22 PM, Matt Porter <mporter@ti.com> wrote: > Enable pinctrl dummy states for all OMAP platforms that don't > populate DT. This allows drivers to be converted to pinctrl > and not generate new warnings on platforms that do not provide > pinctrl data. These platforms already have pinmuxes configured > before the drivers probe. > > Signed-off-by: Matt Porter <mporter@ti.com> Looks like a good idea, so FWIW: Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 1efa984..6ef4010 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -17,6 +17,7 @@ #include <linux/err.h> #include <linux/slab.h> #include <linux/of.h> +#include <linux/pinctrl/machine.h> #include <linux/platform_data/omap4-keypad.h> #include <asm/mach-types.h> @@ -628,6 +629,10 @@ static inline void omap_init_vout(void) {} static int __init omap2_init_devices(void) { + /* Enable dummy states for those platforms without pinctrl support */ + if (!of_have_populated_dt()) + pinctrl_provide_dummies(); + /* * please keep these calls, and their implementations above, * in alphabetical order so they're easier to sort through.
Enable pinctrl dummy states for all OMAP platforms that don't populate DT. This allows drivers to be converted to pinctrl and not generate new warnings on platforms that do not provide pinctrl data. These platforms already have pinmuxes configured before the drivers probe. Signed-off-by: Matt Porter <mporter@ti.com> --- arch/arm/mach-omap2/devices.c | 5 +++++ 1 file changed, 5 insertions(+)