| Message ID | Pine.LNX.4.64.1209190105080.31203@axis700.grange (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
(2012/09/19 8:10), Guennadi Liakhovetski wrote: > Upon completion of a MMC_WRITE_MULTIPLE_BLOCK command MMCIF issues an IRQ > with the DTRANE bit set and often with one or several of CMD12 bits set. > If those interrupts are not acknowledged, an additional interrupt can be > produced and will be delivered later, possibly, when the transaction has > already been completed. To prevent this from happening, CMD12 completion > interrupt sources have to be cleared too upon reception of an DTRANE IRQ. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > --- > > Tested on kzm9g and mackerel. Kobayashi-san, this fixes spurious > interrupts, that you are observing. I verified on kzm9g. This works with [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts Tested-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp> > > drivers/mmc/host/sh_mmcif.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c > index 82bf921..387bf63 100644 > --- a/drivers/mmc/host/sh_mmcif.c > +++ b/drivers/mmc/host/sh_mmcif.c > @@ -1213,7 +1213,9 @@ static irqreturn_t sh_mmcif_intr(int irq, void *dev_id) > sh_mmcif_writel(host->addr, MMCIF_CE_INT, ~INT_BUFRE); > sh_mmcif_bitclr(host, MMCIF_CE_INT_MASK, MASK_MBUFRE); > } else if (state & INT_DTRANE) { > - sh_mmcif_writel(host->addr, MMCIF_CE_INT, ~INT_DTRANE); > + sh_mmcif_writel(host->addr, MMCIF_CE_INT, > + ~(INT_CMD12DRE | INT_CMD12RBE | > + INT_CMD12CRE | INT_DTRANE)); > sh_mmcif_bitclr(host, MMCIF_CE_INT_MASK, MASK_MDTRANE); > } else if (state & INT_CMD12RBE) { > sh_mmcif_writel(host->addr, MMCIF_CE_INT, > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Sep 18 2012, Tetsuyuki Kobayashi wrote: > (2012/09/19 8:10), Guennadi Liakhovetski wrote: >> Upon completion of a MMC_WRITE_MULTIPLE_BLOCK command MMCIF issues an IRQ >> with the DTRANE bit set and often with one or several of CMD12 bits set. >> If those interrupts are not acknowledged, an additional interrupt can be >> produced and will be delivered later, possibly, when the transaction has >> already been completed. To prevent this from happening, CMD12 completion >> interrupt sources have to be cleared too upon reception of an DTRANE IRQ. >> >> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> >> --- >> >> Tested on kzm9g and mackerel. Kobayashi-san, this fixes spurious >> interrupts, that you are observing. > > I verified on kzm9g. > This works with > [PATCH] mmc: sh-mmcif: avoid Oops on spurious interrupts > > Tested-by: Tetsuyuki Kobayashi <koba@kmckk.co.jp> Thanks, pushed to mmc-next for 3.7. - Chris.
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 82bf921..387bf63 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1213,7 +1213,9 @@ static irqreturn_t sh_mmcif_intr(int irq, void *dev_id) sh_mmcif_writel(host->addr, MMCIF_CE_INT, ~INT_BUFRE); sh_mmcif_bitclr(host, MMCIF_CE_INT_MASK, MASK_MBUFRE); } else if (state & INT_DTRANE) { - sh_mmcif_writel(host->addr, MMCIF_CE_INT, ~INT_DTRANE); + sh_mmcif_writel(host->addr, MMCIF_CE_INT, + ~(INT_CMD12DRE | INT_CMD12RBE | + INT_CMD12CRE | INT_DTRANE)); sh_mmcif_bitclr(host, MMCIF_CE_INT_MASK, MASK_MDTRANE); } else if (state & INT_CMD12RBE) { sh_mmcif_writel(host->addr, MMCIF_CE_INT,
Upon completion of a MMC_WRITE_MULTIPLE_BLOCK command MMCIF issues an IRQ with the DTRANE bit set and often with one or several of CMD12 bits set. If those interrupts are not acknowledged, an additional interrupt can be produced and will be delivered later, possibly, when the transaction has already been completed. To prevent this from happening, CMD12 completion interrupt sources have to be cleared too upon reception of an DTRANE IRQ. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- Tested on kzm9g and mackerel. Kobayashi-san, this fixes spurious interrupts, that you are observing. drivers/mmc/host/sh_mmcif.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)