| Message ID | 1348055861-7857-3-git-send-email-fabio.porcedda@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 13:57 Wed 19 Sep , Fabio Porcedda wrote: > Tested on an at91sam9260 board (evk-pro3) > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > --- > arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi > index 66389c1..680b1c8 100644 > --- a/arch/arm/boot/dts/at91sam9260.dtsi > +++ b/arch/arm/boot/dts/at91sam9260.dtsi > @@ -233,6 +233,12 @@ > trigger-external; > }; > }; > + > + watchdog@fffffd40 { disable dy default > + compatible = "atmel,at91sam9-wdt"; > + reg = <0xfffffd40 0x10>; > + }; > + Best Regards, J.
Hi Jean-Christophe, On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote: > On 13:57 Wed 19 Sep , Fabio Porcedda wrote: >> Tested on an at91sam9260 board (evk-pro3) >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> --- >> arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi >> index 66389c1..680b1c8 100644 >> --- a/arch/arm/boot/dts/at91sam9260.dtsi >> +++ b/arch/arm/boot/dts/at91sam9260.dtsi >> @@ -233,6 +233,12 @@ >> trigger-external; >> }; >> }; >> + >> + watchdog@fffffd40 { > disable dy default All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default. IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver, they are safe to be enabled by default. I'm missing something? >> + compatible = "atmel,at91sam9-wdt"; >> + reg = <0xfffffd40 0x10>; >> + }; >> + > > Best Regards, > J. Thanks for the review
On 09:52 Thu 20 Sep , Fabio Porcedda wrote: > Hi Jean-Christophe, > > On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD > <plagnioj@jcrosoft.com> wrote: > > On 13:57 Wed 19 Sep , Fabio Porcedda wrote: > >> Tested on an at91sam9260 board (evk-pro3) > >> > >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > >> --- > >> arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi > >> index 66389c1..680b1c8 100644 > >> --- a/arch/arm/boot/dts/at91sam9260.dtsi > >> +++ b/arch/arm/boot/dts/at91sam9260.dtsi > >> @@ -233,6 +233,12 @@ > >> trigger-external; > >> }; > >> }; > >> + > >> + watchdog@fffffd40 { > > disable dy default > > All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default. > IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver, > they are safe to be enabled by default. > I'm missing something? no the other watchdog will not reset if not managed this one will so I'm not confortable by enabling it by default Best Regards, J.
On Thu, Sep 20, 2012 at 12:07 PM, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote: > On 09:52 Thu 20 Sep , Fabio Porcedda wrote: >> Hi Jean-Christophe, >> >> On Thu, Sep 20, 2012 at 7:29 AM, Jean-Christophe PLAGNIOL-VILLARD >> <plagnioj@jcrosoft.com> wrote: >> > On 13:57 Wed 19 Sep , Fabio Porcedda wrote: >> >> Tested on an at91sam9260 board (evk-pro3) >> >> >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> >> --- >> >> arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++ >> >> 1 file changed, 6 insertions(+) >> >> >> >> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi >> >> index 66389c1..680b1c8 100644 >> >> --- a/arch/arm/boot/dts/at91sam9260.dtsi >> >> +++ b/arch/arm/boot/dts/at91sam9260.dtsi >> >> @@ -233,6 +233,12 @@ >> >> trigger-external; >> >> }; >> >> }; >> >> + >> >> + watchdog@fffffd40 { >> > disable dy default >> >> All the others watchdog drivers in arch/arm/boot/dts/* are enabled by default. >> IMHO the watchdog driver it's like the "rtstc" and "shdwc" driver, >> they are safe to be enabled by default. >> I'm missing something? > no the other watchdog will not reset if not managed > > this one will > > so I'm not confortable by enabling it by default Ok, i will send an updated patch. Thanks for the review
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi index 66389c1..680b1c8 100644 --- a/arch/arm/boot/dts/at91sam9260.dtsi +++ b/arch/arm/boot/dts/at91sam9260.dtsi @@ -233,6 +233,12 @@ trigger-external; }; }; + + watchdog@fffffd40 { + compatible = "atmel,at91sam9-wdt"; + reg = <0xfffffd40 0x10>; + }; + }; nand0: nand@40000000 {
Tested on an at91sam9260 board (evk-pro3) Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- arch/arm/boot/dts/at91sam9260.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)