diff mbox

[3/3] ARM: dts: cfa10049: Add the i2c muxer buses to the CFA-10049

Message ID 1348480425-13848-3-git-send-email-maxime.ripard@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Maxime Ripard Sept. 24, 2012, 9:53 a.m. UTC
This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555
GPIO expander eventually.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 arch/arm/boot/dts/imx28-cfa10049.dts |   33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Sergei Shtylyov Sept. 24, 2012, 11:52 a.m. UTC | #1
Hello.

On 24-09-2012 13:53, Maxime Ripard wrote:

> This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555
> GPIO expander eventually.

> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
>   arch/arm/boot/dts/imx28-cfa10049.dts |   33 +++++++++++++++++++++++++++++++++
>   1 file changed, 33 insertions(+)

> diff --git a/arch/arm/boot/dts/imx28-cfa10049.dts b/arch/arm/boot/dts/imx28-cfa10049.dts
> index a9288fb..9a55632 100644
> --- a/arch/arm/boot/dts/imx28-cfa10049.dts
> +++ b/arch/arm/boot/dts/imx28-cfa10049.dts
> @@ -76,6 +76,39 @@
>   				status = "okay";
>   			};
>
> +			i2cmux {
> +				compatible = "i2c-mux-gpio";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				mux-gpios = <&gpio1 22 0 &gpio1 23 0>;
> +				i2c-parent = <&i2c1>;
> +
> +				i2c@0 {
> +					reg = <0>;
> +					#address-cells = <1>;
> +					#size-cells = <0>;

    If you don't have any subnodes the above to props have no sense.

> +				};
> +

WBR, Sergei
Maxime Ripard Sept. 25, 2012, 2:02 p.m. UTC | #2
Hi

Le 24/09/2012 13:52, Sergei Shtylyov a écrit :
> On 24-09-2012 13:53, Maxime Ripard wrote:
> 
>> This will allow to add the 3 Nuvoton NAU7802 ADCs and the NXP PCA9555
>> GPIO expander eventually.
> 
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>>   arch/arm/boot/dts/imx28-cfa10049.dts |   33
>> +++++++++++++++++++++++++++++++++
>>   1 file changed, 33 insertions(+)
> 
>> diff --git a/arch/arm/boot/dts/imx28-cfa10049.dts
>> b/arch/arm/boot/dts/imx28-cfa10049.dts
>> index a9288fb..9a55632 100644
>> --- a/arch/arm/boot/dts/imx28-cfa10049.dts
>> +++ b/arch/arm/boot/dts/imx28-cfa10049.dts
>> @@ -76,6 +76,39 @@
>>                   status = "okay";
>>               };
>>
>> +            i2cmux {
>> +                compatible = "i2c-mux-gpio";
>> +                #address-cells = <1>;
>> +                #size-cells = <0>;
>> +                mux-gpios = <&gpio1 22 0 &gpio1 23 0>;
>> +                i2c-parent = <&i2c1>;
>> +
>> +                i2c@0 {
>> +                    reg = <0>;
>> +                    #address-cells = <1>;
>> +                    #size-cells = <0>;
> 
>    If you don't have any subnodes the above to props have no sense.

I will use them with subnodes eventually, with the 3 ADCs and the GPIO
expander. So these nodes won't be left empty.

On another hand, I can add these props when I'll add the devices, I have
no strong opinion here.

Maxime
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx28-cfa10049.dts b/arch/arm/boot/dts/imx28-cfa10049.dts
index a9288fb..9a55632 100644
--- a/arch/arm/boot/dts/imx28-cfa10049.dts
+++ b/arch/arm/boot/dts/imx28-cfa10049.dts
@@ -76,6 +76,39 @@ 
 				status = "okay";
 			};
 
+			i2cmux {
+				compatible = "i2c-mux-gpio";
+				#address-cells = <1>;
+				#size-cells = <0>;
+				mux-gpios = <&gpio1 22 0 &gpio1 23 0>;
+				i2c-parent = <&i2c1>;
+
+				i2c@0 {
+					reg = <0>;
+					#address-cells = <1>;
+					#size-cells = <0>;
+				};
+
+				i2c@1 {
+				      reg = <1>;
+				      #address-cells = <1>;
+				      #size-cells = <0>;
+				};
+
+				i2c@2 {
+					reg = <2>;
+					#address-cells = <1>;
+					#size-cells = <0>;
+				};
+
+				i2c@3 {
+					reg = <3>;
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+				};
+			};
+
 			usbphy1: usbphy@8007e000 {
 				status = "okay";
 			};