diff mbox

ARM: am33xx: clk: Update clkdev table to add mcasp alias

Message ID 1348509399-3391-1-git-send-email-hvaibhav@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vaibhav Hiremath Sept. 24, 2012, 5:56 p.m. UTC
After Rajendra's common-clock preparation series,
commit (a1978ef4da1 - ARM: omap: hwmod: get rid of
all omap_clk_get_by_name usage) the clkdev table need to
update with an entry for clocks used by hwmod to have
clock name same as the alias.

Without this, the clk_get() in omap_hwmod would fail.

Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
---
 arch/arm/mach-omap2/clock33xx_data.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Paul Walmsley Sept. 24, 2012, 6:33 p.m. UTC | #1
On Mon, 24 Sep 2012, Vaibhav Hiremath wrote:

> After Rajendra's common-clock preparation series,
> commit (a1978ef4da1 - ARM: omap: hwmod: get rid of
> all omap_clk_get_by_name usage) the clkdev table need to
> update with an entry for clocks used by hwmod to have
> clock name same as the alias.
> 
> Without this, the clk_get() in omap_hwmod would fail.
> 
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>

Tony, if you want to take this, it's

Acked-by: Paul Walmsley <paul@pwsan.com>

otherwise we'll wait for -rc1.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Sept. 24, 2012, 6:49 p.m. UTC | #2
* Paul Walmsley <paul@pwsan.com> [120924 11:34]:
> On Mon, 24 Sep 2012, Vaibhav Hiremath wrote:
> 
> > After Rajendra's common-clock preparation series,
> > commit (a1978ef4da1 - ARM: omap: hwmod: get rid of
> > all omap_clk_get_by_name usage) the clkdev table need to
> > update with an entry for clocks used by hwmod to have
> > clock name same as the alias.
> > 
> > Without this, the clk_get() in omap_hwmod would fail.
> > 
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> 
> Tony, if you want to take this, it's
> 
> Acked-by: Paul Walmsley <paul@pwsan.com>
> 
> otherwise we'll wait for -rc1.

Please just go ahead and queue it as a fix.

We should get a fixes branch in before -rc1 is tagged
so -rc1 works for us.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Walmsley Sept. 24, 2012, 8:57 p.m. UTC | #3
On Mon, 24 Sep 2012, Tony Lindgren wrote:

> * Paul Walmsley <paul@pwsan.com> [120924 11:34]:
> > On Mon, 24 Sep 2012, Vaibhav Hiremath wrote:
> > 
> > > After Rajendra's common-clock preparation series,
> > > commit (a1978ef4da1 - ARM: omap: hwmod: get rid of
> > > all omap_clk_get_by_name usage) the clkdev table need to
> > > update with an entry for clocks used by hwmod to have
> > > clock name same as the alias.
> > > 
> > > Without this, the clk_get() in omap_hwmod would fail.
> > > 
> > > Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> > 
> > Tony, if you want to take this, it's
> > 
> > Acked-by: Paul Walmsley <paul@pwsan.com>
> > 
> > otherwise we'll wait for -rc1.
> 
> Please just go ahead and queue it as a fix.
> 
> We should get a fixes branch in before -rc1 is tagged
> so -rc1 works for us.

OK, will send a pull request once devel-late goes upstream.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c
index b87b88c..114ab4b 100644
--- a/arch/arm/mach-omap2/clock33xx_data.c
+++ b/arch/arm/mach-omap2/clock33xx_data.c
@@ -1035,6 +1035,8 @@  static struct omap_clk am33xx_clks[] = {
 	CLK(NULL,	"pruss_ocp_gclk",	&pruss_ocp_gclk,	CK_AM33XX),
 	CLK("davinci-mcasp.0",  NULL,           &mcasp0_fck,    CK_AM33XX),
 	CLK("davinci-mcasp.1",  NULL,           &mcasp1_fck,    CK_AM33XX),
+	CLK(NULL,	"mcasp0_fck",		&mcasp0_fck,	CK_AM33XX),
+	CLK(NULL,	"mcasp1_fck",		&mcasp1_fck,	CK_AM33XX),
 	CLK("NULL",	"mmc2_fck",		&mmc2_fck,	CK_AM33XX),
 	CLK(NULL,	"mmu_fck",		&mmu_fck,	CK_AM33XX),
 	CLK(NULL,	"smartreflex0_fck",	&smartreflex0_fck,	CK_AM33XX),