| Message ID | 1349165603-24401-9-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 2, 2012 at 10:13 AM, Lee Jones <lee.jones@linaro.org> wrote: > As there will be a Device Tree created for the UIBs, there is no > need to call the UIB initiation functions. Each device will be > detailed and registered from the Device Tree instead. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by, but... > - .init_late = ux500_init_late, > + .init_late = NULL, Why even define it? Yours, Linus Walleij
On Tue, 02 Oct 2012, Linus Walleij wrote: > On Tue, Oct 2, 2012 at 10:13 AM, Lee Jones <lee.jones@linaro.org> wrote: > > > As there will be a Device Tree created for the UIBs, there is no > > need to call the UIB initiation functions. Each device will be > > detailed and registered from the Device Tree instead. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Acked-by, but... > > > - .init_late = ux500_init_late, > > + .init_late = NULL, > > Why even define it? More to show that we're _intentionally_ not using it. I'm happy to remove if it offends you? :)
On Tue, Oct 2, 2012 at 2:15 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Tue, 02 Oct 2012, Linus Walleij wrote: > >> On Tue, Oct 2, 2012 at 10:13 AM, Lee Jones <lee.jones@linaro.org> wrote: >> >> > As there will be a Device Tree created for the UIBs, there is no >> > need to call the UIB initiation functions. Each device will be >> > detailed and registered from the Device Tree instead. >> > >> > Signed-off-by: Lee Jones <lee.jones@linaro.org> >> >> Acked-by, but... >> >> > - .init_late = ux500_init_late, >> > + .init_late = NULL, >> >> Why even define it? > > More to show that we're _intentionally_ not using it. > > I'm happy to remove if it offends you? :) No, I was just asking. I did ACK it... Thanks, Linus Walleij
diff --git a/arch/arm/mach-ux500/cpu-db8500.c b/arch/arm/mach-ux500/cpu-db8500.c index 610ad7f..f85659b 100644 --- a/arch/arm/mach-ux500/cpu-db8500.c +++ b/arch/arm/mach-ux500/cpu-db8500.c @@ -345,7 +345,7 @@ DT_MACHINE_START(U8500_DT, "ST-Ericsson U8500 platform (Device Tree Support)") .timer = &ux500_timer, .handle_irq = gic_handle_irq, .init_machine = u8500_init_machine, - .init_late = ux500_init_late, + .init_late = NULL, .dt_compat = u8500_dt_board_compat, MACHINE_END
As there will be a Device Tree created for the UIBs, there is no need to call the UIB initiation functions. Each device will be detailed and registered from the Device Tree instead. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/mach-ux500/cpu-db8500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)