| Message ID | 20090326111207.7b8a1336@pedra.chehab.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: > On Tue, 24 Mar 2009 23:07:02 -0500 (CDT) > Mike Isely <isely@isely.net> wrote: > > > > > Mauro: > > > > Please pull from http://linuxtv.org/hg/~mcisely/pvrusb2 for a large > > collection of pvrusb2 changesets (see below). > > You forgot to add pvrusb2-cs53l32a.o on your Makefile. > > I'll add it and merge with the correspond patch that added this patch, to avoid > bisect breakage. Damn. Sorry about that. Usually I *do* catch things like that :-( Thanks for spotting and fixing it. There might be another problem - I did test compile and run all this from within v4l-dvb. With that file missing it should not have loaded correctly, which means I must have missed something else too. I will double check this. -Mike
On Thu, 26 Mar 2009 09:16:55 -0500 (CDT) Mike Isely <isely@isely.net> wrote: > On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: > > > On Tue, 24 Mar 2009 23:07:02 -0500 (CDT) > > Mike Isely <isely@isely.net> wrote: > > > > > > > > Mauro: > > > > > > Please pull from http://linuxtv.org/hg/~mcisely/pvrusb2 for a large > > > collection of pvrusb2 changesets (see below). > > > > You forgot to add pvrusb2-cs53l32a.o on your Makefile. > > > > I'll add it and merge with the correspond patch that added this patch, to avoid > > bisect breakage. > > Damn. Sorry about that. Usually I *do* catch things like that :-( > Thanks for spotting and fixing it. > > There might be another problem - I did test compile and run all this > from within v4l-dvb. With that file missing it should not have loaded > correctly, which means I must have missed something else too. I will > double check this. Ok. PS: I couldn't push the patch to linuxtv yet, although it is already on my tree. It seems that the linuxtv machine migration is happening right now (or the file system sync). After it returning back, I'll push the patch there. I'll anyway do the -git fix. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-2.6.29.noarch.orig/drivers/media/video/pvrusb2/Makefile +++ linux-2.6.29.noarch/drivers/media/video/pvrusb2/Makefile @@ -10,6 +10,7 @@ pvrusb2-objs := pvrusb2-i2c-core.o \ pvrusb2-ctrl.o pvrusb2-std.o pvrusb2-devattr.o \ pvrusb2-context.o pvrusb2-io.o pvrusb2-ioread.o \ pvrusb2-cx2584x-v4l.o pvrusb2-wm8775.o \ + pvrusb2-cs53l32a.o \ $(obj-pvrusb2-dvb-y) \ $(obj-pvrusb2-sysfs-y) $(obj-pvrusb2-debugifc-y)