diff mbox

Android.mk: use LOCAL_COPY_HEADERS to export headers. v2

Message ID 1349688236-24932-1-git-send-email-tapani.palli@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tapani Pälli Oct. 8, 2012, 9:23 a.m. UTC 
From: Haitao Huang <haitao.huang@intel.com>

Export necessary header files used by other components for Android,
such as libva intel-driver, gralloc, hwcomposer, etc.

Signed-off-by: Haitao Huang <haitao.huang@intel.com>
[chad: Fixed inconsistent indentation.]
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
---
 Android.mk | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Oliver McFadden Oct. 8, 2012, 11:43 a.m. UTC | #1 
On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani Pälli wrote:
> From: Haitao Huang <haitao.huang@intel.com>
> 
> Export necessary header files used by other components for Android,
> such as libva intel-driver, gralloc, hwcomposer, etc.
> 
> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
> [chad: Fixed inconsistent indentation.]
> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
> ---

Normal syntax is "Subject: [PATCH v2 N/M] ..."  You should add a comment
here describing the v1..v2 diff.

>  Android.mk | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Android.mk b/Android.mk
> index 1029dc6..68db5df 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -1,5 +1,5 @@
>  #
> -# Copyright © 2011 Intel Corporation
> +# Copyright © 2011-2012 Intel Corporation
>  #
>  # Permission is hereby granted, free of charge, to any person obtaining a
>  # copy of this software and associated documentation files (the "Software"),
> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>  LOCAL_CFLAGS := \
>  	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>  
> +LOCAL_COPY_HEADERS :=            \
> +	xf86drm.h                \
> +	include/drm/drm_fourcc.h \
> +	include/drm/drm.h        \
> +	include/drm/drm_mode.h   \
> +	include/drm/drm_sarea.h  \
> +	include/drm/i915_drm.h   \
> +	intel/intel_bufmgr.h     \
> +
> +LOCAL_COPY_HEADERS_TO := libdrm
>  include $(BUILD_SHARED_LIBRARY)
>  
>  include $(LOCAL_PATH)/intel/Android.mk
> -- 
> 1.7.11.7
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Tapani Pälli Oct. 8, 2012, 12:45 p.m. UTC | #2 
On 10/08/2012 02:43 PM, Oliver McFadden wrote:
> On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani Pälli wrote:
>> From: Haitao Huang <haitao.huang@intel.com>
>>
>> Export necessary header files used by other components for Android,
>> such as libva intel-driver, gralloc, hwcomposer, etc.
>>
>> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
>> [chad: Fixed inconsistent indentation.]
>> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
>> ---
> 
> Normal syntax is "Subject: [PATCH v2 N/M] ..."  You should add a comment
> here describing the v1..v2 diff.

ok, I took away the gerrit 'change-id' row, I'll send v3 with your
suggested changes.

>>  Android.mk | 12 +++++++++++-
>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/Android.mk b/Android.mk
>> index 1029dc6..68db5df 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -1,5 +1,5 @@
>>  #
>> -# Copyright © 2011 Intel Corporation
>> +# Copyright © 2011-2012 Intel Corporation
>>  #
>>  # Permission is hereby granted, free of charge, to any person obtaining a
>>  # copy of this software and associated documentation files (the "Software"),
>> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>>  LOCAL_CFLAGS := \
>>  	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>>  
>> +LOCAL_COPY_HEADERS :=            \
>> +	xf86drm.h                \
>> +	include/drm/drm_fourcc.h \
>> +	include/drm/drm.h        \
>> +	include/drm/drm_mode.h   \
>> +	include/drm/drm_sarea.h  \
>> +	include/drm/i915_drm.h   \
>> +	intel/intel_bufmgr.h     \
>> +
>> +LOCAL_COPY_HEADERS_TO := libdrm
>>  include $(BUILD_SHARED_LIBRARY)
>>  
>>  include $(LOCAL_PATH)/intel/Android.mk
>> -- 
>> 1.7.11.7
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Chad Versace Oct. 10, 2012, 5:01 p.m. UTC | #3 
Is the only difference between v2 and v1 of this patch the removal of the
Change-ID tag?

On 10/08/2012 02:23 AM, Tapani Pälli wrote:
> From: Haitao Huang <haitao.huang@intel.com>
> 
> Export necessary header files used by other components for Android,
> such as libva intel-driver, gralloc, hwcomposer, etc.
> 
> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
> [chad: Fixed inconsistent indentation.]
> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
> ---
>  Android.mk | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Android.mk b/Android.mk
> index 1029dc6..68db5df 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -1,5 +1,5 @@
>  #
> -# Copyright © 2011 Intel Corporation
> +# Copyright © 2011-2012 Intel Corporation
>  #
>  # Permission is hereby granted, free of charge, to any person obtaining a
>  # copy of this software and associated documentation files (the "Software"),
> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>  LOCAL_CFLAGS := \
>  	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>  
> +LOCAL_COPY_HEADERS :=            \
> +	xf86drm.h                \
> +	include/drm/drm_fourcc.h \
> +	include/drm/drm.h        \
> +	include/drm/drm_mode.h   \
> +	include/drm/drm_sarea.h  \
> +	include/drm/i915_drm.h   \
> +	intel/intel_bufmgr.h     \
> +
> +LOCAL_COPY_HEADERS_TO := libdrm
>  include $(BUILD_SHARED_LIBRARY)
>  
>  include $(LOCAL_PATH)/intel/Android.mk
>
Tapani Pälli Oct. 11, 2012, 8:55 a.m. UTC | #4 
On 10/10/2012 08:01 PM, Chad Versace wrote:
> Is the only difference between v2 and v1 of this patch the removal of the
> Change-ID tag?

yep that is the diff (sorry for not noting it), there is the v3 as well
where I've removed the [] comment per Oliver's suggestion.


> On 10/08/2012 02:23 AM, Tapani Pälli wrote:
>> From: Haitao Huang <haitao.huang@intel.com>
>>
>> Export necessary header files used by other components for Android,
>> such as libva intel-driver, gralloc, hwcomposer, etc.
>>
>> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
>> [chad: Fixed inconsistent indentation.]
>> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
>> ---
>>  Android.mk | 12 +++++++++++-
>>  1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/Android.mk b/Android.mk
>> index 1029dc6..68db5df 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -1,5 +1,5 @@
>>  #
>> -# Copyright © 2011 Intel Corporation
>> +# Copyright © 2011-2012 Intel Corporation
>>  #
>>  # Permission is hereby granted, free of charge, to any person obtaining a
>>  # copy of this software and associated documentation files (the "Software"),
>> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>>  LOCAL_CFLAGS := \
>>  	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>>  
>> +LOCAL_COPY_HEADERS :=            \
>> +	xf86drm.h                \
>> +	include/drm/drm_fourcc.h \
>> +	include/drm/drm.h        \
>> +	include/drm/drm_mode.h   \
>> +	include/drm/drm_sarea.h  \
>> +	include/drm/i915_drm.h   \
>> +	intel/intel_bufmgr.h     \
>> +
>> +LOCAL_COPY_HEADERS_TO := libdrm
>>  include $(BUILD_SHARED_LIBRARY)
>>  
>>  include $(LOCAL_PATH)/intel/Android.mk
>>
>
diff mbox

Patch

diff --git a/Android.mk b/Android.mk
index 1029dc6..68db5df 100644
--- a/Android.mk
+++ b/Android.mk
@@ -1,5 +1,5 @@ 
 #
-# Copyright © 2011 Intel Corporation
+# Copyright © 2011-2012 Intel Corporation
 #
 # Permission is hereby granted, free of charge, to any person obtaining a
 # copy of this software and associated documentation files (the "Software"),
@@ -45,6 +45,16 @@  LOCAL_C_INCLUDES := \
 LOCAL_CFLAGS := \
 	-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
 
+LOCAL_COPY_HEADERS :=            \
+	xf86drm.h                \
+	include/drm/drm_fourcc.h \
+	include/drm/drm.h        \
+	include/drm/drm_mode.h   \
+	include/drm/drm_sarea.h  \
+	include/drm/i915_drm.h   \
+	intel/intel_bufmgr.h     \
+
+LOCAL_COPY_HEADERS_TO := libdrm
 include $(BUILD_SHARED_LIBRARY)
 
 include $(LOCAL_PATH)/intel/Android.mk