| Message ID | 1349943081-27939-2-git-send-email-t.figa@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Oct 11, 2012 at 10:11 AM, Tomasz Figa <t.figa@samsung.com> wrote: > This patch modifies the pinctrl-samsung driver to detect when width of a > bit field is set to zero (which means that such configuraton type is not > supported) and return an error instead of trying to modify an inexistent > register. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> I'm quite happy with these 17 patches, but I'd like to have Thomas Abraham's definitive ACK before I merge anything. Yours, Linus Walleij
Hi Linus, On Thu, Oct 11, 2012 at 10:57 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Oct 11, 2012 at 10:11 AM, Tomasz Figa <t.figa@samsung.com> wrote: > >> This patch modifies the pinctrl-samsung driver to detect when width of a >> bit field is set to zero (which means that such configuraton type is not >> supported) and return an error instead of trying to modify an inexistent >> register. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> > > I'm quite happy with these 17 patches, but I'd like to have Thomas > Abraham's definitive ACK before I merge anything. Thomas did ACK at [00/17] ... mail. Thank you, Kyungmin Park > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 11, 2012 at 4:00 PM, Kyungmin Park <kmpark@infradead.org> wrote: > On Thu, Oct 11, 2012 at 10:57 PM, Linus Walleij > <linus.walleij@linaro.org> wrote: >> I'm quite happy with these 17 patches, but I'd like to have Thomas >> Abraham's definitive ACK before I merge anything. > Thomas did ACK at [00/17] ... mail. Yeah I missed this because of too much mail, I'm applying & testing now... Thanks! Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-samsung.c b/drivers/pinctrl/pinctrl-samsung.c index dd108a9..c660fa5 100644 --- a/drivers/pinctrl/pinctrl-samsung.c +++ b/drivers/pinctrl/pinctrl-samsung.c @@ -391,6 +391,9 @@ static int samsung_pinconf_rw(struct pinctrl_dev *pctldev, unsigned int pin, return -EINVAL; } + if (!width) + return -EINVAL; + mask = (1 << width) - 1; shift = pin_offset * width; data = readl(reg_base + cfg_reg);
This patch modifies the pinctrl-samsung driver to detect when width of a bit field is set to zero (which means that such configuraton type is not supported) and return an error instead of trying to modify an inexistent register. Signed-off-by: Tomasz Figa <t.figa@samsung.com> --- drivers/pinctrl/pinctrl-samsung.c | 3 +++ 1 file changed, 3 insertions(+)