diff mbox

[1/5] ARM: AT91: Fix build failure on board-dt

Message ID 1350251199-28065-2-git-send-email-manabian@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Joachim Eastwood Oct. 14, 2012, 9:46 p.m. UTC
We need CONFIG_SOC_AT91SAM9 to get the at91sam926x_timer
symbol used in board-dt.

Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---
 arch/arm/mach-at91/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jean-Christophe PLAGNIOL-VILLARD Oct. 15, 2012, 5:59 a.m. UTC | #1
On 23:46 Sun 14 Oct     , Joachim Eastwood wrote:
> We need CONFIG_SOC_AT91SAM9 to get the at91sam926x_timer
> symbol used in board-dt.
as I said before you can not do a select you need to do a depends

as you will have no clock as you select no SoC

Best Regards,
J.
> 
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
>  arch/arm/mach-at91/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
> index 0fafb6a..d9b0546 100644
> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
> @@ -507,6 +507,7 @@ comment "Generic Board Type"
>  
>  config MACH_AT91SAM_DT
>  	bool "Atmel AT91SAM Evaluation Kits with device-tree support"
> +	select SOC_AT91SAM9
>  	select USE_OF
>  	help
>  	  Select this if you want to experiment device-tree with
> -- 
> 1.7.12.3
>
Joachim Eastwood Oct. 15, 2012, 7:12 a.m. UTC | #2
On Mon, Oct 15, 2012 at 7:59 AM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj@jcrosoft.com> wrote:
> On 23:46 Sun 14 Oct     , Joachim Eastwood wrote:
>> We need CONFIG_SOC_AT91SAM9 to get the at91sam926x_timer
>> symbol used in board-dt.
> as I said before you can not do a select you need to do a depends
>
> as you will have no clock as you select no SoC

Yes, the board-dt will not boot without a SoC.

Changing it to depend will hide board-dt until you choose a SoC I
assume this is the behavior we want then.

I'll change both patches to use depend in Kconfig.

regards
Joachim Eastwood


> Best Regards,
> J.
diff mbox

Patch

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 0fafb6a..d9b0546 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -507,6 +507,7 @@  comment "Generic Board Type"
 
 config MACH_AT91SAM_DT
 	bool "Atmel AT91SAM Evaluation Kits with device-tree support"
+	select SOC_AT91SAM9
 	select USE_OF
 	help
 	  Select this if you want to experiment device-tree with