| Message ID | 1351438555-4668-5-git-send-email-anarsoul@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Vasily Khoruzhick, > Recent changes to PXA PWM support changed the PXA27X PWM device > numbering scheme, so keyboard and LCD backlight is not > working anymore on Z2. > > Fix it and move from legacy to new PWM API. The proper fix here would be to start moving towards DT. > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> [...] Best regards, Marek Vasut
On Mon, Oct 29, 2012 at 1:01 AM, Marek Vasut <marex@denx.de> wrote: > Dear Vasily Khoruzhick, > >> Recent changes to PXA PWM support changed the PXA27X PWM device >> numbering scheme, so keyboard and LCD backlight is not >> working anymore on Z2. >> >> Fix it and move from legacy to new PWM API. > > The proper fix here would be to start moving towards DT. > >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > [...] > > Best regards, > Marek Vasut Dear Marek Vasut, Sure, but it'll take some time. For now this simple fix is sufficient. I'll get DT working for pxa27x to familiarize myself with DT. Regards Vasily
Dear Vasily Khoruzhick, > On Mon, Oct 29, 2012 at 1:01 AM, Marek Vasut <marex@denx.de> wrote: > > Dear Vasily Khoruzhick, > > > >> Recent changes to PXA PWM support changed the PXA27X PWM device > >> numbering scheme, so keyboard and LCD backlight is not > >> working anymore on Z2. > >> > >> Fix it and move from legacy to new PWM API. > > > > The proper fix here would be to start moving towards DT. > > > >> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> > > > > [...] > > > > Best regards, > > Marek Vasut > > Dear Marek Vasut, > > Sure, but it'll take some time. For now this simple fix is sufficient. > I'll get DT working for pxa27x to familiarize myself with DT. Good, please focus yourself onto DT as the legacy implementations are not too favored anymore. Best regards, Marek Vasut
diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c index fac7cba..06b8078 100644 --- a/arch/arm/mach-pxa/z2.c +++ b/arch/arm/mach-pxa/z2.c @@ -16,6 +16,7 @@ #include <linux/platform_device.h> #include <linux/mtd/mtd.h> #include <linux/mtd/partitions.h> +#include <linux/pwm.h> #include <linux/pwm_backlight.h> #include <linux/z2_battery.h> #include <linux/dma-mapping.h> @@ -206,17 +207,22 @@ static inline void z2_nor_init(void) {} * Backlight ******************************************************************************/ #if defined(CONFIG_BACKLIGHT_PWM) || defined(CONFIG_BACKLIGHT_PWM_MODULE) +static struct pwm_lookup z2_pwm_lookup[] = { + PWM_LOOKUP("pxa27x-pwm.0", 1, "pwm-backlight.0", NULL), + PWM_LOOKUP("pxa27x-pwm.1", 0, "pwm-backlight.1", NULL), +}; + static struct platform_pwm_backlight_data z2_backlight_data[] = { [0] = { /* Keypad Backlight */ - .pwm_id = 1, + .pwm_id = -1, .max_brightness = 1023, .dft_brightness = 0, .pwm_period_ns = 1260320, }, [1] = { /* LCD Backlight */ - .pwm_id = 2, + .pwm_id = -1, .max_brightness = 1023, .dft_brightness = 512, .pwm_period_ns = 1260320, @@ -243,6 +249,7 @@ static void __init z2_pwm_init(void) { platform_device_register(&z2_backlight_devices[0]); platform_device_register(&z2_backlight_devices[1]); + pwm_add_table(z2_pwm_lookup, ARRAY_SIZE(z2_pwm_lookup)); } #else static inline void z2_pwm_init(void) {}
Recent changes to PXA PWM support changed the PXA27X PWM device numbering scheme, so keyboard and LCD backlight is not working anymore on Z2. Fix it and move from legacy to new PWM API. Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- arch/arm/mach-pxa/z2.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)