diff mbox

[4/5] ARM: PXA: Zipit Z2: Change active_state of power button

Message ID 1351438555-4668-4-git-send-email-anarsoul@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vasily Khoruzhick Oct. 28, 2012, 3:35 p.m. UTC 
From: mcmajeres <mark@engine12.com>

Otherwise userspace might be confused about button state

Signed-off-by: mcmajeres <mark@engine12.com>
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 arch/arm/mach-pxa/z2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut Oct. 28, 2012, 10:01 p.m. UTC | #1 
Dear Vasily Khoruzhick,

> From: mcmajeres <mark@engine12.com>

Read [1]

> Otherwise userspace might be confused about button state
> 
> Signed-off-by: mcmajeres <mark@engine12.com>

Attribution of code shall be done only towards people known by their name.

> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm/mach-pxa/z2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
> index ce90fa9..fac7cba 100644
> --- a/arch/arm/mach-pxa/z2.c
> +++ b/arch/arm/mach-pxa/z2.c
> @@ -437,7 +437,7 @@ static struct gpio_keys_button z2_pxa_buttons[] = {
>  	{
>  		.code		= KEY_POWER,
>  		.gpio		= GPIO1_ZIPITZ2_POWER_BUTTON,
> -		.active_low	= 0,
> +		.active_low	= 1,
>  		.desc		= "Power Button",
>  		.wakeup		= 1,
>  		.type		= EV_KEY,

[1] http://lwn.net/Articles/195643/

Best regards,
Marek Vasut
mark@engine12.com Oct. 28, 2012, 10:31 p.m. UTC | #2 
full name include:

On 2012-10-28 15:01, Marek Vasut wrote:
> Dear Vasily Khoruzhick,
>
>> From: Mark Majeres <mark@engine12.com>
>
> Read [1]
>
>> Otherwise userspace might be confused about button state
>>
>> Signed-off-by: Mark Majeres <mark@engine12.com>
>
> Attribution of code shall be done only towards people known by their 
> name.
>
>> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
>> ---
>>  arch/arm/mach-pxa/z2.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
>> index ce90fa9..fac7cba 100644
>> --- a/arch/arm/mach-pxa/z2.c
>> +++ b/arch/arm/mach-pxa/z2.c
>> @@ -437,7 +437,7 @@ static struct gpio_keys_button z2_pxa_buttons[] 
>> = {
>>  	{
>>  		.code		= KEY_POWER,
>>  		.gpio		= GPIO1_ZIPITZ2_POWER_BUTTON,
>> -		.active_low	= 0,
>> +		.active_low	= 1,
>>  		.desc		= "Power Button",
>>  		.wakeup		= 1,
>>  		.type		= EV_KEY,
>
> [1] http://lwn.net/Articles/195643/
>
> Best regards,
> Marek Vasut
diff mbox

Patch

diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
index ce90fa9..fac7cba 100644
--- a/arch/arm/mach-pxa/z2.c
+++ b/arch/arm/mach-pxa/z2.c
@@ -437,7 +437,7 @@  static struct gpio_keys_button z2_pxa_buttons[] = {
 	{
 		.code		= KEY_POWER,
 		.gpio		= GPIO1_ZIPITZ2_POWER_BUTTON,
-		.active_low	= 0,
+		.active_low	= 1,
 		.desc		= "Power Button",
 		.wakeup		= 1,
 		.type		= EV_KEY,