diff mbox

[14/15] ARM: OMAP2+: omap2plus_defconfig: Enable Mailbox

Message ID 50950C09.6000108@deeprootsystems.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kevin Hilman Nov. 3, 2012, 12:20 p.m. UTC 
On 11/02/2012 01:32 PM, Vaibhav Bedia wrote:
> AM33XX PM code depends on Mailbox module for IPC
> between MPU and WKUP_M3.

OK, but what if I try to build for AM33xx without starting from 
omap2plus_defconfig?

IOW, instead of changing the default defconfig, AM33xx should select 
this when PM
is enabled.   Something like the (untested) change below.

Kevin

Comments

Vaibhav Bedia Nov. 3, 2012, 1:17 p.m. UTC | #1 
On Sat, Nov 03, 2012 at 17:50:25, Kevin Hilman wrote:
> On 11/02/2012 01:32 PM, Vaibhav Bedia wrote:
> > AM33XX PM code depends on Mailbox module for IPC
> > between MPU and WKUP_M3.
> 
> OK, but what if I try to build for AM33xx without starting from 
> omap2plus_defconfig?

I honestly didn't think about this scenario.

> 
> IOW, instead of changing the default defconfig, AM33xx should select 
> this when PM
> is enabled.   Something like the (untested) change below.
> 

Will try it out. Thanks for the suggestion.

Regards,
Vaibhav
Kevin Hilman Nov. 3, 2012, 1:43 p.m. UTC | #2 
On 11/03/2012 01:17 PM, Bedia, Vaibhav wrote:
> On Sat, Nov 03, 2012 at 17:50:25, Kevin Hilman wrote:
>> On 11/02/2012 01:32 PM, Vaibhav Bedia wrote:
>>> AM33XX PM code depends on Mailbox module for IPC
>>> between MPU and WKUP_M3.
>>
>> OK, but what if I try to build for AM33xx without starting from
>> omap2plus_defconfig?
>
> I honestly didn't think about this scenario.
>
>>
>> IOW, instead of changing the default defconfig, AM33xx should select
>> this when PM
>> is enabled.   Something like the (untested) change below.
>>
>
> Will try it out. Thanks for the suggestion.

You're welcome.

See... sometimes maintainers can be useful for something other than 
complaining.  ;)

Kevin
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index d669e22..93c1a37 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -109,6 +109,7 @@  config SOC_AM33XX
  	bool "AM33XX support"
  	default y
  	select ARM_CPU_SUSPEND if PM
+        select OMAP_MBOX_FWK if PM
  	select CPU_V7
  	select MULTI_IRQ_HANDLER