| Message ID | 20121105093451.GA20063@game.jcrosoft.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Subject: usb: at91_udc: fix typo on vubs pullup valid check
^^^^
typo.
On Mon, Nov 05, 2012 at 10:34:52AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> if the gpio is not valid complain
>
> since 3285e0ec088febc5a88f57ddd78385a7da71476c
> ARM: at91/udc: use gpio_is_valid to check the gpio
Poor description.
"The check for a valid vbus pullup gpio in commit 3285e0ec088f (ARM: at91/udc:
use gpio_is_valid to check the gpio) is inverted. Fix this."
would be much better because it describes what the the actual problem is.
Your description could mean that it's missing the error return path, or
maybe you're adding a log message to the failure case, or...
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index 89d90b5..888cb2a 100644 --- a/drivers/usb/gadget/at91_udc.c +++ b/drivers/usb/gadget/at91_udc.c @@ -1739,7 +1739,7 @@ static int __devinit at91udc_probe(struct platform_device *pdev) /* rm9200 needs manual D+ pullup; off by default */ if (cpu_is_at91rm9200()) { - if (gpio_is_valid(udc->board.pullup_pin)) { + if (!gpio_is_valid(udc->board.pullup_pin)) { DBG("no D+ pullup?\n"); retval = -ENODEV; goto fail0;
if the gpio is not valid complain since 3285e0ec088febc5a88f57ddd78385a7da71476c ARM: at91/udc: use gpio_is_valid to check the gpio Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Cc: linux-usb@vger.kernel.org Cc: stable@vger.kernel.org Cc: Felipe Balbi <balbi@ti.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Nicolas Ferre <nicolas.ferre@atmel.com> --- v2: update commit and put Felipe in Cc Hi Greg, this is broken since 3.2 can we have on the stable too Best Regards, J. drivers/usb/gadget/at91_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)