Message ID | 201211081408.41983.arnd@arndb.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thu, Nov 08, 2012 at 02:08:41PM +0000, Arnd Bergmann wrote: > The newly introduced l2_wt_override should be in the same #ifdef > as the code using it, otherwise we get: > > arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not used This should already be fixed. I think your patch pre-dates 7547/4.
On Thursday 08 November 2012, Russell King - ARM Linux wrote: > On Thu, Nov 08, 2012 at 02:08:41PM +0000, Arnd Bergmann wrote: > > The newly introduced l2_wt_override should be in the same #ifdef > > as the code using it, otherwise we get: > > > > arch/arm/mm/cache-l2x0.c:37:12: warning: 'l2_wt_override' defined but not used > > This should already be fixed. I think your patch pre-dates 7547/4. Yes, that's right. I was looking at yesterday's linux-next. It's fixed today. Thanks, Arnd
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c index 92ee4a0..6911b8b 100644 --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c @@ -34,7 +34,6 @@ static DEFINE_RAW_SPINLOCK(l2x0_lock); static u32 l2x0_way_mask; /* Bitmask of active ways */ static u32 l2x0_size; static unsigned long sync_reg_offset = L2X0_CACHE_SYNC; -static int l2_wt_override; /* Aurora don't have the cache ID register available, so we have to * pass it though the device tree */ @@ -424,6 +423,8 @@ void __init l2x0_init(void __iomem *base, u32 aux_val, u32 aux_mask) } #ifdef CONFIG_OF +static int l2_wt_override; + /* * Note that the end addresses passed to Linux primitives are * noninclusive, while the hardware cache range operations use