Message ID | 1352985288-29518-2-git-send-email-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thu, 15 Nov 2012, Lee Jones wrote: > GPIO numbers for the newly created gpio-regulator will differ from > board to board. Therefore it's not sensible to leave this information > in the top level DTSI file. Let's move them out to the DTS files > where they can correctly vary. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > arch/arm/boot/dts/dbx5x0.dtsi | 2 -- > arch/arm/boot/dts/hrefprev60.dts | 7 +++++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi > index d8ba489..9f55363 100644 > --- a/arch/arm/boot/dts/dbx5x0.dtsi > +++ b/arch/arm/boot/dts/dbx5x0.dtsi > @@ -638,8 +638,6 @@ > regulator-name = "mmci-reg"; > regulator-type = "voltage"; > > - gpios = <&tc3589x_gpio 18 0x4>; > - gpio-enable = <&tc3589x_gpio 17 0x4>; > states = <1800000 0x1 > 2900000 0x0>; > > diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts > index b398946..eec29c4 100644 > --- a/arch/arm/boot/dts/hrefprev60.dts > +++ b/arch/arm/boot/dts/hrefprev60.dts > @@ -37,5 +37,12 @@ > reset-gpio = <&tc3589x_gpio 13 0x4>; > }; > }; > + > + vmmci: regulator-gpio { > + gpios = <&tc3589x_gpio 18 0x4>; > + gpio-enable = <&tc3589x_gpio 17 0x4>; > + > + status = "okay"; > + }; > }; > }; > -- > 1.7.9.5 Prod for Linus.
On Thu, Nov 15, 2012 at 2:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > GPIO numbers for the newly created gpio-regulator will differ from > board to board. Therefore it's not sensible to leave this information > in the top level DTSI file. Let's move them out to the DTS files > where they can correctly vary. > > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi index d8ba489..9f55363 100644 --- a/arch/arm/boot/dts/dbx5x0.dtsi +++ b/arch/arm/boot/dts/dbx5x0.dtsi @@ -638,8 +638,6 @@ regulator-name = "mmci-reg"; regulator-type = "voltage"; - gpios = <&tc3589x_gpio 18 0x4>; - gpio-enable = <&tc3589x_gpio 17 0x4>; states = <1800000 0x1 2900000 0x0>; diff --git a/arch/arm/boot/dts/hrefprev60.dts b/arch/arm/boot/dts/hrefprev60.dts index b398946..eec29c4 100644 --- a/arch/arm/boot/dts/hrefprev60.dts +++ b/arch/arm/boot/dts/hrefprev60.dts @@ -37,5 +37,12 @@ reset-gpio = <&tc3589x_gpio 13 0x4>; }; }; + + vmmci: regulator-gpio { + gpios = <&tc3589x_gpio 18 0x4>; + gpio-enable = <&tc3589x_gpio 17 0x4>; + + status = "okay"; + }; }; };
GPIO numbers for the newly created gpio-regulator will differ from board to board. Therefore it's not sensible to leave this information in the top level DTSI file. Let's move them out to the DTS files where they can correctly vary. Signed-off-by: Lee Jones <lee.jones@linaro.org> --- arch/arm/boot/dts/dbx5x0.dtsi | 2 -- arch/arm/boot/dts/hrefprev60.dts | 7 +++++++ 2 files changed, 7 insertions(+), 2 deletions(-)