| Message ID | 1352916505-12343-4-git-send-email-anilkumar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/14/2012 07:08 PM, AnilKumar Ch wrote: > Add a new address space/memory resource to d_can device tree node. D_CAN > RAM initialization is achieved through RAMINIT register which is part of > AM33XX control module address space. D_CAN RAM init or de-init should be > done by writing instance corresponding value to control module register. > > Till we have a separate control module driver to write to control module, > d_can driver will handle the register writes to control module by itself. > So a new address space to represent this control module register is added > to d_can driver. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> This does not apply to net-next/master: Applying: ARM: dts: AM33XX: Add memory resource to d_can node error: patch failed: arch/arm/boot/dts/am33xx.dtsi:227 error: arch/arm/boot/dts/am33xx.dtsi: patch does not apply Patch failed at 0003 ARM: dts: AM33XX: Add memory resource to d_can node Marc
On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote: > On 11/14/2012 07:08 PM, AnilKumar Ch wrote: > > Add a new address space/memory resource to d_can device tree node. D_CAN > > RAM initialization is achieved through RAMINIT register which is part of > > AM33XX control module address space. D_CAN RAM init or de-init should be > > done by writing instance corresponding value to control module register. > > > > Till we have a separate control module driver to write to control module, > > d_can driver will handle the register writes to control module by itself. > > So a new address space to represent this control module register is added > > to d_can driver. > > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > > This does not apply to net-next/master: > > Applying: ARM: dts: AM33XX: Add memory resource to d_can node > error: patch failed: arch/arm/boot/dts/am33xx.dtsi:227 > error: arch/arm/boot/dts/am33xx.dtsi: patch does not apply > Patch failed at 0003 ARM: dts: AM33XX: Add memory resource to d_can node > Marc, Sorry about this DT changes are present in linux-omap. Could you please take the driver changes only and ACK on remaining will help. Tony/Benoit, Could you please take dt patches in this series to linux-omap? Thanks AnilKumar
On 11/20/2012 11:23 AM, AnilKumar, Chimata wrote: > On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote: >> On 11/14/2012 07:08 PM, AnilKumar Ch wrote: >>> Add a new address space/memory resource to d_can device tree node. D_CAN >>> RAM initialization is achieved through RAMINIT register which is part of >>> AM33XX control module address space. D_CAN RAM init or de-init should be >>> done by writing instance corresponding value to control module register. >>> >>> Till we have a separate control module driver to write to control module, >>> d_can driver will handle the register writes to control module by itself. >>> So a new address space to represent this control module register is added >>> to d_can driver. >>> >>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com> >> >> This does not apply to net-next/master: >> >> Applying: ARM: dts: AM33XX: Add memory resource to d_can node >> error: patch failed: arch/arm/boot/dts/am33xx.dtsi:227 >> error: arch/arm/boot/dts/am33xx.dtsi: patch does not apply >> Patch failed at 0003 ARM: dts: AM33XX: Add memory resource to d_can node >> > > Marc, > > Sorry about this DT changes are present in linux-omap. > > Could you please take the driver changes only and ACK on remaining will > help. Will do - I'm currently looking at the driver. Marc
On Tue, Nov 20, 2012 at 15:56:32, Marc Kleine-Budde wrote: > On 11/20/2012 11:23 AM, AnilKumar, Chimata wrote: > > On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote: > >> On 11/14/2012 07:08 PM, AnilKumar Ch wrote: > >>> Add a new address space/memory resource to d_can device tree node. D_CAN > >>> RAM initialization is achieved through RAMINIT register which is part of > >>> AM33XX control module address space. D_CAN RAM init or de-init should be > >>> done by writing instance corresponding value to control module register. > >>> > >>> Till we have a separate control module driver to write to control module, > >>> d_can driver will handle the register writes to control module by itself. > >>> So a new address space to represent this control module register is added > >>> to d_can driver. > >>> > >>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > >> > >> This does not apply to net-next/master: > >> > >> Applying: ARM: dts: AM33XX: Add memory resource to d_can node > >> error: patch failed: arch/arm/boot/dts/am33xx.dtsi:227 > >> error: arch/arm/boot/dts/am33xx.dtsi: patch does not apply > >> Patch failed at 0003 ARM: dts: AM33XX: Add memory resource to d_can node > >> > > > > Marc, > > > > Sorry about this DT changes are present in linux-omap. > > > > Could you please take the driver changes only and ACK on remaining will > > help. > > Will do - I'm currently looking at the driver. > Hi Marc, Please ACK this patch as well. Thanks AnilKumar
On 11/14/2012 07:08 PM, AnilKumar Ch wrote: > Add a new address space/memory resource to d_can device tree node. D_CAN > RAM initialization is achieved through RAMINIT register which is part of > AM33XX control module address space. D_CAN RAM init or de-init should be > done by writing instance corresponding value to control module register. > > Till we have a separate control module driver to write to control module, > d_can driver will handle the register writes to control module by itself. > So a new address space to represent this control module register is added > to d_can driver. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
On 11/21/2012 06:45 AM, AnilKumar, Chimata wrote: > On Tue, Nov 20, 2012 at 15:56:32, Marc Kleine-Budde wrote: >> On 11/20/2012 11:23 AM, AnilKumar, Chimata wrote: >>> On Tue, Nov 20, 2012 at 15:43:04, Marc Kleine-Budde wrote: >>>> On 11/14/2012 07:08 PM, AnilKumar Ch wrote: >>>>> Add a new address space/memory resource to d_can device tree node. D_CAN >>>>> RAM initialization is achieved through RAMINIT register which is part of >>>>> AM33XX control module address space. D_CAN RAM init or de-init should be >>>>> done by writing instance corresponding value to control module register. >>>>> >>>>> Till we have a separate control module driver to write to control module, >>>>> d_can driver will handle the register writes to control module by itself. >>>>> So a new address space to represent this control module register is added >>>>> to d_can driver. >>>>> >>>>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com> >>>> >>>> This does not apply to net-next/master: >>>> >>>> Applying: ARM: dts: AM33XX: Add memory resource to d_can node >>>> error: patch failed: arch/arm/boot/dts/am33xx.dtsi:227 >>>> error: arch/arm/boot/dts/am33xx.dtsi: patch does not apply >>>> Patch failed at 0003 ARM: dts: AM33XX: Add memory resource to d_can node >>>> >>> >>> Marc, >>> >>> Sorry about this DT changes are present in linux-omap. >>> >>> Could you please take the driver changes only and ACK on remaining will >>> help. >> >> Will do - I'm currently looking at the driver. >> > > Hi Marc, > > Please ACK this patch as well. done :) Marc
On Wed, Nov 21, 2012 at 13:50:26, Marc Kleine-Budde wrote: > On 11/14/2012 07:08 PM, AnilKumar Ch wrote: > > Add a new address space/memory resource to d_can device tree node. D_CAN > > RAM initialization is achieved through RAMINIT register which is part of > > AM33XX control module address space. D_CAN RAM init or de-init should be > > done by writing instance corresponding value to control module register. > > > > Till we have a separate control module driver to write to control module, > > d_can driver will handle the register writes to control module by itself. > > So a new address space to represent this control module register is added > > to d_can driver. > > > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > Hi Tony/Benoit, Could you please pull this in? Thanks AnilKumar
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index c92c35f..ea011d6 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -227,7 +227,8 @@ dcan0: d_can@481cc000 { compatible = "bosch,d_can"; ti,hwmods = "d_can0"; - reg = <0x481cc000 0x2000>; + reg = <0x481cc000 0x2000 + 0x44e10644 0x4>; interrupts = <52>; status = "disabled"; }; @@ -235,7 +236,8 @@ dcan1: d_can@481d0000 { compatible = "bosch,d_can"; ti,hwmods = "d_can1"; - reg = <0x481d0000 0x2000>; + reg = <0x481d0000 0x2000 + 0x44e10644 0x4>; interrupts = <55>; status = "disabled"; };
Add a new address space/memory resource to d_can device tree node. D_CAN RAM initialization is achieved through RAMINIT register which is part of AM33XX control module address space. D_CAN RAM init or de-init should be done by writing instance corresponding value to control module register. Till we have a separate control module driver to write to control module, d_can driver will handle the register writes to control module by itself. So a new address space to represent this control module register is added to d_can driver. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/boot/dts/am33xx.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)