diff mbox

[v3,2/4] mmc: dw-mmc: remove the duplicated code

Message ID 509B6ED3.2000003@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jaehoon Chung Nov. 8, 2012, 8:35 a.m. UTC 
ctype is used 1-bit buswidth mode by default.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/mmc/host/dw_mmc.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

Comments

Seungwon Jeon Nov. 27, 2012, 8:01 a.m. UTC | #1 
This is minor change.

Acked-by: Seungwon Jeon <tgih.jun@samsung.com>

Thanks,
Seungwon Jeon

On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> ctype is used 1-bit buswidth mode by default.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc.c |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a1369aa..0a80b5c 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  	struct dw_mci_drv_data *drv_data = slot->host->drv_data;
>  	u32 regs;
> 
> -	/* set default 1 bit mode */
> -	slot->ctype = SDMMC_CTYPE_1BIT;
> -
>  	switch (ios->bus_width) {
> -	case MMC_BUS_WIDTH_1:
> -		slot->ctype = SDMMC_CTYPE_1BIT;
> -		break;
>  	case MMC_BUS_WIDTH_4:
>  		slot->ctype = SDMMC_CTYPE_4BIT;
>  		break;
>  	case MMC_BUS_WIDTH_8:
>  		slot->ctype = SDMMC_CTYPE_8BIT;
>  		break;
> +	default:
> +		/* set default 1 bit mode */
> +		slot->ctype = SDMMC_CTYPE_1BIT;
>  	}
> 
>  	regs = mci_readl(slot->host, UHS_REG);
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
James Hogan Nov. 27, 2012, 9:41 a.m. UTC | #2 
On 27/11/12 08:01, Seungwon Jeon wrote:
> This is minor change.
> 
> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
> 
> Thanks,
> Seungwon Jeon

Looks good to me too.
Acked-by: James Hogan <james.hogan@imgtec.com>

> 
> On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> ctype is used 1-bit buswidth mode by default.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/mmc/host/dw_mmc.c |    9 +++------
>>  1 files changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index a1369aa..0a80b5c 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>  	struct dw_mci_drv_data *drv_data = slot->host->drv_data;
>>  	u32 regs;
>>
>> -	/* set default 1 bit mode */
>> -	slot->ctype = SDMMC_CTYPE_1BIT;
>> -
>>  	switch (ios->bus_width) {
>> -	case MMC_BUS_WIDTH_1:
>> -		slot->ctype = SDMMC_CTYPE_1BIT;
>> -		break;
>>  	case MMC_BUS_WIDTH_4:
>>  		slot->ctype = SDMMC_CTYPE_4BIT;
>>  		break;
>>  	case MMC_BUS_WIDTH_8:
>>  		slot->ctype = SDMMC_CTYPE_8BIT;
>>  		break;
>> +	default:
>> +		/* set default 1 bit mode */
>> +		slot->ctype = SDMMC_CTYPE_1BIT;
>>  	}
>>
>>  	regs = mci_readl(slot->host, UHS_REG);
>> --
>> 1.7.4.1
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jaehoon Chung Nov. 29, 2012, 3:03 p.m. UTC | #3 
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

2012/11/27 James Hogan <james.hogan@imgtec.com>:
> On 27/11/12 08:01, Seungwon Jeon wrote:
>> This is minor change.
>>
>> Acked-by: Seungwon Jeon <tgih.jun@samsung.com>
>>
>> Thanks,
>> Seungwon Jeon
>
> Looks good to me too.
> Acked-by: James Hogan <james.hogan@imgtec.com>
>
>>
>> On Thursday, November 08, 2012, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> ctype is used 1-bit buswidth mode by default.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>>> ---
>>>  drivers/mmc/host/dw_mmc.c |    9 +++------
>>>  1 files changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>>> index a1369aa..0a80b5c 100644
>>> --- a/drivers/mmc/host/dw_mmc.c
>>> +++ b/drivers/mmc/host/dw_mmc.c
>>> @@ -773,19 +773,16 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>>>      struct dw_mci_drv_data *drv_data = slot->host->drv_data;
>>>      u32 regs;
>>>
>>> -    /* set default 1 bit mode */
>>> -    slot->ctype = SDMMC_CTYPE_1BIT;
>>> -
>>>      switch (ios->bus_width) {
>>> -    case MMC_BUS_WIDTH_1:
>>> -            slot->ctype = SDMMC_CTYPE_1BIT;
>>> -            break;
>>>      case MMC_BUS_WIDTH_4:
>>>              slot->ctype = SDMMC_CTYPE_4BIT;
>>>              break;
>>>      case MMC_BUS_WIDTH_8:
>>>              slot->ctype = SDMMC_CTYPE_8BIT;
>>>              break;
>>> +    default:
>>> +            /* set default 1 bit mode */
>>> +            slot->ctype = SDMMC_CTYPE_1BIT;
>>>      }
>>>
>>>      regs = mci_readl(slot->host, UHS_REG);
>>> --
>>> 1.7.4.1
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chris Ball Dec. 3, 2012, 7:46 p.m. UTC | #4 
Hi,

On Thu, Nov 08 2012, Jaehoon Chung wrote:
> ctype is used 1-bit buswidth mode by default.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Thanks, pushed to mmc-next for 3.8.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index a1369aa..0a80b5c 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -773,19 +773,16 @@  static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	struct dw_mci_drv_data *drv_data = slot->host->drv_data;
 	u32 regs;
 
-	/* set default 1 bit mode */
-	slot->ctype = SDMMC_CTYPE_1BIT;
-
 	switch (ios->bus_width) {
-	case MMC_BUS_WIDTH_1:
-		slot->ctype = SDMMC_CTYPE_1BIT;
-		break;
 	case MMC_BUS_WIDTH_4:
 		slot->ctype = SDMMC_CTYPE_4BIT;
 		break;
 	case MMC_BUS_WIDTH_8:
 		slot->ctype = SDMMC_CTYPE_8BIT;
 		break;
+	default:
+		/* set default 1 bit mode */
+		slot->ctype = SDMMC_CTYPE_1BIT;
 	}
 
 	regs = mci_readl(slot->host, UHS_REG);