diff mbox

drm: Add EDID_QUIRK_FORCE_REDUCED_BLANKING for ASUS VW222S

Message ID 1345045240.4264.21.camel@mattotaupa (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Menzel Aug. 15, 2012, 3:40 p.m. UTC
Date: Wed, 8 Aug 2012 23:12:19 +0200

Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with
vertical stripes in the top half.

In commit bc42aabc [2]

        commit bc42aabc6a01b92b0f961d65671564e0e1cd7592
        Author: Adam Jackson <ajax@redhat.com>
        Date:   Wed May 23 16:26:54 2012 -0400

            drm/edid/quirks: ViewSonic VA2026w

Adam Jackson added the quirk `EDID_QUIRK_FORCE_REDUCED_BLANKING` which
is also needed for this ASUS monitor.

All log files and output from `xrandr` is included in the referenced
Bugzilla report #17629.

[1] http://www.asus.com/Display/LCD_Monitors/VW222S/
[2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=bc42aabc6a01b92b0f961d65671564e0e1cd7592

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=17629
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: <dri-devel@lists.freedesktop.org>
Cc: Adam Jackson <ajax@redhat.com>
Cc: Ian Pilcher <arequipeno@gmail.com>
Cc: <stable@vger.kernel.org>
---
Same comment as in previous patch.

Ian, I did not base this patch on your series, to make it easier to get
back ported. I can easily rebase it though, so hopefully some maintainer
can tell me what to do.
---
 drivers/gpu/drm/drm_edid.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

Florian Mickler Dec. 18, 2012, 8:03 p.m. UTC | #1
Hi all!

On Wed, 15 Aug 2012 17:40:40 +0200
Paul Menzel <paulepanter@users.sourceforge.net> wrote:

> Date: Wed, 8 Aug 2012 23:12:19 +0200
> 
> Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with
> vertical stripes in the top half.
> 

This patch, which was merged in v3.6-rc4, makes the image on my ASUS
VW222U ca. 1 inch too wide left/right and top/bottom.  The effect is as
if the image was zoomed (bigger, more pixely).

Reverting it fixes the problem. 

The Monitor is connected via VGA, but also has a DVI interface.

Maybe the quirk-apply criteria is too unspecific? 

Regards,
Flo

> ---
>  drivers/gpu/drm/drm_edid.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 75e252e..102346d 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -87,6 +87,9 @@ static struct edid_quirk {
>  	int product_id;
>  	u32 quirks;
>  } edid_quirk_list[] = {
> +	/* ASUS VW222S */
> +	{ "ACI", 22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING },
> +
>  	/* Acer AL1706 */
>  	{ "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 },
>  	/* Acer F51 */
Paul Menzel Dec. 18, 2012, 10:33 p.m. UTC | #2
Dear Florian,


Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:

> On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
> 
> > Date: Wed, 8 Aug 2012 23:12:19 +0200
> > 
> > Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with
> > vertical stripes in the top half.
> 
> This patch, which was merged in v3.6-rc4, makes the image on my ASUS
> VW222U ca. 1 inch too wide left/right and top/bottom.  The effect is as
> if the image was zoomed (bigger, more pixely).
> 
> Reverting it fixes the problem.

I am sorry for the trouble caused by this. As a work around, you could
also specify the QUIRKS on the Linux command line.

> The Monitor is connected via VGA, but also has a DVI interface.
> 
> Maybe the quirk-apply criteria is too unspecific?

Hmm, I guess everything is identical but the DVI connector they added to
the VW222U. Though I should have noticed the effect on the VW222S and
did not. :(

Could you please send the `edid-decode` output on your system and
`/var/log/Xorg.0.log`.

Also I wonder how this quirk could create such a behavior.


Thanks,

Paul


[1] http://cgit.freedesktop.org/xorg/app/edid-decode/
Ian Pilcher Dec. 19, 2012, 9:18 p.m. UTC | #3
On 12/18/2012 04:33 PM, Paul Menzel wrote:
> I am sorry for the trouble caused by this. As a work around, you could
> also specify the QUIRKS on the Linux command line.

Those patches never made it in.  I gave up when I was asked to rewrite
everything without using unions.
Florian Mickler Dec. 21, 2012, 1:52 p.m. UTC | #4
On Tue, 18 Dec 2012 23:33:20 +0100
Paul Menzel <paulepanter@users.sourceforge.net> wrote:

> Dear Florian,
> 
> 
> Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
> 
> > On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
> > 
> > > Date: Wed, 8 Aug 2012 23:12:19 +0200
> > > 
> > > Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with
> > > vertical stripes in the top half.
> > 
> > This patch, which was merged in v3.6-rc4, makes the image on my ASUS
> > VW222U ca. 1 inch too wide left/right and top/bottom.  The effect is as
> > if the image was zoomed (bigger, more pixely).
> > 
> > Reverting it fixes the problem.
> 
> I am sorry for the trouble caused by this. As a work around, you could
> also specify the QUIRKS on the Linux command line.
> 
> > The Monitor is connected via VGA, but also has a DVI interface.
> > 
> > Maybe the quirk-apply criteria is too unspecific?
> 
> Hmm, I guess everything is identical but the DVI connector they added to
> the VW222U. Though I should have noticed the effect on the VW222S and
> did not. :(

Hm.. why should you have noticed the effect on the VW222S? Does it
happen there too?

> 
> Could you please send the `edid-decode` output on your system and
> `/var/log/Xorg.0.log`.
> 

I attached the xrandr --verbose output and the 
# get-edid  | parse-edid
output from http://www.polypux.org/projects/read-edid/ which I already
had installed. Hope this works for you too.



> Also I wonder how this quirk could create such a behavior.


Yes. I'm not shure how this could happen. It probably is either a bug
somewhere, or it is the 'natural' effect of misconfiguring the vga
pipeline.  Maybe someone more knowledgeable than me could make a more
educated guess about this.


> 
> [1] http://cgit.freedesktop.org/xorg/app/edid-decode/
Screen 0: minimum 320 x 200, current 3080 x 1050, maximum 8192 x 8192
LVDS1 connected 1400x1050+1680+0 (0x44) normal (normal left inverted right x axis y axis) 304mm x 228mm
	Identifier: 0x41
	Timestamp:  20362
	Subpixel:   horizontal rgb
	Gamma:      1.0:1.0:1.0
	Brightness: 1.0
	Clones:    
	CRTC:       1
	CRTCs:      1
	Transform:  1.000000 0.000000 0.000000
	            0.000000 1.000000 0.000000
	            0.000000 0.000000 1.000000
	           filter: 
	EDID:
		00ffffffffffff0030ae424000000000
		000f0103801e1778ea3c809757518a27
		22505421080081800101010101010101
		010101010101302a7820511a10403070
		130030e41000001825237820511a1040
		3070130030e4100000180000000f0090
		4332904328140100320c5321000000fe
		004c503135304530372d544c303300ca
	BACKLIGHT: 15 (0x0000000f)	range:  (0,15)
	Backlight: 15 (0x0000000f)	range:  (0,15)
	scaling mode:	Full aspect
		supported: None         Full         Center       Full aspect 
  1400x1050 (0x44)  108.0MHz -HSync -VSync *current +preferred
        h: width  1400 start 1448 end 1560 total 1688 skew    0 clock   64.0KHz
        v: height 1050 start 1051 end 1054 total 1066           clock   60.0Hz
  1400x1050 (0x45)  122.0MHz +HSync +VSync
        h: width  1400 start 1488 end 1640 total 1880 skew    0 clock   64.9KHz
        v: height 1050 start 1052 end 1064 total 1082           clock   60.0Hz
  1400x1050 (0x46)   90.0MHz -HSync -VSync
        h: width  1400 start 1448 end 1560 total 1688 skew    0 clock   53.3KHz
        v: height 1050 start 1051 end 1054 total 1066           clock   50.0Hz
  1280x1024 (0x47)  108.0MHz +HSync +VSync
        h: width  1280 start 1328 end 1440 total 1688 skew    0 clock   64.0KHz
        v: height 1024 start 1025 end 1028 total 1066           clock   60.0Hz
  1280x960 (0x48)  108.0MHz +HSync +VSync
        h: width  1280 start 1376 end 1488 total 1800 skew    0 clock   60.0KHz
        v: height  960 start  961 end  964 total 1000           clock   60.0Hz
  1024x768 (0x49)   65.0MHz -HSync -VSync
        h: width  1024 start 1048 end 1184 total 1344 skew    0 clock   48.4KHz
        v: height  768 start  771 end  777 total  806           clock   60.0Hz
  800x600 (0x4a)   40.0MHz +HSync +VSync
        h: width   800 start  840 end  968 total 1056 skew    0 clock   37.9KHz
        v: height  600 start  601 end  605 total  628           clock   60.3Hz
  800x600 (0x4b)   36.0MHz +HSync +VSync
        h: width   800 start  824 end  896 total 1024 skew    0 clock   35.2KHz
        v: height  600 start  601 end  603 total  625           clock   56.2Hz
  640x480 (0x4c)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  490 end  492 total  525           clock   60.0Hz
  640x480 (0x4d)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  490 end  492 total  525           clock   59.9Hz
VGA1 connected 1680x1050+0+0 (0x4e) normal (normal left inverted right x axis y axis) 473mm x 296mm
	Identifier: 0x42
	Timestamp:  20362
	Subpixel:   unknown
	Gamma:      1.0:1.0:1.0
	Brightness: 1.0
	Clones:    
	CRTC:       0
	CRTCs:      0 1
	Transform:  1.000000 0.000000 0.000000
	            0.000000 1.000000 0.000000
	            0.000000 0.000000 1.000000
	           filter: 
	EDID:
		00ffffffffffff000469a222a6180000
		2e1101031e2f1e78eec4f6a3574a9c23
		114f54bfef00714f818081409500a940
		b3000101010121399030621a274068b0
		3600d9281100001c000000fd00384b1f
		5111000a202020202020000000fc0056
		573232320a20202020202020000000ff
		0037424c4d51433030363331302000d1
  1680x1050 (0x4e)  146.2MHz -HSync +VSync *current +preferred
        h: width  1680 start 1784 end 1960 total 2240 skew    0 clock   65.3KHz
        v: height 1050 start 1053 end 1059 total 1089           clock   60.0Hz
  1600x1200 (0xc7)  162.0MHz +HSync +VSync
        h: width  1600 start 1664 end 1856 total 2160 skew    0 clock   75.0KHz
        v: height 1200 start 1201 end 1204 total 1250           clock   60.0Hz
  1280x1024 (0x4f)  135.0MHz +HSync +VSync
        h: width  1280 start 1296 end 1440 total 1688 skew    0 clock   80.0KHz
        v: height 1024 start 1025 end 1028 total 1066           clock   75.0Hz
  1280x1024 (0x47)  108.0MHz +HSync +VSync
        h: width  1280 start 1328 end 1440 total 1688 skew    0 clock   64.0KHz
        v: height 1024 start 1025 end 1028 total 1066           clock   60.0Hz
  1440x900 (0x50)  106.5MHz -HSync +VSync
        h: width  1440 start 1520 end 1672 total 1904 skew    0 clock   55.9KHz
        v: height  900 start  903 end  909 total  934           clock   59.9Hz
  1280x960 (0x48)  108.0MHz +HSync +VSync
        h: width  1280 start 1376 end 1488 total 1800 skew    0 clock   60.0KHz
        v: height  960 start  961 end  964 total 1000           clock   60.0Hz
  1152x864 (0x51)  108.0MHz +HSync +VSync
        h: width  1152 start 1216 end 1344 total 1600 skew    0 clock   67.5KHz
        v: height  864 start  865 end  868 total  900           clock   75.0Hz
  1024x768 (0x52)   78.8MHz +HSync +VSync
        h: width  1024 start 1040 end 1136 total 1312 skew    0 clock   60.1KHz
        v: height  768 start  769 end  772 total  800           clock   75.1Hz
  1024x768 (0x53)   75.0MHz -HSync -VSync
        h: width  1024 start 1048 end 1184 total 1328 skew    0 clock   56.5KHz
        v: height  768 start  771 end  777 total  806           clock   70.1Hz
  1024x768 (0x49)   65.0MHz -HSync -VSync
        h: width  1024 start 1048 end 1184 total 1344 skew    0 clock   48.4KHz
        v: height  768 start  771 end  777 total  806           clock   60.0Hz
  832x624 (0x54)   57.3MHz -HSync -VSync
        h: width   832 start  864 end  928 total 1152 skew    0 clock   49.7KHz
        v: height  624 start  625 end  628 total  667           clock   74.6Hz
  800x600 (0x55)   50.0MHz +HSync +VSync
        h: width   800 start  856 end  976 total 1040 skew    0 clock   48.1KHz
        v: height  600 start  637 end  643 total  666           clock   72.2Hz
  800x600 (0x56)   49.5MHz +HSync +VSync
        h: width   800 start  816 end  896 total 1056 skew    0 clock   46.9KHz
        v: height  600 start  601 end  604 total  625           clock   75.0Hz
  800x600 (0x4a)   40.0MHz +HSync +VSync
        h: width   800 start  840 end  968 total 1056 skew    0 clock   37.9KHz
        v: height  600 start  601 end  605 total  628           clock   60.3Hz
  800x600 (0x4b)   36.0MHz +HSync +VSync
        h: width   800 start  824 end  896 total 1024 skew    0 clock   35.2KHz
        v: height  600 start  601 end  603 total  625           clock   56.2Hz
  640x480 (0x57)   31.5MHz -HSync -VSync
        h: width   640 start  664 end  704 total  832 skew    0 clock   37.9KHz
        v: height  480 start  489 end  491 total  520           clock   72.8Hz
  640x480 (0x58)   31.5MHz -HSync -VSync
        h: width   640 start  656 end  720 total  840 skew    0 clock   37.5KHz
        v: height  480 start  481 end  484 total  500           clock   75.0Hz
  640x480 (0x59)   30.2MHz -HSync -VSync
        h: width   640 start  704 end  768 total  864 skew    0 clock   35.0KHz
        v: height  480 start  483 end  486 total  525           clock   66.7Hz
  640x480 (0x4c)   25.2MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock   31.5KHz
        v: height  480 start  490 end  492 total  525           clock   60.0Hz
  720x400 (0x5a)   28.3MHz -HSync +VSync
        h: width   720 start  738 end  846 total  900 skew    0 clock   31.5KHz
        v: height  400 start  412 end  414 total  449           clock   70.1Hz
TV1 unknown connection (normal left inverted right x axis y axis)
	Identifier: 0x43
	Timestamp:  20362
	Subpixel:   unknown
	Clones:    
	CRTCs:      0 1
	Transform:  1.000000 0.000000 0.000000
	            0.000000 1.000000 0.000000
	            0.000000 0.000000 1.000000
	           filter: 
	bottom margin: 37 (0x00000025)	range:  (0,100)
	right margin: 46 (0x0000002e)	range:  (0,100)
	top margin: 36 (0x00000024)	range:  (0,100)
	left margin: 54 (0x00000036)	range:  (0,100)
	mode:	NTSC-M
		supported: NTSC-M       NTSC-443     NTSC-J       PAL-M       
		           PAL-N        PAL          720p@60Hz    720p@50Hz   
		           1080i@50Hz   1080i@60Hz  
  848x480 (0x5b)   29.0MHz +preferred
        h: width   848 start  849 end  912 total  944 skew    0 clock   30.7KHz
        v: height  480 start  481 end  512 total  513           clock   59.9Hz
  640x480 (0x5c)   22.6MHz +preferred
        h: width   640 start  641 end  704 total  736 skew    0 clock   30.7KHz
        v: height  480 start  481 end  512 total  513           clock   59.9Hz
  1024x768 (0x5d)   53.8MHz
        h: width  1024 start 1025 end 1088 total 1120 skew    0 clock   48.0KHz
        v: height  768 start  769 end  800 total  801           clock   59.9Hz
  800x600 (0x5e)   34.0MHz
        h: width   800 start  801 end  864 total  896 skew    0 clock   37.9KHz
        v: height  600 start  601 end  632 total  633           clock   59.9Hz
# EDID version 1 revision 3
Section "Monitor"
	# Block type: 2:0 3:fd
	# Block type: 2:0 3:fc
	Identifier "VW222"
	VendorName "ACI"
	ModelName "VW222"
	# Block type: 2:0 3:fd
	HorizSync 31-81
	VertRefresh 56-75
	# Max dot clock (video bandwidth) 170 MHz
	# Block type: 2:0 3:fc
	# Block type: 2:0 3:ff
	# DPMS capabilities: Active off:yes  Suspend:yes  Standby:yes

	Mode 	"1680x1050"	# vfreq 59.954Hz, hfreq 65.290kHz
		DotClock	146.250000
		HTimings	1680 1784 1960 2240
		VTimings	1050 1053 1059 1089
		Flags	"+HSync" "-VSync"
	EndMode
	# Block type: 2:0 3:fd
	# Block type: 2:0 3:fc
	# Block type: 2:0 3:ff
EndSection
Paul Menzel Dec. 31, 2012, 4:37 p.m. UTC | #5
Dear Florian,


Am Freitag, den 21.12.2012, 14:52 +0100 schrieb Florian Mickler:
> On Tue, 18 Dec 2012 23:33:20 +0100
> Paul Menzel <paulepanter@users.sourceforge.net> wrote:

> > Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
> > 
> > > On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
> > > 
> > > > Date: Wed, 8 Aug 2012 23:12:19 +0200
> > > > 
> > > > Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with
> > > > vertical stripes in the top half.
> > > 
> > > This patch, which was merged in v3.6-rc4, makes the image on my ASUS
> > > VW222U ca. 1 inch too wide left/right and top/bottom.  The effect is as
> > > if the image was zoomed (bigger, more pixely).
> > > 
> > > Reverting it fixes the problem.
> > 
> > I am sorry for the trouble caused by this. As a work around, you could
> > also specify the QUIRKS on the Linux command line.
> > 
> > > The Monitor is connected via VGA, but also has a DVI interface.
> > > 
> > > Maybe the quirk-apply criteria is too unspecific?
> > 
> > Hmm, I guess everything is identical but the DVI connector they added to
> > the VW222U. Though I should have noticed the effect on the VW222S and
> > did not. :(
> 
> Hm.. why should you have noticed the effect on the VW222S? Does it
> happen there too?

No, it did not happen there with an Intel 915GM chip. Could you please
send the `Xorg.0.log`, so that we see what you use. Maybe also a dmesg
output with `dri.debug=6`.

> > Could you please send the `edid-decode` output on your system and
> > `/var/log/Xorg.0.log`.
> 
> I attached the xrandr --verbose output and the 
> # get-edid  | parse-edid
> output from http://www.polypux.org/projects/read-edid/ which I already
> had installed. Hope this works for you too.
>
> > Also I wonder how this quirk could create such a behavior.
>
> Yes. I'm not shure how this could happen. It probably is either a bug
> somewhere, or it is the 'natural' effect of misconfiguring the vga
> pipeline.  Maybe someone more knowledgeable than me could make a more
> educated guess about this.

What should be done about this? Revert this until the reason for the
regression is figured out or fix the regression? For the second option,
Florian could you please create a new ticket?


Thanks,

Paul


> > [1] http://cgit.freedesktop.org/xorg/app/edid-decode/
Florian Mickler Dec. 31, 2012, 5:22 p.m. UTC | #6
Dear Paul,

do you have a quick pointer to your decoded EDID? Maybe we can tell the
VW222S and the VW222U apart. Then a small hack to the quirk-code should
do the trick.

Else, I'm afraid the right thing to do is to revert the quirk.

I will provide the log files as soon as I'm back with that monitor,
which should be next year... (Means tomorrow or the day after)

Regards,
Flo

On Mon, 31 Dec 2012 17:37:24 +0100
Paul Menzel <paulepanter@users.sourceforge.net> wrote:

> Dear Florian,
> 
> 
> Am Freitag, den 21.12.2012, 14:52 +0100 schrieb Florian Mickler:
> > On Tue, 18 Dec 2012 23:33:20 +0100
> > Paul Menzel <paulepanter@users.sourceforge.net> wrote:
> 
> > > Am Dienstag, den 18.12.2012, 21:03 +0100 schrieb Florian Mickler:
> > > 
> > > > On Wed, 15 Aug 2012 17:40:40 +0200 Paul Menzel wrote:
> > > > 
> > > > > Date: Wed, 8 Aug 2012 23:12:19 +0200
> > > > > 
> > > > > Connecting an ASUS VW222S [1] over VGA a garbled screen is shown with
> > > > > vertical stripes in the top half.
> > > > 
> > > > This patch, which was merged in v3.6-rc4, makes the image on my ASUS
> > > > VW222U ca. 1 inch too wide left/right and top/bottom.  The effect is as
> > > > if the image was zoomed (bigger, more pixely).
> > > > 
> > > > Reverting it fixes the problem.
> > > 
> > > I am sorry for the trouble caused by this. As a work around, you could
> > > also specify the QUIRKS on the Linux command line.
> > > 
> > > > The Monitor is connected via VGA, but also has a DVI interface.
> > > > 
> > > > Maybe the quirk-apply criteria is too unspecific?
> > > 
> > > Hmm, I guess everything is identical but the DVI connector they added to
> > > the VW222U. Though I should have noticed the effect on the VW222S and
> > > did not. :(
> > 
> > Hm.. why should you have noticed the effect on the VW222S? Does it
> > happen there too?
> 
> No, it did not happen there with an Intel 915GM chip. Could you please
> send the `Xorg.0.log`, so that we see what you use. Maybe also a dmesg
> output with `dri.debug=6`.
> 
> > > Could you please send the `edid-decode` output on your system and
> > > `/var/log/Xorg.0.log`.
> > 
> > I attached the xrandr --verbose output and the 
> > # get-edid  | parse-edid
> > output from http://www.polypux.org/projects/read-edid/ which I already
> > had installed. Hope this works for you too.
> >
> > > Also I wonder how this quirk could create such a behavior.
> >
> > Yes. I'm not shure how this could happen. It probably is either a bug
> > somewhere, or it is the 'natural' effect of misconfiguring the vga
> > pipeline.  Maybe someone more knowledgeable than me could make a more
> > educated guess about this.
> 
> What should be done about this? Revert this until the reason for the
> regression is figured out or fix the regression? For the second option,
> Florian could you please create a new ticket?
> 
> 
> Thanks,
> 
> Paul
> 
> 
> > > [1] http://cgit.freedesktop.org/xorg/app/edid-decode/
Paul Menzel Jan. 1, 2013, 3:43 a.m. UTC | #7
Dear Florian,


first, I wish everyone a Happy New Year!


Am Montag, den 31.12.2012, 18:22 +0100 schrieb Florian Mickler:

> do you have a quick pointer to your decoded EDID?

yes, everything is in the bug report the patch was supposed to fix [1].

> Maybe we can tell the VW222S and the VW222U apart. Then a small hack
> to the quirk-code should do the trick.

The EDID luckily is different.

        $ diff -u asus-vw222s.edid asus-vw222u.edid
        --- asus-vw222s.edid	2012-08-15 17:22:32.172213340 +0200
        +++ asus-vw222u.edid	2013-01-01 04:33:45.271951086 +0100
        @@ -1,8 +1,8 @@
        -00ffffffffffff000469a22201010101
        -0c1201031e2f1e78eec4f6a3574a9c23
        +00ffffffffffff000469a222a6180000
        +2e1101031e2f1e78eec4f6a3574a9c23
         114f54bfef00714f818081409500a940
         b3000101010121399030621a274068b0
         3600d9281100001c000000fd00384b1f
         5111000a202020202020000000fc0056
         573232320a20202020202020000000ff
        -0038334c4d51533037393235300a00b3
        +0037424c4d51433030363331302000d1

Here the strings output by `edid-decode`.

### VW222S ###

        $ ./edid-decode asus-vw222s.edid 
        […]
        Manufacturer: ACI Model 22a2 Serial Number 16843009
        Made week 12 of 2008
        EDID version: 1.3
        Analog display, Input voltage level: 0.7/0.3 V
        Configurable signal levels
        Sync: Separate Composite SyncOnGreen 
        Maximum image size: 47 cm x 30 cm
        Gamma: 2.20
        DPMS levels: Standby Suspend Off
        RGB color display
        Default (sRGB) color space is primary color space
        First detailed timing is preferred timing
        Established timings supported:
          720x400@70Hz
          640x480@60Hz
          640x480@67Hz
          640x480@72Hz
          640x480@75Hz
          800x600@56Hz
          800x600@60Hz
          800x600@72Hz
          800x600@75Hz
          832x624@75Hz
          1024x768@60Hz
          1024x768@70Hz
          1024x768@75Hz
          1280x1024@75Hz
        Standard timings supported:
          1152x864@75Hz
          1280x1024@60Hz
          1280x960@60Hz
          1440x900@60Hz
          1600x1200@60Hz
          1680x1050@60Hz
        Detailed mode: Clock 146.250 MHz, 473 mm x 296 mm
                       1680 1784 1960 2240 hborder 0
                       1050 1053 1059 1089 vborder 0
                       -hsync +vsync 
        Monitor ranges (GTF): 56-75Hz V, 31-81kHz H, max dotclock 170MHz
        Monitor name: VW222
        Serial number: 83LMQS079250
        Checksum: 0xb3 (valid)

### VW222U ###

        $ ./edid-decode asus-vw222u.edid
        […]
        Manufacturer: ACI Model 22a2 Serial Number 6310
        Made week 46 of 2007
        EDID version: 1.3
        Analog display, Input voltage level: 0.7/0.3 V
        Configurable signal levels
        Sync: Separate Composite SyncOnGreen 
        Maximum image size: 47 cm x 30 cm
        Gamma: 2.20
        DPMS levels: Standby Suspend Off
        RGB color display
        Default (sRGB) color space is primary color space
        First detailed timing is preferred timing
        Established timings supported:
          720x400@70Hz
          640x480@60Hz
          640x480@67Hz
          640x480@72Hz
          640x480@75Hz
          800x600@56Hz
          800x600@60Hz
          800x600@72Hz
          800x600@75Hz
          832x624@75Hz
          1024x768@60Hz
          1024x768@70Hz
          1024x768@75Hz
          1280x1024@75Hz
        Standard timings supported:
          1152x864@75Hz
          1280x1024@60Hz
          1280x960@60Hz
          1440x900@60Hz
          1600x1200@60Hz
          1680x1050@60Hz
        Detailed mode: Clock 146.250 MHz, 473 mm x 296 mm
                       1680 1784 1960 2240 hborder 0
                       1050 1053 1059 1089 vborder 0
                       -hsync +vsync 
        Monitor ranges (GTF): 56-75Hz V, 31-81kHz H, max dotclock 170MHz
        Monitor name: VW222
        Serial number: 7BLMQC006310 
        Checksum: 0xd1 (valid)

So both advertise the same name and model. :(

> Else, I'm afraid the right thing to do is to revert the quirk.

Yes, the no regression rule.

> I will provide the log files as soon as I'm back with that monitor,
> which should be next year... (Means tomorrow or the day after)

Awesome. When you find out the graphics chip and you are near the
monitor it would be awesome, if you could also connect a to a system
with a different graphics chip so we can get an indication where the
problem might be.

So if nobody has a great idea, the roadmap looks as follows. Revert the
patch, find out why the graphics driver chokes on the reduced blanking
(report a bug) and commit the patch again.


Thanks,

Paul


[1] https://bugs.freedesktop.org/show_bug.cgi?id=17629#c15
Florian Mickler Jan. 4, 2013, 11:54 a.m. UTC | #8
Dear Paul,

On Tue, 01 Jan 2013 04:43:39 +0100
Paul Menzel <paulepanter@users.sourceforge.net> wrote:

> So if nobody has a great idea, the roadmap looks as follows. Revert the
> patch, find out why the graphics driver chokes on the reduced blanking
> (report a bug) and commit the patch again.

I reported a bug at: https://bugzilla.kernel.org/show_bug.cgi?id=52281

Regards,
Flo
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 75e252e..102346d 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -87,6 +87,9 @@  static struct edid_quirk {
 	int product_id;
 	u32 quirks;
 } edid_quirk_list[] = {
+	/* ASUS VW222S */
+	{ "ACI", 22a2, EDID_QUIRK_FORCE_REDUCED_BLANKING },
+
 	/* Acer AL1706 */
 	{ "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 },
 	/* Acer F51 */