| Message ID | 1357730128-23018-2-git-send-email-fabio.porcedda@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Greg, I'm sorry, In the previous email I used your wrong email address, in this email I've used your correct email address. Best regards Fabio Porcedda On Wed, Jan 9, 2013 at 12:15 PM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > For simple modules that contain a single platform_driver without any > additional setup code then ends up being a block of duplicated > boilerplate. This patch adds a new macro, > module_platform_driver_probe(), which replaces the > module_init()/module_exit() registrations with template functions. > > This macro use the same idea of module_platform_driver(). > > This macro is useful to stop the misuse of module_platform_driver() for > removing the platform_driver_probe() boilerplate. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Greg Kroah-Hartman (linuxfoundation.org) > --- > include/linux/platform_device.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h > index a9ded9a..c082c71 100644 > --- a/include/linux/platform_device.h > +++ b/include/linux/platform_device.h > @@ -204,6 +204,24 @@ static inline void platform_set_drvdata(struct platform_device *pdev, void *data > module_driver(__platform_driver, platform_driver_register, \ > platform_driver_unregister) > > +/* module_platform_driver_probe() - Helper macro for drivers that don't do > + * anything special in module init/exit. This eliminates a lot of > + * boilerplate. Each module may only use this macro once, and > + * calling it replaces module_init() and module_exit() > + */ > +#define module_platform_driver_probe(__platform_driver, __platform_probe) \ > +static int __init __platform_driver##_init(void) \ > +{ \ > + return platform_driver_probe(&(__platform_driver), \ > + __platform_probe); \ > +} \ > +module_init(__platform_driver##_init); \ > +static void __exit __platform_driver##_exit(void) \ > +{ \ > + platform_driver_unregister(&(__platform_driver)); \ > +} \ > +module_exit(__platform_driver##_exit); > + > extern struct platform_device *platform_create_bundle(struct platform_driver *driver, > int (*probe)(struct platform_device *), > struct resource *res, unsigned int n_res, > -- > 1.8.0.3 >
diff --git a/include/linux/platform_device.h b/include/linux/platform_device.h index a9ded9a..c082c71 100644 --- a/include/linux/platform_device.h +++ b/include/linux/platform_device.h @@ -204,6 +204,24 @@ static inline void platform_set_drvdata(struct platform_device *pdev, void *data module_driver(__platform_driver, platform_driver_register, \ platform_driver_unregister) +/* module_platform_driver_probe() - Helper macro for drivers that don't do + * anything special in module init/exit. This eliminates a lot of + * boilerplate. Each module may only use this macro once, and + * calling it replaces module_init() and module_exit() + */ +#define module_platform_driver_probe(__platform_driver, __platform_probe) \ +static int __init __platform_driver##_init(void) \ +{ \ + return platform_driver_probe(&(__platform_driver), \ + __platform_probe); \ +} \ +module_init(__platform_driver##_init); \ +static void __exit __platform_driver##_exit(void) \ +{ \ + platform_driver_unregister(&(__platform_driver)); \ +} \ +module_exit(__platform_driver##_exit); + extern struct platform_device *platform_create_bundle(struct platform_driver *driver, int (*probe)(struct platform_device *), struct resource *res, unsigned int n_res,
For simple modules that contain a single platform_driver without any additional setup code then ends up being a block of duplicated boilerplate. This patch adds a new macro, module_platform_driver_probe(), which replaces the module_init()/module_exit() registrations with template functions. This macro use the same idea of module_platform_driver(). This macro is useful to stop the misuse of module_platform_driver() for removing the platform_driver_probe() boilerplate. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> Cc: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/platform_device.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)