diff mbox

scripts: kconfig: qconf.cc: fix a compiliation error when using make xconfig

Message ID 1358047720-10358-1-git-send-email-rkmahefa@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Tiana Rakotovao Andriamahefa Jan. 13, 2013, 3:28 a.m. UTC
When using make xconfig, the following compilation error appears :
   /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.

Signed-off-by: Tiana Rakotovao Andriamahefa <rkmahefa@gmail.com>
---
 scripts/kconfig/qconf.cc |    1 +
 1 file changed, 1 insertion(+)

Comments

Michal Marek Jan. 13, 2013, 8:50 p.m. UTC | #1
On 13.1.2013 04:28, Tiana Rakotovao Andriamahefa wrote:
> When using make xconfig, the following compilation error appears :
>    /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
> Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.

This is a bug in the Qt header. Is Qt3 still maintained?

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tiana Rakotovao Andriamahefa Jan. 14, 2013, 12:54 a.m. UTC | #2
Le dimanche 13 janvier 2013 à 09:50:52, Michal Marek a écrit :
> On 13.1.2013 04:28, Tiana Rakotovao Andriamahefa wrote:
> > When using make xconfig, the following compilation error appears :
> >    /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
> > Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
> 
> This is a bug in the Qt header. Is Qt3 still maintained?

This seems to be a common c++ issue since the begining of 2011.

Some Qt3 headers use ptrdiff_t which is defined in stddef.h. They also use some 
c++ headers, and rely on them to include stddef.h. However, since GCC-4.6, 
those c++ headers do not include stddef.h anymore. So, include <stddef.h> 
fixes it.

This issue is reported here:  http://gcc.gnu.org/gcc-4.6/porting_to.html?
Michal Marek Jan. 15, 2013, 9:32 p.m. UTC | #3
On 14.1.2013 01:54, Tiana Rakotovao Andriamahefa wrote:
> Le dimanche 13 janvier 2013 à 09:50:52, Michal Marek a écrit :
>> On 13.1.2013 04:28, Tiana Rakotovao Andriamahefa wrote:
>>> When using make xconfig, the following compilation error appears :
>>>    /usr/include/qt3/qvaluelist.h:427:13: error: ‘ptrdiff_t’ does not name a type
>>> Including stddef.h in scripts/kconfig/qconf.cc permits to avoid this error.
>>
>> This is a bug in the Qt header. Is Qt3 still maintained?
> 
> This seems to be a common c++ issue since the begining of 2011.
> 
> Some Qt3 headers use ptrdiff_t which is defined in stddef.h. They also use some 
> c++ headers, and rely on them to include stddef.h. However, since GCC-4.6, 
> those c++ headers do not include stddef.h anymore. So, include <stddef.h> 
> fixes it.

Right. My question is - is Qt3 still maintained somehow, so the includes
can be added where they belong, or do we need to workaround in in the
applications?

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index df274fe..1500c38 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -6,6 +6,7 @@ 
 #include <qglobal.h>
 
 #if QT_VERSION < 0x040000
+#include <stddef.h>
 #include <qmainwindow.h>
 #include <qvbox.h>
 #include <qvaluelist.h>