| Message ID | 1359024920-32190-6-git-send-email-manishv.b@ti.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Jan 24, 2013 at 04:25:19PM +0530, Vishwanathrao Badarkhe, Manish wrote: > --- > arch/arm/boot/dts/tps6507x.dtsi | 47 +++++++++++++++++++++++++++++++++++++++ Why are you putting this in arch/arm?
Hi Mark, On Thu, Jan 24, 2013 at 17:30:51, Mark Brown wrote: > On Thu, Jan 24, 2013 at 04:25:19PM +0530, Vishwanathrao Badarkhe, Manish wrote: > > > --- > > arch/arm/boot/dts/tps6507x.dtsi | 47 +++++++++++++++++++++++++++++++++++++++ > > Why are you putting this in arch/arm? > I too doubt that whether it should be in architecture specific folder, My code is in reference to below patch: arm/dts: regulator: Add tps65910 device tree data(d5d08e2e1672da627d7c9d34a9dc1089c653e23a) Could you please suggest me if it can be moved somewhere else? Regards, Manish
On Fri, Jan 25, 2013 at 06:29:49AM +0000, Vishwanathrao Badarkhe, Manish wrote: > On Thu, Jan 24, 2013 at 17:30:51, Mark Brown wrote: > I too doubt that whether it should be in architecture specific folder, > My code is in reference to below patch: > arm/dts: regulator: Add tps65910 device tree data(d5d08e2e1672da627d7c9d34a9dc1089c653e23a) > Could you please suggest me if it can be moved somewhere else? We should have somewhere to put this sort of generic stuff, yes. Not sure where, possibly under drivers/of or some non-drivers part of the tree.
On Sat, Jan 26, 2013 at 10:42:08, Mark Brown wrote: > On Fri, Jan 25, 2013 at 06:29:49AM +0000, Vishwanathrao Badarkhe, Manish wrote: > > On Thu, Jan 24, 2013 at 17:30:51, Mark Brown wrote: > > > I too doubt that whether it should be in architecture specific folder, > > > My code is in reference to below patch: > > arm/dts: regulator: Add tps65910 device tree > > data(d5d08e2e1672da627d7c9d34a9dc1089c653e23a) > > > Could you please suggest me if it can be moved somewhere else? > > We should have somewhere to put this sort of generic stuff, yes. Not sure where, possibly under drivers/of or some non-drivers part of the tree. > Right now, nobody has put this kind of generic stuff other than architecture folder. Later on We can move these kind of generic stuff somewhere else in one shot. Regards, Manish
diff --git a/arch/arm/boot/dts/tps6507x.dtsi b/arch/arm/boot/dts/tps6507x.dtsi new file mode 100644 index 0000000..4ae483e --- /dev/null +++ b/arch/arm/boot/dts/tps6507x.dtsi @@ -0,0 +1,47 @@ +/* + * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +/* + * Integrated Power Management Chip + * http://www.ti.com/lit/ds/symlink/tps65070.pdf + */ + +&tps { + compatible = "ti,tps6507x"; + + regulators { + #address-cells = <1>; + #size-cells = <0>; + + vdcdc1_reg: regulator@0 { + reg = <0>; + regulator-compatible = "VDCDC1"; + }; + + vdcdc2_reg: regulator@1 { + reg = <1>; + regulator-compatible = "VDCDC2"; + }; + + vdcdc3_reg: regulator@2 { + reg = <2>; + regulator-compatible = "VDCDC3"; + }; + + ldo1_reg: regulator@3 { + reg = <3>; + regulator-compatible = "LDO1"; + }; + + ldo2_reg: regulator@4 { + reg = <4>; + regulator-compatible = "LDO2"; + }; + + }; +};
Add device tree data for tps6507x regulator by adding all tps6507x regulator nodes. Regulators are initialized based on compatible name provided in tps6507x DT file. All tps6507x PMIC regulator device tree nodes are placed in a separate device tree include file (tps6507x.dtsi). tps6507x.dtsi file is created using datasheet http://www.ti.com/lit/ds/symlink/tps65070.pdf Tested on da850-evm. Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com> --- arch/arm/boot/dts/tps6507x.dtsi | 47 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 47 insertions(+), 0 deletions(-) create mode 100644 arch/arm/boot/dts/tps6507x.dtsi