| Message ID | 51122147.6080708@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote: > > 'const static ' is not a common order, better to use 'const static' instead. You mean " use static const instead ", right ? > building: > make EXTRA_CFLAGS=-W ARCH=arm > > drivers/gpio/gpio-omap.c:1479: > warning: 'static' is not at beginning of declaration > drivers/gpio/gpio-omap.c:1485: > warning: 'static' is not at beginning of declaration > drivers/gpio/gpio-omap.c:1491: > warning: 'static' is not at beginning of declaration > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- With change log fixed, Acked-by: Santosh Shilimkar ,santosh.shilimkar@ti.com> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
? 2013?02?06? 17:36, Santosh Shilimkar ??: > On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote: >> > >> > 'const static ' is not a common order, better to use 'const static' instead. > You mean " use static const instead ", right ? > oh, yes. it is my miswritten. if necessary to send patch v2, please tell me. thanks. :-)
On Wednesday 06 February 2013 04:08 PM, Chen Gang wrote: > ? 2013?02?06? 17:36, Santosh Shilimkar ??: >> On Wednesday 06 February 2013 02:54 PM, Chen Gang wrote: >>>> >>>> 'const static ' is not a common order, better to use 'const static' instead. >> You mean " use static const instead ", right ? >> > > oh, yes. it is my miswritten. > > if necessary to send patch v2, please tell me. > Please do send updated version. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index f1fbedb2..159f5c5 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -1476,19 +1476,19 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = { .fallingdetect = OMAP4_GPIO_FALLINGDETECT, }; -const static struct omap_gpio_platform_data omap2_pdata = { +static const struct omap_gpio_platform_data omap2_pdata = { .regs = &omap2_gpio_regs, .bank_width = 32, .dbck_flag = false, }; -const static struct omap_gpio_platform_data omap3_pdata = { +static const struct omap_gpio_platform_data omap3_pdata = { .regs = &omap2_gpio_regs, .bank_width = 32, .dbck_flag = true, }; -const static struct omap_gpio_platform_data omap4_pdata = { +static const struct omap_gpio_platform_data omap4_pdata = { .regs = &omap4_gpio_regs, .bank_width = 32, .dbck_flag = true,
'const static ' is not a common order, better to use 'const static' instead. building: make EXTRA_CFLAGS=-W ARCH=arm drivers/gpio/gpio-omap.c:1479: warning: 'static' is not at beginning of declaration drivers/gpio/gpio-omap.c:1485: warning: 'static' is not at beginning of declaration drivers/gpio/gpio-omap.c:1491: warning: 'static' is not at beginning of declaration Signed-off-by: Chen Gang <gang.chen@asianux.com> --- drivers/gpio/gpio-omap.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)