diff mbox

drm/i915: Use HAS_L3_GPU_CACHE in i915_gem_l3_remap

Message ID 1360867567-20593-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter Feb. 14, 2013, 6:46 p.m. UTC 
Yet another remnant ... this might explain why l3 remapping didn't
really work on HSW.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
Spotted-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/i915_gem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ben Widawsky Feb. 14, 2013, 10:51 p.m. UTC | #1 
On Thu, Feb 14, 2013 at 07:46:07PM +0100, Daniel Vetter wrote:
> Yet another remnant ... this might explain why l3 remapping didn't
> really work on HSW.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
> Spotted-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
[snip]
Daniel Vetter Feb. 15, 2013, 10:10 a.m. UTC | #2 
On Thu, Feb 14, 2013 at 02:51:19PM -0800, Ben Widawsky wrote:
> On Thu, Feb 14, 2013 at 07:46:07PM +0100, Daniel Vetter wrote:
> > Yet another remnant ... this might explain why l3 remapping didn't
> > really work on HSW.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=57441
> > Spotted-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Queued for -next, thanks for the review.
-Daniel
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a367801..8413ffc 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3872,7 +3872,7 @@  void i915_gem_l3_remap(struct drm_device *dev)
 	u32 misccpctl;
 	int i;
 
-	if (!IS_IVYBRIDGE(dev))
+	if (!HAS_L3_GPU_CACHE(dev))
 		return;
 
 	if (!dev_priv->l3_parity.remap_info)