| Message ID | 1362045557-9123-1-git-send-email-jlec@gentoo.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Justin, All, On Thursday 28 February 2013 jlec@gentoo.org wrote: > When building ncurses with --with-termlib several symbols get moved from > libncurses.so to libtinfo.so. Thus when linking with libncurses.so, one > additionally needs to link with libtinfo.so. > > Ncurses provides a config script (ncurses5-config) to assist finding ncurses. > This patch makes use of it to detect the necessary libs for linking of the > ncurses nconfig dialog. I've queued that one in my tree, now, in branch yem-kconfig-for-next: https://www.gitorious.org/linux-kconfig/linux-kconfig Thank you! :-) Regards, Yann E. MORIN.
On 2013-02-28 10:59 +0100, jlec@gentoo.org wrote: > Ncurses provides a config script (ncurses5-config) to assist finding ncurses. > This patch makes use of it to detect the necessary libs for linking of the > ncurses nconfig dialog. That script is not necessarily called ncurses5-config, it might also be called ncurses6-config is ncurses is configured for a different ABI (--enable-ext-colors, --enable-ext-mouse). Although I would suspect that any distribution who does that provides a compatibility symlink. > scripts/kconfig/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > index 3091794..c372976 100644 > --- a/scripts/kconfig/Makefile > +++ b/scripts/kconfig/Makefile > @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ > > HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) > > -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses > +HOSTLOADLIBES_nconf = -lmenu -lpanel > +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \ > + || ncurses5-config --libs 2>/dev/null ) This will link with ncursesw, not ncurses. Probably not what you want, since nconf.h does not #include the right headers for that. On Debian/Ubuntu, there's also the problem that ncursesw5-config exists even if the libncursesw5-dev package is not installed, so this patch makes the build fail in such cases. Can we just call ncurses5-config and not ncursesw5-config, or are there any distros who ship the latter and not the former? Cheers, Sven -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 28/02/13 22:50, Sven Joachim wrote: > On 2013-02-28 10:59 +0100, jlec@gentoo.org wrote: > >> Ncurses provides a config script (ncurses5-config) to assist finding ncurses. >> This patch makes use of it to detect the necessary libs for linking of the >> ncurses nconfig dialog. > > That script is not necessarily called ncurses5-config, it might also be > called ncurses6-config is ncurses is configured for a different ABI > (--enable-ext-colors, --enable-ext-mouse). Although I would suspect > that any distribution who does that provides a compatibility symlink. > We don't do that, but I rechecked with building ncurses manually. You are right. How widely spread is the usage of this options? Or is it rather an experimental option? What we could do is simple extending the syntax to additionally check for the ABI version 6 config scripts. Is this an option to consider? >> scripts/kconfig/Makefile | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile >> index 3091794..c372976 100644 >> --- a/scripts/kconfig/Makefile >> +++ b/scripts/kconfig/Makefile >> @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ >> >> HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) >> >> -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses >> +HOSTLOADLIBES_nconf = -lmenu -lpanel >> +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \ >> + || ncurses5-config --libs 2>/dev/null ) > > This will link with ncursesw, not ncurses. Probably not what you want, > since nconf.h does not #include the right headers for that. > That's true, and again it would change two things at once. I will go back to simple -lncurses as it was before. > On Debian/Ubuntu, there's also the problem that ncursesw5-config exists > even if the libncursesw5-dev package is not installed, so this patch > makes the build fail in such cases. Will be solved when reverting as described above. But actually it smells like a bug in the package management, doesn't it? Why are build time config scripts shipped in runtime only packages? What is their purpose? > > Can we just call ncurses5-config and not ncursesw5-config, or are there > any distros who ship the latter and not the former? > I can't talk about distro wide situation, but manual building gives only one of the two. So there might be a situation where only one of the two is present. It seems we have a little dilemma here. Any suggestions how to solve it? Thanks, Justin
On 28/02/13 21:59, Yann E. MORIN wrote: > I've queued that one in my tree, now, in branch yem-kconfig-for-next: > https://www.gitorious.org/linux-kconfig/linux-kconfig > Thanks for queuing, but with the points which Sven mentioned we should first agree on a way to detect things. The simplest option which might only be present at very recent distro versions is using pkg-config. Second best is ncurses*5-config. There we have the strange situation that "ncurses-bin" contains the config scripts although no build time dependencies are installed along. Third, we might only find either of nurses{,w}5-config. And at last we might face the situation where the new ABI is used and the script is named ncurses{,w}6-config. Ugly but working would be a simple "||" chain. This would create problems on debian/ubuntu which needs to be solved. Any other suggestions how we can solve the problem? Thanks justin
On 2013-03-01 08:37 +0100, justin wrote: > On 28/02/13 22:50, Sven Joachim wrote: >> On 2013-02-28 10:59 +0100, jlec@gentoo.org wrote: >> >>> Ncurses provides a config script (ncurses5-config) to assist finding ncurses. >>> This patch makes use of it to detect the necessary libs for linking of the >>> ncurses nconfig dialog. >> >> That script is not necessarily called ncurses5-config, it might also be >> called ncurses6-config is ncurses is configured for a different ABI >> (--enable-ext-colors, --enable-ext-mouse). Although I would suspect >> that any distribution who does that provides a compatibility symlink. >> > > We don't do that, but I rechecked with building ncurses manually. You > are right. How widely spread is the usage of this options? Or is it > rather an experimental option? Pretty much, since it changes the ABI and everyone wants to be compatible with the existing ncurses ABI. > What we could do is simple extending the syntax to additionally check > for the ABI version 6 config scripts. Is this an option to consider? Probably. >>> scripts/kconfig/Makefile | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile >>> index 3091794..c372976 100644 >>> --- a/scripts/kconfig/Makefile >>> +++ b/scripts/kconfig/Makefile >>> @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ >>> >>> HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) >>> >>> -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses >>> +HOSTLOADLIBES_nconf = -lmenu -lpanel >>> +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \ >>> + || ncurses5-config --libs 2>/dev/null ) >> >> This will link with ncursesw, not ncurses. Probably not what you want, >> since nconf.h does not #include the right headers for that. >> > > That's true, and again it would change two things at once. I will go > back to simple -lncurses as it was before. > >> On Debian/Ubuntu, there's also the problem that ncursesw5-config exists >> even if the libncursesw5-dev package is not installed, so this patch >> makes the build fail in such cases. > > Will be solved when reverting as described above. But actually it smells > like a bug in the package management, doesn't it? Why are build time > config scripts shipped in runtime only packages? What is their purpose? Historically it seems to be an accident, and the ncurses{w,5}-config scripts should have better been shipped in their development packages. But nowadays we want to make the development packages multiarch-aware, and since the scripts differ on architectures, moving them away from ncurses-bin would mean adding two additional binary packages just for these scripts. See http://bugs.debian.org/480437 for a discussion on that topic. >> Can we just call ncurses5-config and not ncursesw5-config, or are there >> any distros who ship the latter and not the former? >> > > I can't talk about distro wide situation, but manual building gives only > one of the two. So there might be a situation where only one of the two > is present. > > It seems we have a little dilemma here. Any suggestions how to solve it? Well, at least until nconf does not make any effort to explicitly detect and use the wide API, trying ncurses5-config first should work. If you build ncurses yourself with --enable-widec, there is no -lmenu or -lpanel anyway, these libraries are called menuw and panelw then. Cheers, Sven -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/03/13 09:36, Sven Joachim wrote: > Historically it seems to be an accident, and the ncurses{w,5}-config > scripts should have better been shipped in their development packages. > But nowadays we want to make the development packages multiarch-aware, > and since the scripts differ on architectures, moving them away from > ncurses-bin would mean adding two additional binary packages just for > these scripts. > > See http://bugs.debian.org/480437 for a discussion on that topic. > I just tested on an ubuntu installation what happens with the patches applied; you simply end up with the warning the you need to install the dev package. So I don't see any problem here. > Well, at least until nconf does not make any effort to explicitly detect > and use the wide API, trying ncurses5-config first should work. If you > build ncurses yourself with --enable-widec, there is no -lmenu or -lpanel > anyway, these libraries are called menuw and panelw then. You are right, we only should consider ncurses5-config right now. Regards, Justin
On 2013-03-01 14:47 +0100, justin wrote: > On 01/03/13 09:36, Sven Joachim wrote: >> Historically it seems to be an accident, and the ncurses{w,5}-config >> scripts should have better been shipped in their development packages. >> But nowadays we want to make the development packages multiarch-aware, >> and since the scripts differ on architectures, moving them away from >> ncurses-bin would mean adding two additional binary packages just for >> these scripts. >> >> See http://bugs.debian.org/480437 for a discussion on that topic. >> > > I just tested on an ubuntu installation what happens with the patches > applied; you simply end up with the warning the you need to install the > dev package. So I don't see any problem here. Well, in Debian/Ubuntu are _two_ dev packages, one for the wide API (libncursesw5-dev), and on for the non-wide API (libncurses5-dev). Only the latter should be necessary, but with your original patch people would need to install the former as well. >> Well, at least until nconf does not make any effort to explicitly detect >> and use the wide API, trying ncurses5-config first should work. If you >> build ncurses yourself with --enable-widec, there is no -lmenu or -lpanel >> anyway, these libraries are called menuw and panelw then. > > You are right, we only should consider ncurses5-config right now. That seems unlikely to cause regressions on its own. Cheers, Sven -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sven, Justin, All, Sorry for the delay... On Thursday 28 February 2013 Sven Joachim wrote: > On 2013-02-28 10:59 +0100, jlec@gentoo.org wrote: > > > Ncurses provides a config script (ncurses5-config) to assist finding ncurses. > > This patch makes use of it to detect the necessary libs for linking of the > > ncurses nconfig dialog. > > That script is not necessarily called ncurses5-config, it might also be > called ncurses6-config is ncurses is configured for a different ABI > (--enable-ext-colors, --enable-ext-mouse). Although I would suspect > that any distribution who does that provides a compatibility symlink. Cygwin does provide nurses{,w}{5,6}-config. > > scripts/kconfig/Makefile | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > > index 3091794..c372976 100644 > > --- a/scripts/kconfig/Makefile > > +++ b/scripts/kconfig/Makefile > > @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ > > > > HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) > > > > -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses > > +HOSTLOADLIBES_nconf = -lmenu -lpanel > > +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \ > > + || ncurses5-config --libs 2>/dev/null ) > > This will link with ncursesw, not ncurses. Probably not what you want, > since nconf.h does not #include the right headers for that. > > On Debian/Ubuntu, there's also the problem that ncursesw5-config exists > even if the libncursesw5-dev package is not installed, so this patch > makes the build fail in such cases. The same goes for ncurses5-config, which is provided by ncurses-bin, and so is present even if the devel package is not installed, and the build will break, too. Regards, Yann E. MORIN.
On 2013-03-03 21:23 +0100, Yann E. MORIN wrote: > On Thursday 28 February 2013 Sven Joachim wrote: >> On 2013-02-28 10:59 +0100, jlec@gentoo.org wrote: > >> > scripts/kconfig/Makefile | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile >> > index 3091794..c372976 100644 >> > --- a/scripts/kconfig/Makefile >> > +++ b/scripts/kconfig/Makefile >> > @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ >> > >> > HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) >> > >> > -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses >> > +HOSTLOADLIBES_nconf = -lmenu -lpanel >> > +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \ >> > + || ncurses5-config --libs 2>/dev/null ) >> >> This will link with ncursesw, not ncurses. Probably not what you want, >> since nconf.h does not #include the right headers for that. >> >> On Debian/Ubuntu, there's also the problem that ncursesw5-config exists >> even if the libncursesw5-dev package is not installed, so this patch >> makes the build fail in such cases. > > The same goes for ncurses5-config, which is provided by ncurses-bin, and > so is present even if the devel package is not installed, and the build > will break, too. This is not the same: if libncurses5-dev is not installed, the build is going to fail anyway, since there is no -lmenu or -lpanel then. I second the proposal to try pkg-config and fall back to -lncurses, BTW. Cheers, Sven -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 3091794..c372976 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -216,7 +216,9 @@ HOSTCFLAGS_gconf.o = `pkg-config --cflags gtk+-2.0 gmodule-2.0 libglade-2.0` \ HOSTLOADLIBES_mconf = $(shell $(CONFIG_SHELL) $(check-lxdialog) -ldflags $(HOSTCC)) -HOSTLOADLIBES_nconf = -lmenu -lpanel -lncurses +HOSTLOADLIBES_nconf = -lmenu -lpanel +HOSTLOADLIBES_nconf += $(shell ncursesw5-config --libs 2>/dev/null \ + || ncurses5-config --libs 2>/dev/null ) $(obj)/qconf.o: $(obj)/.tmp_qtcheck ifeq ($(qconf-target),1)