| Message ID | 1362476098.16460.65.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Paul, On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote: > Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to > DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's > Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which > makes this select statement a nop. Since the Marvell Dove code includes > <linux/clk-provider.h> we can assume that this entry needs to select > COMMON_CLK instead. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Untested. > > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Nice catch, thanks for the patch. Sebastian, could you test this and report back? thx, Jason.
On Tue, 5 Mar 2013 09:00:25 -0500 Jason Cooper <jason@lakedaemon.net> wrote: > On Tue, Mar 05, 2013 at 10:34:58AM +0100, Paul Bolle wrote: > > Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to > > DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's > > Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which > > makes this select statement a nop. Since the Marvell Dove code includes > > <linux/clk-provider.h> we can assume that this entry needs to select > > COMMON_CLK instead. > > > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > > --- > > Untested. > > > > arch/arm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Nice catch, thanks for the patch. Sebastian, could you test this and > report back? I also have a Cubox and I generated a kernel 3.9-rc1 for it (not tested yet). The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects COMMON_CLK. So, "select COMMON_CLK" is not needed in ARCH_DOVE. BTW, why is there a PLAT_ORION_LEGACY?
On Tue, 2013-03-05 at 19:02 +0100, Jean-Francois Moine wrote: > The .config contains CONFIG_COMMON_CLK=y naturally because MACH_DOVE > selects PLAT_ORION_LEGACY which selects PLAT_ORION which selects > COMMON_CLK. > > So, "select COMMON_CLK" is not needed in ARCH_DOVE. Thanks. Unless people object (because they prefer an explicit, though superfluous, select of COMMON_CLK) I'll redo my patch. Paul Bolle
On 03/05/2013 10:34 AM, Paul Bolle wrote: > Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to > DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's > Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which > makes this select statement a nop. Since the Marvell Dove code includes > <linux/clk-provider.h> we can assume that this entry needs to select > COMMON_CLK instead. > > Signed-off-by: Paul Bolle<pebolle@tiscali.nl> > --- > Untested. > > arch/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 5b71469..31acce7 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -556,7 +556,7 @@ config ARCH_IXP4XX > config ARCH_DOVE > bool "Marvell Dove" > select ARCH_REQUIRE_GPIOLIB > - select COMMON_CLK_DOVE > + select COMMON_CLK > select CPU_V7 > select GENERIC_CLOCKEVENTS > select MIGHT_HAVE_PCI Paul, thanks for the patch but I guess COMMON_CLK_DOVE is a left-over from early DT experiments with Dove. It should just be removed from arm/Kconfig. Thanks for pointing it out, and it would be great to update your patch accordingly. Sebastian
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 5b71469..31acce7 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -556,7 +556,7 @@ config ARCH_IXP4XX config ARCH_DOVE bool "Marvell Dove" select ARCH_REQUIRE_GPIOLIB - select COMMON_CLK_DOVE + select COMMON_CLK select CPU_V7 select GENERIC_CLOCKEVENTS select MIGHT_HAVE_PCI
Commit 5b03df9ace680d7cdd34a69dfd85ca5f74159d18 ("ARM: dove: switch to DT clock providers") added "select COMMON_CLK_DOVE" to Marvell Dove's Kconfig entry. But there's no Kconfig symbol COMMON_CLK_DOVE, which makes this select statement a nop. Since the Marvell Dove code includes <linux/clk-provider.h> we can assume that this entry needs to select COMMON_CLK instead. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. arch/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)