| Message ID | 1362609234.28137.2.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Paul Bolle wrote: > > The unused Kconfig symbol MACH_N35 was removed in commit > 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c ("ARM: S3C2410: move > mach-s3c2410/* into mach-s3c24xx/"). But there is still one (pointless) > select statement for that symbol. Drop it. > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > arch/arm/mach-s3c24xx/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig > index 37f513d..7361b9d 100644 > --- a/arch/arm/mach-s3c24xx/Kconfig > +++ b/arch/arm/mach-s3c24xx/Kconfig > @@ -320,7 +320,6 @@ config PM_H1940 > > config MACH_N30 > bool "Acer N30 family" > - select MACH_N35 > select S3C_DEV_NAND > select S3C_DEV_USB_HOST > help > -- > 1.7.11.7 Yes, right. Applied, thanks. BTW, so the machine type can be removed at arch/arm/tools/mach-types as well. - Kukjin
On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote:
> BTW, so the machine type can be removed at arch/arm/tools/mach-types as well.
Well, that file has a big comment on top, containing the line:
Please do not send patches to this file; it is automatically
generated!
So I didn't dare to touch it.
Paul Bolle
Paul Bolle wrote: > > On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote: > > > BTW, so the machine type can be removed at arch/arm/tools/mach-types as > well. > > Well, that file has a big comment on top, containing the line: > Please do not send patches to this file; it is automatically > generated! > > So I didn't dare to touch it. > Yeah, I know. It will be handled by Russell King :-) Thanks. - Kukjin
On Thu, Mar 07, 2013 at 09:50:17AM +0900, Kukjin Kim wrote: > Paul Bolle wrote: > > > > On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote: > > > > > BTW, so the machine type can be removed at arch/arm/tools/mach-types as > > well. > > > > Well, that file has a big comment on top, containing the line: > > Please do not send patches to this file; it is automatically > > generated! > > > > So I didn't dare to touch it. > > > Yeah, I know. > > It will be handled by Russell King :-) And deleting entries from it is pointless if they've ever been in the kernel.
Russell King - ARM Linux wrote: > > On Thu, Mar 07, 2013 at 09:50:17AM +0900, Kukjin Kim wrote: > > Paul Bolle wrote: > > > > > > On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote: > > > > > > > BTW, so the machine type can be removed at arch/arm/tools/mach-types > as > > > well. > > > > > > Well, that file has a big comment on top, containing the line: > > > Please do not send patches to this file; it is automatically > > > generated! > > > > > > So I didn't dare to touch it. > > > > > Yeah, I know. > > > > It will be handled by Russell King :-) > > And deleting entries from it is pointless if they've ever been in the > kernel. OK, I see and agree. Thanks. - Kukjin
On Thu, Mar 07, 2013 at 10:14:19AM +0900, Kukjin Kim wrote: > Russell King - ARM Linux wrote: > > And deleting entries from it is pointless if they've ever been in the > > kernel. > > OK, I see and agree. The issue is that the database system "locks" an entry into the file as soon as support is merged into mainline for the platform. The reason for this is that as soon as the support gets merged into a kernel verison, that symbol is then referenced. If anyone goes to the website to download a new copy of the file, it then must continue to contain that symbol because they may be using the file with any kernel version - maybe a version of the kernel with your platform support in - and maybe they're using something that references the generated ID/macros from your entry. Updates to the file in the mainline kernel are merely re-downloads of the file from the website and committed. So, deleting entries once used in mainline is extremely problematical. If someone commits such a patch, my next update from the website/database to the file will put it back. Hence the problem.
diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index 37f513d..7361b9d 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -320,7 +320,6 @@ config PM_H1940 config MACH_N30 bool "Acer N30 family" - select MACH_N35 select S3C_DEV_NAND select S3C_DEV_USB_HOST help
The unused Kconfig symbol MACH_N35 was removed in commit 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c ("ARM: S3C2410: move mach-s3c2410/* into mach-s3c24xx/"). But there is still one (pointless) select statement for that symbol. Drop it. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- arch/arm/mach-s3c24xx/Kconfig | 1 - 1 file changed, 1 deletion(-)