| Message ID | 1362571461-14570-1-git-send-email-thomas.abraham@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 6, 2013 at 1:04 PM, Thomas Abraham <thomas.abraham@linaro.org> wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hi Thomas, On Wednesday, March 06, 2013, Thomas Abraham wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. 'setup_bus' callback is still useful in dw_mci_drv_data? Considering the purpose, it would be good to remove. And, could you change commit prefix for consistency? dwmmc -> dw_mmc Thanks, Seungwon Jeon > > Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> > --- > drivers/mmc/host/dw_mmc-exynos.c | 38 -------------------------------------- > 1 files changed, 0 insertions(+), 38 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index 72fd0f2..467d043 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -152,43 +152,6 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) > return 0; > } > > -static int dw_mci_exynos_setup_bus(struct dw_mci *host, > - struct device_node *slot_np, u8 bus_width) > -{ > - int idx, gpio, ret; > - > - if (!slot_np) > - return -EINVAL; > - > - /* cmd + clock + bus-width pins */ > - for (idx = 0; idx < NUM_PINS(bus_width); idx++) { > - gpio = of_get_gpio(slot_np, idx); > - if (!gpio_is_valid(gpio)) { > - dev_err(host->dev, "invalid gpio: %d\n", gpio); > - return -EINVAL; > - } > - > - ret = devm_gpio_request(host->dev, gpio, "dw-mci-bus"); > - if (ret) { > - dev_err(host->dev, "gpio [%d] request failed\n", gpio); > - return -EBUSY; > - } > - } > - > - if (host->pdata->quirks & DW_MCI_QUIRK_BROKEN_CARD_DETECTION) > - return 0; > - > - gpio = of_get_named_gpio(slot_np, "samsung,cd-pinmux-gpio", 0); > - if (gpio_is_valid(gpio)) { > - if (devm_gpio_request(host->dev, gpio, "dw-mci-cd")) > - dev_err(host->dev, "gpio [%d] request failed\n", gpio); > - } else { > - dev_info(host->dev, "cd gpio not available"); > - } > - > - return 0; > -} > - > /* Exynos5250 controller specific capabilities */ > static unsigned long exynos5250_dwmmc_caps[4] = { > MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR | > @@ -205,7 +168,6 @@ static const struct dw_mci_drv_data exynos5250_drv_data = { > .prepare_command = dw_mci_exynos_prepare_command, > .set_ios = dw_mci_exynos_set_ios, > .parse_dt = dw_mci_exynos_parse_dt, > - .setup_bus = dw_mci_exynos_setup_bus, > }; > > static const struct of_device_id dw_mci_exynos_match[] = { > -- > 1.6.6.rc2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Thomas, On Wed, Mar 6, 2013 at 4:04 AM, Thomas Abraham <thomas.abraham@linaro.org> wrote: > With device core now able to setup the default pin configuration, > the pin configuration code based on the deprecated Samsung specific > gpio bindings is removed. > > Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> > --- > drivers/mmc/host/dw_mmc-exynos.c | 38 -------------------------------------- > 1 files changed, 0 insertions(+), 38 deletions(-) It would be good to address Seungwon Jeon's comments (change prefix to dw_mmc and remove setup_bus), but in general this looks good to me, so... With <https://patchwork.kernel.org/patch/2225151/> on exynos5250-snow (ARM Chromebook): Reviewed-by: Doug Anderson <dianders@chromium.org> Tested-by: Doug Anderson <dianders@chromium.org> -Doug
Thomas, On Mon, Mar 11, 2013 at 10:53 AM, Doug Anderson <dianders@google.com> wrote: > It would be good to address Seungwon Jeon's comments (change prefix to > dw_mmc and remove setup_bus), but in general this looks good to me, > so... Are you planning on doing this? I noticed that Chris pulled your sdhci-s3c change in recently but apparently skipped this one since it had outstanding comments. Can you address comments and re-send? This is blocking pinmux dts stuff from landing (I think) and that blocks a lot of other things from landing. The comments are pretty trivial, so I could always fix them and re-send myself, but it would be better if you could do it... :) -Doug
Thomas, On Mon, Mar 25, 2013 at 9:56 AM, Doug Anderson <dianders@google.com> wrote: > Are you planning on doing this? I noticed that Chris pulled your > sdhci-s3c change in recently but apparently skipped this one since it > had outstanding comments. Can you address comments and re-send? This > is blocking pinmux dts stuff from landing (I think) and that blocks a > lot of other things from landing. > > The comments are pretty trivial, so I could always fix them and > re-send myself, but it would be better if you could do it... :) I didn't hear anything last week and it's getting pretty late in the process. I'll post something tomorrow if I don't hear from you... -Doug
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 72fd0f2..467d043 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -152,43 +152,6 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) return 0; } -static int dw_mci_exynos_setup_bus(struct dw_mci *host, - struct device_node *slot_np, u8 bus_width) -{ - int idx, gpio, ret; - - if (!slot_np) - return -EINVAL; - - /* cmd + clock + bus-width pins */ - for (idx = 0; idx < NUM_PINS(bus_width); idx++) { - gpio = of_get_gpio(slot_np, idx); - if (!gpio_is_valid(gpio)) { - dev_err(host->dev, "invalid gpio: %d\n", gpio); - return -EINVAL; - } - - ret = devm_gpio_request(host->dev, gpio, "dw-mci-bus"); - if (ret) { - dev_err(host->dev, "gpio [%d] request failed\n", gpio); - return -EBUSY; - } - } - - if (host->pdata->quirks & DW_MCI_QUIRK_BROKEN_CARD_DETECTION) - return 0; - - gpio = of_get_named_gpio(slot_np, "samsung,cd-pinmux-gpio", 0); - if (gpio_is_valid(gpio)) { - if (devm_gpio_request(host->dev, gpio, "dw-mci-cd")) - dev_err(host->dev, "gpio [%d] request failed\n", gpio); - } else { - dev_info(host->dev, "cd gpio not available"); - } - - return 0; -} - /* Exynos5250 controller specific capabilities */ static unsigned long exynos5250_dwmmc_caps[4] = { MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR | @@ -205,7 +168,6 @@ static const struct dw_mci_drv_data exynos5250_drv_data = { .prepare_command = dw_mci_exynos_prepare_command, .set_ios = dw_mci_exynos_set_ios, .parse_dt = dw_mci_exynos_parse_dt, - .setup_bus = dw_mci_exynos_setup_bus, }; static const struct of_device_id dw_mci_exynos_match[] = {
With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> --- drivers/mmc/host/dw_mmc-exynos.c | 38 -------------------------------------- 1 files changed, 0 insertions(+), 38 deletions(-)